Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Bruce Evans
On Sun, 16 Sep 2012, Chris Rees wrote: On 16 September 2012 18:41, Ian Lepore wrote: On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote: On 16 Sep 2012 16:19, "David Chisnall" wrote: On 16 Sep 2012, at 10:37, Chris Rees wrote: Actually: for (;;) ; This form will generate a com

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Julian Elischer
On 9/16/12 3:07 AM, Chris Rees wrote: On 16 Sep 2012 10:53, "Alexey Dokuchaev" > wrote: > > On Sun, Sep 16, 2012 at 10:37:56AM +0100, Chris Rees wrote: > > On 16 September 2012 10:28, Alexey Dokuchaev > wrote: > > > I thought preferred and m

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Eitan Adler
On 16 September 2012 13:45, Chris Rees wrote: > On 16 September 2012 18:41, Ian Lepore wrote: >> On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote: >>> On 16 Sep 2012 16:19, "David Chisnall" wrote: >>> > >>> > On 16 Sep 2012, at 10:37, Chris Rees wrote: >>> > >>> > > Actually: >>> > > >>> > >

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Alexey Dokuchaev
On Sun, Sep 16, 2012 at 06:45:30PM +0100, Chris Rees wrote: > On 16 September 2012 18:41, Ian Lepore wrote: > > One of the examples allows > > > > for (;;) > > stmt; > > > > Using "continue;" as the statement is consistant with that. > > Ok, so with approval from a docs/src guy I'd li

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Chris Rees
On 16 September 2012 18:41, Ian Lepore wrote: > On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote: >> On 16 Sep 2012 16:19, "David Chisnall" wrote: >> > >> > On 16 Sep 2012, at 10:37, Chris Rees wrote: >> > >> > > Actually: >> > > >> > > for (;;) >> > >; >> > >> > This form will generat

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Ian Lepore
On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote: > On 16 Sep 2012 16:19, "David Chisnall" wrote: > > > > On 16 Sep 2012, at 10:37, Chris Rees wrote: > > > > > Actually: > > > > > > for (;;) > > >; > > > > This form will generate a compiler warning, because it looks like a > missing loo

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Chris Rees
On 16 Sep 2012 16:19, "David Chisnall" wrote: > > On 16 Sep 2012, at 10:37, Chris Rees wrote: > > > Actually: > > > > for (;;) > >; > > This form will generate a compiler warning, because it looks like a missing loop body. You can silence the warning by this form: > > for (;;) {} > > This

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread David Chisnall
On 16 Sep 2012, at 10:37, Chris Rees wrote: > Actually: > > for (;;) >; This form will generate a compiler warning, because it looks like a missing loop body. You can silence the warning by this form: for (;;) {} This makes it clear that you have an explicit body containing no statem

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread mdf
On Sun, Sep 16, 2012 at 2:53 AM, Alexey Dokuchaev wrote: > On Sun, Sep 16, 2012 at 10:37:56AM +0100, Chris Rees wrote: >> On 16 September 2012 10:28, Alexey Dokuchaev wrote: >> > I thought preferred and more style(9) compliant way to code [empty >> > endless loop] is: >> > >> > for (;;) >

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Chris Rees
On 16 Sep 2012 10:53, "Alexey Dokuchaev" wrote: > > On Sun, Sep 16, 2012 at 10:37:56AM +0100, Chris Rees wrote: > > On 16 September 2012 10:28, Alexey Dokuchaev wrote: > > > I thought preferred and more style(9) compliant way to code [empty > > > endless loop] is: > > > > > > for (;;) > >

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Alexey Dokuchaev
On Sun, Sep 16, 2012 at 10:37:56AM +0100, Chris Rees wrote: > On 16 September 2012 10:28, Alexey Dokuchaev wrote: > > I thought preferred and more style(9) compliant way to code [empty > > endless loop] is: > > > > for (;;) > > continue; > > Actually: > > for (;;) >

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Chris Rees
On 16 September 2012 10:28, Alexey Dokuchaev wrote: > On Sun, Sep 16, 2012 at 07:55:49AM +, Andrew Turner wrote: >> New Revision: 240549 >> URL: http://svn.freebsd.org/changeset/base/240549 >> >> Log: >> The cpu_reset function is noreturn, make sure this is true on Tegra 2. >> While here f

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Alexey Dokuchaev
On Sun, Sep 16, 2012 at 07:55:49AM +, Andrew Turner wrote: > New Revision: 240549 > URL: http://svn.freebsd.org/changeset/base/240549 > > Log: > The cpu_reset function is noreturn, make sure this is true on Tegra 2. > While here fix a typo. > > + > + while(1); I thought preferred an

svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread Andrew Turner
Author: andrew Date: Sun Sep 16 07:55:49 2012 New Revision: 240549 URL: http://svn.freebsd.org/changeset/base/240549 Log: The cpu_reset function is noreturn, make sure this is true on Tegra 2. While here fix a typo. Modified: head/sys/arm/tegra/common.c Modified: head/sys/arm/tegra/common.