On Fri, 1 Jun 2012, John Baldwin wrote:
On Friday, June 01, 2012 12:39:48 pm Eitan Adler wrote:
On 1 June 2012 07:24, John Baldwin wrote:
This is why I personally loathe assignment side effects in boolean expressions
for control flow. I tend to write this sort of thing instead as:
ch
On Friday, June 01, 2012 12:39:48 pm Eitan Adler wrote:
> On 1 June 2012 07:24, John Baldwin wrote:
> > This is why I personally loathe assignment side effects in boolean
> > expressions
> > for control flow. I tend to write this sort of thing instead as:
> >
> >channel->dtr_arr[dtr_inde
On 1 June 2012 07:24, John Baldwin wrote:
> This is why I personally loathe assignment side effects in boolean expressions
> for control flow. I tend to write this sort of thing instead as:
>
> channel->dtr_arr[dtr_index].dtr = dtrh;
> if (dtrh != NULL) {
Same here. I was told to u
On Fri, 1 Jun 2012, John Baldwin wrote:
On Friday, June 01, 2012 2:23:42 am Eitan Adler wrote:
On 31 May 2012 22:13, Bruce Evans wrote:
This seems to change a style by (excessive parentheses for a normal
equality test) into logic bug (assignment of dtrh instead of compariing
with it).
inten
On Friday, June 01, 2012 2:23:42 am Eitan Adler wrote:
> On 31 May 2012 22:13, Bruce Evans wrote:
> > This seems to change a style by (excessive parentheses for a normal
> > equality test) into logic bug (assignment of dtrh instead of compariing
> > with it).
>
> intentional - perhaps my commit m
On 31 May 2012 22:13, Bruce Evans wrote:
> This seems to change a style by (excessive parentheses for a normal
> equality test) into logic bug (assignment of dtrh instead of compariing
> with it).
intentional - perhaps my commit message was poorly worded.
The comment above says
283 /*
28
On Fri, 1 Jun 2012, Eitan Adler wrote:
Author: eadler
Date: Fri Jun 1 04:23:20 2012
New Revision: 236377
URL: http://svn.freebsd.org/changeset/base/236377
Log:
Fix warning generated by clang;
warning: equality comparison with extraneous parentheses
[-Wparentheses-equality]
R
Author: eadler
Date: Fri Jun 1 04:23:20 2012
New Revision: 236377
URL: http://svn.freebsd.org/changeset/base/236377
Log:
Fix warning generated by clang;
warning: equality comparison with extraneous parentheses
[-Wparentheses-equality]
Reported by: arundel
Reviewed by: g
