Re: svn commit: r232271 - head/sys/kern

2012-02-29 Thread Bruce Evans
On Wed, 29 Feb 2012, Dimitry Andric wrote: On 2012-02-28 23:11, Giovanni Trematerra wrote: On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric wrote: ... It introduces a style(9) violation, though. I think it should be in this way pipe_chmod(struct file *fp, mode_t mode, struct ucred *active_c

Re: svn commit: r232271 - head/sys/kern

2012-02-28 Thread Dimitry Andric
On 2012-02-28 23:11, Giovanni Trematerra wrote: > On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric wrote: >> Author: dim >> Date: Tue Feb 28 21:45:21 2012 >> New Revision: 232271 >> URL: http://svn.freebsd.org/changeset/base/232271 ... > It introduces a style(9) violation, though. > I think it sho

Re: svn commit: r232271 - head/sys/kern

2012-02-28 Thread Giovanni Trematerra
On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric wrote: > Author: dim > Date: Tue Feb 28 21:45:21 2012 > New Revision: 232271 > URL: http://svn.freebsd.org/changeset/base/232271 > > Log: >  Change definition of pipe_chmod() from K&R to C99, to avoid the >  following clang warning: > >  sys/kern/sy

svn commit: r232271 - head/sys/kern

2012-02-28 Thread Dimitry Andric
Author: dim Date: Tue Feb 28 21:45:21 2012 New Revision: 232271 URL: http://svn.freebsd.org/changeset/base/232271 Log: Change definition of pipe_chmod() from K&R to C99, to avoid the following clang warning: sys/kern/sys_pipe.c:1556:10: error: promoted type 'int' of K&R function paramete