Re: svn commit: r227778 - head/sys/net

2011-12-14 Thread Julien Ridoux
On 04/12/2011, at 11:31 PM, Lawrence Stewart wrote: > On 12/03/11 12:02, Jung-uk Kim wrote: >> On Friday 02 December 2011 07:27 pm, Jung-uk Kim wrote: >>> On Thursday 01 December 2011 11:43 pm, Lawrence Stewart wrote: On 12/02/11 03:43, Jung-uk Kim wrote: > On Thursday 01 December 2011 1

Re: svn commit: r227778 - head/sys/net

2011-12-04 Thread Lawrence Stewart
On 12/03/11 12:02, Jung-uk Kim wrote: On Friday 02 December 2011 07:27 pm, Jung-uk Kim wrote: On Thursday 01 December 2011 11:43 pm, Lawrence Stewart wrote: On 12/02/11 03:43, Jung-uk Kim wrote: On Thursday 01 December 2011 10:11 am, Lawrence Stewart wrote: On 11/30/11 05:09, Jung-uk Kim wrot

Re: svn commit: r227778 - head/sys/net

2011-12-02 Thread Julien Ridoux
On 03/12/2011, at 12:02 PM, Jung-uk Kim wrote: [snip] > > - The snippet of code at the beginning of catchpacket() that > was manipulating the struct bintime derived from bpf_gettime() > was gross and has been removed in favour of selecting the > right {get}bin{up}time() func

Re: svn commit: r227778 - head/sys/net

2011-12-02 Thread Benjamin Kaduk
On Fri, 2 Dec 2011, Jung-uk Kim wrote: On Friday 02 December 2011 07:27 pm, Jung-uk Kim wrote: Please see my patch: http://people.freebsd.org/~jkim/bpf_ffclock.diff I booted up the kernel and found it just crashes because of stupid typos. Now a new patch is uploaded in place. Sorry. Anyw

Re: svn commit: r227778 - head/sys/net

2011-12-02 Thread Jung-uk Kim
On Friday 02 December 2011 07:27 pm, Jung-uk Kim wrote: > On Thursday 01 December 2011 11:43 pm, Lawrence Stewart wrote: > > On 12/02/11 03:43, Jung-uk Kim wrote: > > > On Thursday 01 December 2011 10:11 am, Lawrence Stewart wrote: > > >> On 11/30/11 05:09, Jung-uk Kim wrote: > > >>> On Tuesday 29

Re: svn commit: r227778 - head/sys/net

2011-12-02 Thread Jung-uk Kim
On Thursday 01 December 2011 11:43 pm, Lawrence Stewart wrote: > On 12/02/11 03:43, Jung-uk Kim wrote: > > On Thursday 01 December 2011 10:11 am, Lawrence Stewart wrote: > >> On 11/30/11 05:09, Jung-uk Kim wrote: > >>> On Tuesday 29 November 2011 11:13 am, Lawrence Stewart wrote: > On 11/30/11

Re: svn commit: r227778 - head/sys/net

2011-12-01 Thread Lawrence Stewart
On 12/02/11 03:43, Jung-uk Kim wrote: On Thursday 01 December 2011 10:11 am, Lawrence Stewart wrote: On 11/30/11 05:09, Jung-uk Kim wrote: On Tuesday 29 November 2011 11:13 am, Lawrence Stewart wrote: On 11/30/11 00:05, Lawrence Stewart wrote: On 11/28/11 14:59, Benjamin Kaduk wrote: On Wed,

Re: svn commit: r227778 - head/sys/net

2011-12-01 Thread Jung-uk Kim
On Thursday 01 December 2011 10:11 am, Lawrence Stewart wrote: > On 11/30/11 05:09, Jung-uk Kim wrote: > > On Tuesday 29 November 2011 11:13 am, Lawrence Stewart wrote: > >> On 11/30/11 00:05, Lawrence Stewart wrote: > >>> On 11/28/11 14:59, Benjamin Kaduk wrote: > On Wed, 23 Nov 2011, Lawrenc

Re: svn commit: r227778 - head/sys/net

2011-12-01 Thread Lawrence Stewart
On 11/30/11 05:09, Jung-uk Kim wrote: On Tuesday 29 November 2011 11:13 am, Lawrence Stewart wrote: On 11/30/11 00:05, Lawrence Stewart wrote: On 11/28/11 14:59, Benjamin Kaduk wrote: On Wed, 23 Nov 2011, Lawrence Stewart wrote: On 11/23/11 17:42, Julien Ridoux wrote: [snip] What is your

Re: svn commit: r227778 - head/sys/net

2011-11-29 Thread Jung-uk Kim
On Tuesday 29 November 2011 11:13 am, Lawrence Stewart wrote: > On 11/30/11 00:05, Lawrence Stewart wrote: > > On 11/28/11 14:59, Benjamin Kaduk wrote: > >> On Wed, 23 Nov 2011, Lawrence Stewart wrote: > >>> On 11/23/11 17:42, Julien Ridoux wrote: > > [snip] > > What is your favourite option?

Re: svn commit: r227778 - head/sys/net

2011-11-29 Thread Lawrence Stewart
On 11/30/11 00:05, Lawrence Stewart wrote: On 11/28/11 14:59, Benjamin Kaduk wrote: On Wed, 23 Nov 2011, Lawrence Stewart wrote: On 11/23/11 17:42, Julien Ridoux wrote: [snip] What is your favourite option? FreeBSD parlance is to ask what colour you would like to paint the bikeshed ;) As

Re: svn commit: r227778 - head/sys/net

2011-11-29 Thread Lawrence Stewart
On 11/28/11 14:59, Benjamin Kaduk wrote: On Wed, 23 Nov 2011, Lawrence Stewart wrote: On 11/23/11 17:42, Julien Ridoux wrote: Thanks all for the feedback. With some delay, I have a patch against r227871 that implements what Lawrence proposed. You can find it here: http://www.cubinlab.ee.unime

Re: svn commit: r227778 - head/sys/net

2011-11-28 Thread Lawrence Stewart
On 11/29/11 06:20, John Baldwin wrote: On Wednesday, November 23, 2011 2:37:05 am Lawrence Stewart wrote: On 11/23/11 17:42, Julien Ridoux wrote: On 23/11/2011, at 1:00 AM, Lawrence Stewart wrote: On 11/23/11 00:30, John Baldwin wrote: Think of standalone modules that are not built as part

Re: svn commit: r227778 - head/sys/net

2011-11-28 Thread John Baldwin
On Wednesday, November 23, 2011 2:37:05 am Lawrence Stewart wrote: > On 11/23/11 17:42, Julien Ridoux wrote: > > > > On 23/11/2011, at 1:00 AM, Lawrence Stewart wrote: > > > >> On 11/23/11 00:30, John Baldwin wrote: > >>> Think of standalone modules that are not built as part of a > >>> kernel (e.g

Re: svn commit: r227778 - head/sys/net

2011-11-27 Thread Benjamin Kaduk
On Wed, 23 Nov 2011, Lawrence Stewart wrote: On 11/23/11 17:42, Julien Ridoux wrote: Thanks all for the feedback. With some delay, I have a patch against r227871 that implements what Lawrence proposed. You can find it here: http://www.cubinlab.ee.unimelb.edu.au/~jrid/patches/ffclock-bpf-header

Re: svn commit: r227778 - head/sys/net

2011-11-22 Thread Lawrence Stewart
On 11/23/11 17:42, Julien Ridoux wrote: On 23/11/2011, at 1:00 AM, Lawrence Stewart wrote: On 11/23/11 00:30, John Baldwin wrote: On Monday, November 21, 2011 2:28:10 am Lawrence Stewart wrote: On 11/21/11 17:18, Julien Ridoux wrote: On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: On

Re: svn commit: r227778 - head/sys/net

2011-11-22 Thread Julien Ridoux
On 23/11/2011, at 1:00 AM, Lawrence Stewart wrote: > On 11/23/11 00:30, John Baldwin wrote: >> On Monday, November 21, 2011 2:28:10 am Lawrence Stewart wrote: >>> On 11/21/11 17:18, Julien Ridoux wrote: On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: > On 11/21/11 16:12, B

Re: svn commit: r227778 - head/sys/net

2011-11-22 Thread Benjamin Kaduk
On Tue, 22 Nov 2011, John Baldwin wrote: Think of standalone modules that are not built as part of a kernel (e.g. 3rd party device drivers). In general we should avoid having structures change size for kernel options, especially common structures. It just adds lots of pain and suffering and c

Re: svn commit: r227778 - head/sys/net

2011-11-22 Thread Lawrence Stewart
On 11/23/11 00:30, John Baldwin wrote: On Monday, November 21, 2011 2:28:10 am Lawrence Stewart wrote: On 11/21/11 17:18, Julien Ridoux wrote: On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: On 11/21/11 16:12, Ben Kaduk wrote: On Sun, Nov 20, 2011 at 11:17 PM, Lawrence Stewartwrote:

Re: svn commit: r227778 - head/sys/net

2011-11-22 Thread John Baldwin
On Monday, November 21, 2011 2:28:10 am Lawrence Stewart wrote: > On 11/21/11 17:18, Julien Ridoux wrote: > > > > On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: > > > >> On 11/21/11 16:12, Ben Kaduk wrote: > >>> On Sun, Nov 20, 2011 at 11:17 PM, Lawrence > >>> Stewart wrote: > Author: ls

Re: svn commit: r227778 - head/sys/net

2011-11-21 Thread Lawrence Stewart
On 11/21/11 20:52, Julien Ridoux wrote: On 21/11/2011, at 7:28 PM, Lawrence Stewart wrote: On 11/21/11 18:28, Lawrence Stewart wrote: On 11/21/11 17:18, Julien Ridoux wrote: On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: On 11/21/11 16:12, Ben Kaduk wrote: [snip] Is it really necess

Re: svn commit: r227778 - head/sys/net

2011-11-21 Thread Julien Ridoux
On 21/11/2011, at 7:28 PM, Lawrence Stewart wrote: > On 11/21/11 18:28, Lawrence Stewart wrote: >> On 11/21/11 17:18, Julien Ridoux wrote: >>> >>> On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: >>> On 11/21/11 16:12, Ben Kaduk wrote: > [snip] > Is it really necessary to make the AB

Re: svn commit: r227778 - head/sys/net

2011-11-21 Thread Lawrence Stewart
On 11/21/11 18:28, Lawrence Stewart wrote: On 11/21/11 17:18, Julien Ridoux wrote: On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: On 11/21/11 16:12, Ben Kaduk wrote: [snip] Is it really necessary to make the ABI dependent on a kernel configuration option? This causes all sorts of headac

Re: svn commit: r227778 - head/sys/net

2011-11-20 Thread Lawrence Stewart
On 11/21/11 17:18, Julien Ridoux wrote: On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: On 11/21/11 16:12, Ben Kaduk wrote: On Sun, Nov 20, 2011 at 11:17 PM, Lawrence Stewart wrote: Author: lstewart Date: Mon Nov 21 04:17:24 2011 New Revision: 227778 URL: http://svn.freebsd.org/changese

Re: svn commit: r227778 - head/sys/net

2011-11-20 Thread Garrett Cooper
On Sun, Nov 20, 2011 at 10:18 PM, Julien Ridoux wrote: > > On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: > >> On 11/21/11 16:12, Ben Kaduk wrote: >>> On Sun, Nov 20, 2011 at 11:17 PM, Lawrence Stewart   >>> wrote: Author: lstewart Date: Mon Nov 21 04:17:24 2011 New Revision: 22

Re: svn commit: r227778 - head/sys/net

2011-11-20 Thread Julien Ridoux
On 21/11/2011, at 4:39 PM, Lawrence Stewart wrote: > On 11/21/11 16:12, Ben Kaduk wrote: >> On Sun, Nov 20, 2011 at 11:17 PM, Lawrence Stewart >> wrote: >>> Author: lstewart >>> Date: Mon Nov 21 04:17:24 2011 >>> New Revision: 227778 >>> URL: http://svn.freebsd.org/changeset/base/227778 >>> >>

Re: svn commit: r227778 - head/sys/net

2011-11-20 Thread Lawrence Stewart
On 11/21/11 16:12, Ben Kaduk wrote: On Sun, Nov 20, 2011 at 11:17 PM, Lawrence Stewart wrote: Author: lstewart Date: Mon Nov 21 04:17:24 2011 New Revision: 227778 URL: http://svn.freebsd.org/changeset/base/227778 Log: - When feed-forward clock support is compiled in, change the BPF header to

Re: svn commit: r227778 - head/sys/net

2011-11-20 Thread Ben Kaduk
On Sun, Nov 20, 2011 at 11:17 PM, Lawrence Stewart wrote: > Author: lstewart > Date: Mon Nov 21 04:17:24 2011 > New Revision: 227778 > URL: http://svn.freebsd.org/changeset/base/227778 > > Log: >  - When feed-forward clock support is compiled in, change the BPF header to >    contain both a regula

svn commit: r227778 - head/sys/net

2011-11-20 Thread Lawrence Stewart
Author: lstewart Date: Mon Nov 21 04:17:24 2011 New Revision: 227778 URL: http://svn.freebsd.org/changeset/base/227778 Log: - When feed-forward clock support is compiled in, change the BPF header to contain both a regular timestamp obtained from the system clock and the current feed-forw