Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-09 Thread David Schultz
On Sun, May 08, 2011, Bruce Evans wrote: > #define bzero(p, n) ({ \ > if (__builtin_constant_p(n) && (n) <= 32) \ > __builtin_memset((p), 0, (n)); \ > else

Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-08 Thread Bruce Evans
On Sat, 7 May 2011, Hans Petter Selasky wrote: On Saturday 07 May 2011 19:13:27 m...@freebsd.org wrote: On Sat, May 7, 2011 at 9:36 AM, Hans Petter Selasky wrote: On Saturday 07 May 2011 18:28:24 Hans Petter Selasky wrote: - Use memcpy() instead of bcopy(). - Use memset() instead of bze

Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-08 Thread Bruce Evans
On Sat, 7 May 2011, Garrett Cooper wrote: On Sat, May 7, 2011 at 10:13 AM, wrote: On Sat, May 7, 2011 at 9:36 AM, Hans Petter Selasky wrote: On Saturday 07 May 2011 18:28:24 Hans Petter Selasky wrote: ? - Use memcpy() instead of bcopy(). - Use memset() instead of bzero(). Why? ?It usua

Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-07 Thread Hans Petter Selasky
On Saturday 07 May 2011 19:13:27 m...@freebsd.org wrote: > On Sat, May 7, 2011 at 9:36 AM, Hans Petter Selasky wrote: > > On Saturday 07 May 2011 18:28:24 Hans Petter Selasky wrote: > >> - Use memcpy() instead of bcopy(). > > > > - Use memset() instead of bzero(). > > Why? It usually falls t

Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-07 Thread Garrett Cooper
On Sat, May 7, 2011 at 10:13 AM, wrote: > On Sat, May 7, 2011 at 9:36 AM, Hans Petter Selasky wrote: >> On Saturday 07 May 2011 18:28:24 Hans Petter Selasky wrote: >>>   - Use memcpy() instead of bcopy(). >> >> - Use memset() instead of bzero(). > > Why?  It usually falls through to the same cod

Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-07 Thread mdf
On Sat, May 7, 2011 at 9:36 AM, Hans Petter Selasky wrote: > On Saturday 07 May 2011 18:28:24 Hans Petter Selasky wrote: >>   - Use memcpy() instead of bcopy(). > > - Use memset() instead of bzero(). Why? It usually falls through to the same code in libc. Is there some standardization on memfoo

Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-07 Thread Hans Petter Selasky
On Saturday 07 May 2011 18:28:24 Hans Petter Selasky wrote: > - Use memcpy() instead of bcopy(). - Use memset() instead of bzero(). --HPS ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe,

svn commit: r221604 - head/usr.sbin/usbdump

2011-05-07 Thread Hans Petter Selasky
Author: hselasky Date: Sat May 7 16:28:23 2011 New Revision: 221604 URL: http://svn.freebsd.org/changeset/base/221604 Log: Minor usbdump update: - Use memcpy() instead of bcopy(). - Replace all asserts() by standard error messages. - Update usage(). MFC after:7 days Modified: