Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-19 Thread Warner Losh
On 01/18/2011 22:56, Peter Jeremy wrote: On 2011-Jan-18 15:23:16 +, John Baldwin wrote: Log: Remove some always-true comparisons. ... --- head/sys/dev/cs/if_cs.c Tue Jan 18 14:58:44 2011(r217537) +++ head/sys/dev/cs/if_cs.c Tue Jan 18 15:23:16 2011(r217538) @@ -3

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-19 Thread John Baldwin
On Wednesday, January 19, 2011 12:56:35 am Peter Jeremy wrote: > On 2011-Jan-18 15:23:16 +, John Baldwin wrote: > >Log: > > Remove some always-true comparisons. > ... > >--- head/sys/dev/cs/if_cs.c Tue Jan 18 14:58:44 2011(r217537) > >+++ head/sys/dev/cs/if_cs.c Tue Jan 18 15:23:16

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-19 Thread Peter Jeremy
On 2011-Jan-18 15:23:16 +, John Baldwin wrote: >Log: > Remove some always-true comparisons. ... >--- head/sys/dev/cs/if_cs.cTue Jan 18 14:58:44 2011(r217537) >+++ head/sys/dev/cs/if_cs.cTue Jan 18 15:23:16 2011(r217538) >@@ -364,7 +364,7 @@ cs_cs89x0_probe(device_t dev

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-18 Thread Bruce Evans
On Tue, 18 Jan 2011, Roman Divacky wrote: On Wed, Jan 19, 2011 at 04:54:34AM +1100, Bruce Evans wrote: On Tue, 18 Jan 2011, John Baldwin wrote: ... Gah, I trusted the clang warning too much. enum's are ints in C yes? So clang has a bug if it thinks an enum value cannot be negative. In pract

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-18 Thread Roman Divacky
On Wed, Jan 19, 2011 at 04:54:34AM +1100, Bruce Evans wrote: > On Tue, 18 Jan 2011, John Baldwin wrote: > > >On Tuesday, January 18, 2011 12:00:44 pm Bruce Evans wrote: > >>On Tue, 18 Jan 2011, John Baldwin wrote: > >> > >>>Log: > >>> Remove some always-true comparisons. > >>> > >>> Submitted by:

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-18 Thread Bruce Evans
On Tue, 18 Jan 2011, John Baldwin wrote: On Tuesday, January 18, 2011 12:00:44 pm Bruce Evans wrote: On Tue, 18 Jan 2011, John Baldwin wrote: Log: Remove some always-true comparisons. Submitted by: clang via rdivacky Modified: head/sys/dev/buslogic/bt.c

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-18 Thread John Baldwin
On Tuesday, January 18, 2011 12:00:44 pm Bruce Evans wrote: > On Tue, 18 Jan 2011, John Baldwin wrote: > > > Log: > > Remove some always-true comparisons. > > > > Submitted by: clang via rdivacky > > > > Modified: head/sys/dev/buslogic/bt.c > >

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-18 Thread Bruce Evans
On Tue, 18 Jan 2011, John Baldwin wrote: Log: Remove some always-true comparisons. Submitted by: clang via rdivacky Modified: head/sys/dev/buslogic/bt.c == --- head/sys/dev/buslogic/bt.c Tue Jan 18 14:58:44 2011

svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-18 Thread John Baldwin
Author: jhb Date: Tue Jan 18 15:23:16 2011 New Revision: 217538 URL: http://svn.freebsd.org/changeset/base/217538 Log: Remove some always-true comparisons. Submitted by: clang via rdivacky Modified: head/sys/dev/buslogic/bt.c head/sys/dev/cs/if_cs.c Modified: head/sys/dev/buslogic/bt.