Re: svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6

2010-08-12 Thread Simon L. Nielsen
On 2010.08.11 00:51:51 +, Will Andrews wrote: > Author: will > Date: Wed Aug 11 00:51:50 2010 > New Revision: 211157 > URL: http://svn.freebsd.org/changeset/base/211157 > > Log: > Allow carp(4) to be loaded as a kernel module. Follow precedent set by > bridge(4), lagg(4) etc. and make use

Re: svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6

2010-08-11 Thread Bjoern A. Zeeb
On Wed, 11 Aug 2010, Will Andrews wrote: On Wed, Aug 11, 2010 at 8:34 AM, Pawel Jakub Dawidek wrote: Wouldn't it be better to allow unload only if there are no carp(4) interfaces? I'd be glad to destroy my carp interfaces before unloading the module, but recompiling the kernel to unload it? No

Re: svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6

2010-08-11 Thread Will Andrews
On Wed, Aug 11, 2010 at 8:34 AM, Pawel Jakub Dawidek wrote: > Wouldn't it be better to allow unload only if there are no carp(4) > interfaces? I'd be glad to destroy my carp interfaces before unloading > the module, but recompiling the kernel to unload it? Not so much. Well, in theory, if_clone_d

Re: svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6

2010-08-11 Thread Will Andrews
On Wed, Aug 11, 2010 at 12:36 PM, John Baldwin wrote: > This doesn't compile due to duplicate function pointer definitions (e.g. >  if_bridge.c and if_ether.c).  You should move all the function pointer > definitions to net/if.c and add declarations for them to a header instead of > a bunch of 'ex

Re: svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6

2010-08-11 Thread John Baldwin
Will Andrews wrote: Author: will Date: Wed Aug 11 00:51:50 2010 New Revision: 211157 URL: http://svn.freebsd.org/changeset/base/211157 Log: Allow carp(4) to be loaded as a kernel module. Follow precedent set by bridge(4), lagg(4) etc. and make use of function pointers and pf_proto_registe

Re: svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6

2010-08-11 Thread Pawel Jakub Dawidek
On Wed, Aug 11, 2010 at 12:51:51AM +, Will Andrews wrote: > Author: will > Date: Wed Aug 11 00:51:50 2010 > New Revision: 211157 > URL: http://svn.freebsd.org/changeset/base/211157 > > Log: > Allow carp(4) to be loaded as a kernel module. Follow precedent set by > bridge(4), lagg(4) etc.

svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6

2010-08-10 Thread Will Andrews
Author: will Date: Wed Aug 11 00:51:50 2010 New Revision: 211157 URL: http://svn.freebsd.org/changeset/base/211157 Log: Allow carp(4) to be loaded as a kernel module. Follow precedent set by bridge(4), lagg(4) etc. and make use of function pointers and pf_proto_register() to hook carp into