Re: svn commit: r206560 - head/sys/fs/devfs

2010-04-15 Thread Kostik Belousov
On Thu, Apr 15, 2010 at 04:01:56PM +0300, Jaakko Heinonen wrote: > On 2010-04-14, Kostik Belousov wrote: > > First, I think we shall sort dirent->dd_dlist so that symlinks are > > located before any other entries, and allow for duplication of > > any name with the name of symlink. > > What will ha

Re: svn commit: r206560 - head/sys/fs/devfs

2010-04-15 Thread Jaakko Heinonen
On 2010-04-14, Kostik Belousov wrote: > First, I think we shall sort dirent->dd_dlist so that symlinks are > located before any other entries, and allow for duplication of > any name with the name of symlink. What will happen when user deletes a symlink covering a device? Uncovering the device may

Re: svn commit: r206560 - head/sys/fs/devfs

2010-04-14 Thread Kostik Belousov
On Wed, Apr 14, 2010 at 05:20:00PM +0300, Jaakko Heinonen wrote: > On 2010-04-14, Kostik Belousov wrote: > > > Otherwise sounds reasonable suggestion. However changes are needed in > > > devfs. Currently devfs_populate_loop() is not along the make_dev*() > > > code path but make_dev(9) increases a

Re: svn commit: r206560 - head/sys/fs/devfs

2010-04-14 Thread Jaakko Heinonen
On 2010-04-14, Kostik Belousov wrote: > > Otherwise sounds reasonable suggestion. However changes are needed in > > devfs. Currently devfs_populate_loop() is not along the make_dev*() > > code path but make_dev(9) increases a generation counter and > > devfs_populate_loop() gets called sometimes la

Re: svn commit: r206560 - head/sys/fs/devfs

2010-04-14 Thread Kostik Belousov
On Wed, Apr 14, 2010 at 03:49:13PM +0300, Jaakko Heinonen wrote: > > Thank you for your comments. > > On 2010-04-14, Kostik Belousov wrote: > > The make_dev_credf() signature can be changed to return int error code > > instead of void, and a flag, lets call it MAKEDEV_CHECKNAME, added, > > make_

Re: svn commit: r206560 - head/sys/fs/devfs

2010-04-14 Thread Jaakko Heinonen
Thank you for your comments. On 2010-04-14, Kostik Belousov wrote: > The make_dev_credf() signature can be changed to return int error code > instead of void, and a flag, lets call it MAKEDEV_CHECKNAME, added, make_dev_credf() returns struct cdev *, not void. > that specifies that make_dev_cred

Re: svn commit: r206560 - head/sys/fs/devfs

2010-04-14 Thread Kostik Belousov
On Tue, Apr 13, 2010 at 06:53:39PM +, Jaakko Heinonen wrote: > Author: jh > Date: Tue Apr 13 18:53:39 2010 > New Revision: 206560 > URL: http://svn.freebsd.org/changeset/base/206560 > > Log: > - Ignore and report duplicate and empty device names in > devfs_populate_loop() > instead of c

svn commit: r206560 - head/sys/fs/devfs

2010-04-13 Thread Jaakko Heinonen
Author: jh Date: Tue Apr 13 18:53:39 2010 New Revision: 206560 URL: http://svn.freebsd.org/changeset/base/206560 Log: - Ignore and report duplicate and empty device names in devfs_populate_loop() instead of causing erratic behavior. Currently make_dev(9) can't fail, so there is no way to