Re: svn commit: r366993 - head/sys/net

2020-10-27 Thread Warner Losh
On Tue, Oct 27, 2020 at 2:23 PM Konstantin Belousov wrote: > On Tue, Oct 27, 2020 at 02:52:38PM -0400, Ed Maste wrote: > > On Sat, 24 Oct 2020 at 06:46, Konstantin Belousov > wrote: > > > > > > > -#include > > > sys/systm.h should come right after sys/param.h. These two headers are > > > excep

Re: svn commit: r366993 - head/sys/net

2020-10-27 Thread Konstantin Belousov
On Tue, Oct 27, 2020 at 02:52:38PM -0400, Ed Maste wrote: > On Sat, 24 Oct 2020 at 06:46, Konstantin Belousov wrote: > > > > > -#include > > sys/systm.h should come right after sys/param.h. These two headers are > > exceptions to the normal alphabetical rule. > > style(9) claims that sys/types.

Re: svn commit: r366993 - head/sys/net

2020-10-27 Thread Ed Maste
On Sat, 24 Oct 2020 at 06:46, Konstantin Belousov wrote: > > > -#include > sys/systm.h should come right after sys/param.h. These two headers are > exceptions to the normal alphabetical rule. style(9) claims that sys/types.h and sys/param.h are the special headers: Kernel include files (s

Re: svn commit: r366993 - head/sys/net

2020-10-27 Thread Alexander Richardson
On Sat, 24 Oct 2020 at 13:52, Alexey Dokuchaev wrote: > > On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: > > New Revision: 366993 > > URL: https://svnweb.freebsd.org/changeset/base/366993 > > > > Log: > > Run code through "clang-format -style=file" with some additional fixe

Re: svn commit: r366993 - head/sys/net

2020-10-25 Thread Pedro Giffuni
On 10/24/20 8:19 PM, Ed Maste wrote: On Sat, 24 Oct 2020 at 11:27, Warner Losh wrote: Given we already have nice .clang-format, that does most of the job, maybe it's worth considering looking into tweaking it further to fix this part? It would be nice if we could finally offload all formatting

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Warner Losh
On Sat, Oct 24, 2020 at 7:20 PM Ed Maste wrote: > On Sat, 24 Oct 2020 at 11:27, Warner Losh wrote: > > > >> Given we already have nice .clang-format, that does most of the job, > maybe it's worth considering looking into tweaking it further to fix this > part? > >> It would be nice if we could f

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Ed Maste
On Sat, 24 Oct 2020 at 11:27, Warner Losh wrote: > >> Given we already have nice .clang-format, that does most of the job, maybe >> it's worth considering looking into tweaking it further to fix this part? >> It would be nice if we could finally offload all formatting issues to the >> tool and f

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Alexander Richardson
On Sat, 24 Oct 2020, 16:27 Warner Losh, wrote: > > > On Sat, Oct 24, 2020, 7:38 AM Alexander V. Chernikov > wrote: > >> 24.10.2020, 14:08, "Hans Petter Selasky" : >> > On 2020-10-24 14:52, Alexey Dokuchaev wrote: >> >> On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: >> >>>

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Warner Losh
On Sat, Oct 24, 2020, 7:38 AM Alexander V. Chernikov wrote: > 24.10.2020, 14:08, "Hans Petter Selasky" : > > On 2020-10-24 14:52, Alexey Dokuchaev wrote: > >> On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: > >>> New Revision: 366993 > >>> URL: https://svnweb.freebsd.org/c

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Alexander V . Chernikov
24.10.2020, 14:08, "Hans Petter Selasky" : > On 2020-10-24 14:52, Alexey Dokuchaev wrote: >>  On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: >>>  New Revision: 366993 >>>  URL: https://svnweb.freebsd.org/changeset/base/366993 >>> >>>  Log: >>> Run code through "clang-forma

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Hans Petter Selasky
On 2020-10-24 14:52, Alexey Dokuchaev wrote: On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: New Revision: 366993 URL: https://svnweb.freebsd.org/changeset/base/366993 Log: Run code through "clang-format -style=file" with some additional fixes. No functional change.

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Alexey Dokuchaev
On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: > New Revision: 366993 > URL: https://svnweb.freebsd.org/changeset/base/366993 > > Log: > Run code through "clang-format -style=file" with some additional fixes. > No functional change. > > ... > @@ -99,8 +97,8 @@ infiniba

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Hans Petter Selasky
On 2020-10-24 12:46, Konstantin Belousov wrote: sys/systm.h should come right after sys/param.h OK, fixed. --HPS ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-s

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Konstantin Belousov
On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: > Author: hselasky > Date: Sat Oct 24 10:23:21 2020 > New Revision: 366993 > URL: https://svnweb.freebsd.org/changeset/base/366993 > > Log: > Run code through "clang-format -style=file" with some additional fixes. > No functi