Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-27 Thread Stefan Esser
Am 27.10.20 um 08:37 schrieb Alex Kozlov: On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: So, first off, it's already hard coded. Stefan's changes change the hard coding from 'impossible to change' to 'changeable with a recompile' which is an improvement. It might even wind up as a

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-27 Thread Alex Kozlov
On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: > On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: > > > On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: > > > Am 25.10.20 um 06:56 schrieb Alex Kozlov: > > > > On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wro

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Stefan Esser
Am 26.10.20 um 09:08 schrieb Baptiste Daroussin: On Mon, Oct 26, 2020 at 02:05:28AM -0600, Scott Long wrote: On Oct 26, 2020, at 1:50 AM, Baptiste Daroussin wrote: On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: [...] So, first off, it's already hard coded. Stefan's changes ch

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Stefan Esser
Am 26.10.20 um 00:55 schrieb Rodney W. Grimes: [ Charset ISO-8859-1 unsupported, converting... ] On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wrote: Am 24.10.20 um 09:48 schrieb Alex Kozlov: On Fri, Oct 23, 2020 at 09:22:23AM +, Stefan E?er wrote: Author: se Date: Fri Oct 23 09:

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Baptiste Daroussin
On Mon, Oct 26, 2020 at 02:05:28AM -0600, Scott Long wrote: > > > On Oct 26, 2020, at 1:50 AM, Baptiste Daroussin wrote: > > > > On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: > >> On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: > >> > >>> On Sun, Oct 25, 2020 at 11:37:34AM +

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Scott Long
> On Oct 26, 2020, at 1:50 AM, Baptiste Daroussin wrote: > > On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: >> On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: >> >>> On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: Am 25.10.20 um 06:56 schrieb Alex Kozlov: >

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Baptiste Daroussin
On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: > On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: > > > On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: > > > Am 25.10.20 um 06:56 schrieb Alex Kozlov: > > > > On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wro

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Warner Losh
On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: > On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: > > Am 25.10.20 um 06:56 schrieb Alex Kozlov: > > > On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wrote: > > > > Am 24.10.20 um 09:48 schrieb Alex Kozlov: > > [...] > > > >

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Alex Kozlov
On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: > Am 25.10.20 um 06:56 schrieb Alex Kozlov: > > On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wrote: > > > Am 24.10.20 um 09:48 schrieb Alex Kozlov: > [...] > > > > You are hardcoding assumption that LOCALBASE = /usr/local. Plea

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Rodney W. Grimes
[ Charset ISO-8859-1 unsupported, converting... ] > On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wrote: > > Am 24.10.20 um 09:48 schrieb Alex Kozlov: > > > On Fri, Oct 23, 2020 at 09:22:23AM +, Stefan E?er wrote: > > > > Author: se > > > > Date: Fri Oct 23 09:22:23 2020 > > > > New Re

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Warner Losh
On Sun, Oct 25, 2020, 9:04 AM Kyle Evans wrote: > On Sun, Oct 25, 2020 at 5:21 AM Stefan Esser wrote: > > > > Am 25.10.20 um 04:46 schrieb Rodney W. Grimes: > > >> On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes < > free...@gndrsh.dnsmgr.net> > > >> wrote: > > +#define _PATH_LOCALBASE

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Kyle Evans
On Sun, Oct 25, 2020 at 5:21 AM Stefan Esser wrote: > > Am 25.10.20 um 04:46 schrieb Rodney W. Grimes: > >> On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes > >> > >> wrote: > +#define _PATH_LOCALBASE "/usr/local" > + > >>> > >>> Something feels very wrong about this becoming a d

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Stefan Esser
Am 25.10.20 um 06:56 schrieb Alex Kozlov: On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wrote: Am 24.10.20 um 09:48 schrieb Alex Kozlov: [...] You are hardcoding assumption that LOCALBASE = /usr/local. Please make it overridable with LOCALBASE environment variable. This was a trivial

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Stefan Esser
Am 25.10.20 um 04:46 schrieb Rodney W. Grimes: On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes wrote: +#define _PATH_LOCALBASE "/usr/local" + Something feels very wrong about this becoming a defined path in base, it is further dependence on /usr/local which in the early days we spent a

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Alex Kozlov
On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wrote: > Am 24.10.20 um 09:48 schrieb Alex Kozlov: > > On Fri, Oct 23, 2020 at 09:22:23AM +, Stefan Eßer wrote: > > > Author: se > > > Date: Fri Oct 23 09:22:23 2020 > > > New Revision: 366962 > > > URL: https://svnweb.freebsd.org/changeset

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Scott Long
> On Oct 24, 2020, at 9:46 PM, Rodney W. Grimes > wrote: > >>> >>> Something feels very wrong about this becoming a defined path in base, >>> it is further dependence on /usr/local which in the early days we spent >>> a great deal of time removing. >>> >>> I believe the whole ports system al

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Rodney W. Grimes
> On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes > wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > Author: se > > > Date: Fri Oct 23 09:22:23 2020 > > > New Revision: 366962 > > > URL: https://svnweb.freebsd.org/changeset/base/366962 > > > > > > Log: > > > Add search of LOCALB

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Warner Losh
On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: se > > Date: Fri Oct 23 09:22:23 2020 > > New Revision: 366962 > > URL: https://svnweb.freebsd.org/changeset/base/366962 > > > > Log: > > Add search of LOCALBASE/share/calendar for

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > Author: se > Date: Fri Oct 23 09:22:23 2020 > New Revision: 366962 > URL: https://svnweb.freebsd.org/changeset/base/366962 > > Log: > Add search of LOCALBASE/share/calendar for calendars supplied by a port. > > Calendar files in LOCALBASE overr

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Stefan Esser
Am 24.10.20 um 09:48 schrieb Alex Kozlov: On Fri, Oct 23, 2020 at 09:22:23AM +, Stefan Eßer wrote: Author: se Date: Fri Oct 23 09:22:23 2020 New Revision: 366962 URL: https://svnweb.freebsd.org/changeset/base/366962 Log: Add search of LOCALBASE/share/calendar for calendars supplied by a

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Alex Kozlov
On Fri, Oct 23, 2020 at 09:22:23AM +, Stefan Eßer wrote: > Author: se > Date: Fri Oct 23 09:22:23 2020 > New Revision: 366962 > URL: https://svnweb.freebsd.org/changeset/base/366962 > > Log: > Add search of LOCALBASE/share/calendar for calendars supplied by a port. > > Calendar files in