Re: svn commit: r357867 - head/tests/sys/net

2020-02-14 Thread Li-Wen Hsu
On Fri, Feb 14, 2020 at 5:33 AM Konstantin Belousov wrote: > On Thu, Feb 13, 2020 at 07:05:19PM +, Li-Wen Hsu wrote: > > -#define RANDOM_MAX ((1<<31) - 1) > > +#define RANDOM_MAX (((long)1<<31) - 1) > This still gives UB on ILP32 platforms. I believe the better fix would be > (1u << 31) - 1.

Re: svn commit: r357867 - head/tests/sys/net

2020-02-13 Thread Konstantin Belousov
On Thu, Feb 13, 2020 at 07:05:19PM +, Li-Wen Hsu wrote: > Author: lwhsu > Date: Thu Feb 13 19:05:19 2020 > New Revision: 357867 > URL: https://svnweb.freebsd.org/changeset/base/357867 > > Log: > Fix GCC build. > > Sponsored by: The FreeBSD Foundation > > Modified: > head/tests/