Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-25 Thread Ed Maste
On Wed, 25 Sep 2019 at 17:13, Dimitry Andric wrote: > > > Interesting, it seems Clang doesn't even warn in the case of casting a > > uint64_t to a 32-bit pointer. Looks like there are some useful > > warnings that ought to be implemented. > > There is -Wconversion for this, or the more specific -W

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-25 Thread Dimitry Andric
On 25 Sep 2019, at 15:36, Ed Maste wrote: > > On Tue, 24 Sep 2019 at 17:39, Bruce Evans wrote: >> >> On i386, these types have different sizes, so >> gcc detects the type mismatch. clang is too broken to report this type >> mismatch. > > Interesting, it seems Clang doesn't even warn in the ca

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-25 Thread Ed Maste
On Tue, 24 Sep 2019 at 17:39, Bruce Evans wrote: > > On i386, these types have different sizes, so > gcc detects the type mismatch. clang is too broken to report this type > mismatch. Interesting, it seems Clang doesn't even warn in the case of casting a uint64_t to a 32-bit pointer. Looks like

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Bruce Evans
On Tue, 24 Sep 2019, Randall Stewart wrote: Log: lets put (void) in a couple of functions to keep older platforms that are stuck with gcc happy (ppc). The changes are needed in both bbr and rack. You mean "Don't use K&R declarations. clang is too broken to warn about K&R declarations even