Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

2019-01-16 Thread Ian Lepore
On Tue, 2019-01-15 at 12:33 -0800, Gleb Smirnoff wrote: > On Tue, Jan 15, 2019 at 01:20:14PM -0700, Ian Lepore wrote: > I> On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote: > I> > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: > I> > J> Why not #include counter.h in the relev

Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

2019-01-16 Thread Bruce Evans
On Tue, 15 Jan 2019, Gleb Smirnoff wrote: On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: J> Why not #include counter.h in the relevant vm_machdep.c files instead? This also is ugly :( Not sure more or less. Probably less, but I urged to plug all possible compilation failures at

Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

2019-01-15 Thread John Baldwin
On 1/15/19 12:33 PM, Gleb Smirnoff wrote: > On Tue, Jan 15, 2019 at 01:20:14PM -0700, Ian Lepore wrote: > I> On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote: > I> > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: > I> > J> Why not #include counter.h in the relevant vm_machdep

Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

2019-01-15 Thread Gleb Smirnoff
On Tue, Jan 15, 2019 at 01:20:14PM -0700, Ian Lepore wrote: I> On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote: I> > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: I> > J> Why not #include counter.h in the relevant vm_machdep.c files I> > instead? I> > I> > This also is ugl

Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

2019-01-15 Thread Ian Lepore
On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote: > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: > J> Why not #include counter.h in the relevant vm_machdep.c files > instead? > > This also is ugly :( Not sure more or less. Probably less, but I > urged to plug all possible

Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

2019-01-15 Thread Gleb Smirnoff
On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: J> Why not #include counter.h in the relevant vm_machdep.c files instead? This also is ugly :( Not sure more or less. Probably less, but I urged to plug all possible compilation failures at a time. What is ugly is that most files jus

Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

2019-01-15 Thread Justin Hibbits
On Tue, 15 Jan 2019 19:33:47 + (UTC) Gleb Smirnoff wrote: > Author: glebius > Date: Tue Jan 15 19:33:47 2019 > New Revision: 343058 > URL: https://svnweb.freebsd.org/changeset/base/343058 > > Log: > Fix compilation failures on different arches that have vm_machdep.c > not aware of counter_