Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread Andrew Rybchenko
On 30.11.2018 22:01, Philip Paeps wrote: On 2018-11-30 19:36:27 (+0100), John Baldwin wrote: On 11/30/18 10:15 AM, Andrew Rybchenko wrote: On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 34132

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread Andrew Rybchenko
On 30.11.2018 21:54, Brooks Davis wrote: On Fri, Nov 30, 2018 at 09:15:39PM +0300, Andrew Rybchenko wrote: On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 341327 URL: https://svnweb.freebsd.org

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread Andrew Rybchenko
Hi Conrad, On 30.11.2018 21:35, Conrad Meyer wrote: On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko wrote: Basically I'm ready to follow any sensible policy. Hi Andrew, I think general policy is to not include a "Differential Revision:" line in a commit message unless there was actual revi

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread John Baldwin
On 11/30/18 11:01 AM, Philip Paeps wrote: > On 2018-11-30 19:36:27 (+0100), John Baldwin wrote: >> On 11/30/18 10:15 AM, Andrew Rybchenko wrote: >>> On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: > Author: arybchik > Date: Fri Nov 30 07:11:05 201

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread Philip Paeps
On 2018-11-30 19:36:27 (+0100), John Baldwin wrote: On 11/30/18 10:15 AM, Andrew Rybchenko wrote: On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 341327 URL: https://svnweb.freebsd.org/changese

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread Brooks Davis
On Fri, Nov 30, 2018 at 09:15:39PM +0300, Andrew Rybchenko wrote: > On 30.11.2018 20:30, John Baldwin wrote: > > On 11/29/18 11:11 PM, Andrew Rybchenko wrote: > >> Author: arybchik > >> Date: Fri Nov 30 07:11:05 2018 > >> New Revision: 341327 > >> URL: https://svnweb.freebsd.org/changeset/base/3413

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread John Baldwin
On 11/30/18 10:15 AM, Andrew Rybchenko wrote: > On 30.11.2018 20:30, John Baldwin wrote: >> On 11/29/18 11:11 PM, Andrew Rybchenko wrote: >>> Author: arybchik >>> Date: Fri Nov 30 07:11:05 2018 >>> New Revision: 341327 >>> URL: https://svnweb.freebsd.org/changeset/base/341327 >>> >>> Log: >>>sf

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread Conrad Meyer
On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko wrote: > Basically I'm ready to follow any sensible policy. Hi Andrew, I think general policy is to not include a "Differential Revision:" line in a commit message unless there was actual review there. (That's separate from the issue of creating

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread Andrew Rybchenko
On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 341327 URL: https://svnweb.freebsd.org/changeset/base/341327 Log: sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped Early pr

Re: svn commit: r341327 - head/sys/dev/sfxge

2018-11-30 Thread John Baldwin
On 11/29/18 11:11 PM, Andrew Rybchenko wrote: > Author: arybchik > Date: Fri Nov 30 07:11:05 2018 > New Revision: 341327 > URL: https://svnweb.freebsd.org/changeset/base/341327 > > Log: > sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped > > Early processing of a packet on trans