Re: svn commit: r338633 - head/lib/libpam/pam.d

2018-09-13 Thread Brad Davis
On Thu, Sep 13, 2018, at 10:09 AM, Jean-Sébastien Pédron wrote: > > On 9/13/18 6:08 PM, Brad Davis wrote: > >>> + ${INSTALL_LINK} ${TAG_ARGS} ${CONFDIR}/ftpd ${CONFDIR}/ftp > >> > >> I think this line should probably be ${DESTDIR}/${CONFDIR} for both > >> source and dest. > > > > Yep.. Too late a

Re: svn commit: r338633 - head/lib/libpam/pam.d

2018-09-13 Thread Jean-Sébastien Pédron
On 9/13/18 6:08 PM, Brad Davis wrote: >>> + ${INSTALL_LINK} ${TAG_ARGS} ${CONFDIR}/ftpd ${CONFDIR}/ftp >> >> I think this line should probably be ${DESTDIR}/${CONFDIR} for both >> source and dest. > > Yep.. Too late at night and missed that and it didn't show up in my > packages build, but doe

Re: svn commit: r338633 - head/lib/libpam/pam.d

2018-09-13 Thread Brad Davis
On Thu, Sep 13, 2018, at 10:07 AM, Ian Lepore wrote: > On Thu, 2018-09-13 at 07:48 +, Brad Davis wrote: > > Author: brd > > Date: Thu Sep 13 07:48:49 2018 > > New Revision: 338633 > > URL: https://svnweb.freebsd.org/changeset/base/338633 > > > > Log: > >   Fix build after r338621 by avoiding L

Re: svn commit: r338633 - head/lib/libpam/pam.d

2018-09-13 Thread Ian Lepore
On Thu, 2018-09-13 at 07:48 +, Brad Davis wrote: > Author: brd > Date: Thu Sep 13 07:48:49 2018 > New Revision: 338633 > URL: https://svnweb.freebsd.org/changeset/base/338633 > > Log: >   Fix build after r338621 by avoiding LINKS and installing the link > manually. >    >   Approved by:

Re: svn commit: r338633 - head/lib/libpam/pam.d

2018-09-13 Thread Jean-Sébastien Pédron
On 9/13/18 9:48 AM, Brad Davis wrote: > Author: brd > Date: Thu Sep 13 07:48:49 2018 > New Revision: 338633 > URL: https://svnweb.freebsd.org/changeset/base/338633 > > Log: > Fix build after r338621 by avoiding LINKS and installing the link manually. Hi! I still hit a failure in `make package`