Re: svn commit: r328492 - head/contrib/opie/libopie

2018-01-27 Thread Pedro Giffuni
On 01/27/18 20:42, Bruce Evans wrote: On Sat, 27 Jan 2018, Pedro Giffuni wrote: On 01/27/18 18:21, Bruce Evans wrote: On Sat, 27 Jan 2018, Dimitry Andric wrote: On 27 Jan 2018, at 23:20, Ed Schouten wrote: * [... context lost to corruption of spaces which makes it unreadable] Wait.

Re: svn commit: r328492 - head/contrib/opie/libopie

2018-01-27 Thread Bruce Evans
On Sat, 27 Jan 2018, Pedro Giffuni wrote: On 01/27/18 18:21, Bruce Evans wrote: On Sat, 27 Jan 2018, Dimitry Andric wrote: On 27 Jan 2018, at 23:20, Ed Schouten wrote: * [... context lost to corruption of spaces which makes it unreadable] Wait... This may access utmp.ut_host one byte

Re: svn commit: r328492 - head/contrib/opie/libopie

2018-01-27 Thread Pedro Giffuni
On 01/27/18 18:21, Bruce Evans wrote: On Sat, 27 Jan 2018, Dimitry Andric wrote: On 27 Jan 2018, at 23:20, Ed Schouten wrote: 2018-01-27 23:16 GMT+01:00 Pedro F. Giffuni :    char host[sizeof(utmp.ut_host) + 1];    insecure = 1; -   strncpy(host, utmp.ut_host, sizeof(utmp.ut_

Re: svn commit: r328492 - head/contrib/opie/libopie

2018-01-27 Thread Bruce Evans
On Sat, 27 Jan 2018, Dimitry Andric wrote: On 27 Jan 2018, at 23:20, Ed Schouten wrote: 2018-01-27 23:16 GMT+01:00 Pedro F. Giffuni : char host[sizeof(utmp.ut_host) + 1]; insecure = 1; - strncpy(host, utmp.ut_host, sizeof(utmp.ut_host)); - host[sizeof(utmp.ut_host)

Re: svn commit: r328492 - head/contrib/opie/libopie

2018-01-27 Thread Ed Schouten
2018-01-27 23:31 GMT+01:00 Dimitry Andric : > On 27 Jan 2018, at 23:20, Ed Schouten wrote: >> >> 2018-01-27 23:16 GMT+01:00 Pedro F. Giffuni : >>>char host[sizeof(utmp.ut_host) + 1]; >>>insecure = 1; >>> >>> - strncpy(host, utmp.ut_host, sizeof(utmp.ut_host)); >>> - hos

Re: svn commit: r328492 - head/contrib/opie/libopie

2018-01-27 Thread Dimitry Andric
On 27 Jan 2018, at 23:20, Ed Schouten wrote: > > 2018-01-27 23:16 GMT+01:00 Pedro F. Giffuni : >>char host[sizeof(utmp.ut_host) + 1]; >>insecure = 1; >> >> - strncpy(host, utmp.ut_host, sizeof(utmp.ut_host)); >> - host[sizeof(utmp.ut_host)] = 0; >> + strncpy(hos

Re: svn commit: r328492 - head/contrib/opie/libopie

2018-01-27 Thread Ed Schouten
Hi Pedro, 2018-01-27 23:16 GMT+01:00 Pedro F. Giffuni : > char host[sizeof(utmp.ut_host) + 1]; > insecure = 1; > > - strncpy(host, utmp.ut_host, sizeof(utmp.ut_host)); > - host[sizeof(utmp.ut_host)] = 0; > + strncpy(host, utmp.ut_host, sizeof(host)); Wait... This