Ian Lepore ian at freebsd.org wrote on
Fri Jan 26 16:56:09 UTC 2018 :
> Modern compilers will warn about a class with virtual functions and no
> virtual dtor, so just blindly including it is more harmful than
> prophylactic these days, IMO.
More reliable is to have non-virtual destructors be, say
On Thu, 2018-01-25 at 22:59 -0700, Warner Losh wrote:
> On Thu, Jan 25, 2018 at 10:02 PM, Matt Joras wrote:
>
> >
> > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote:
> > >
> > >
> > >
> > > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote:
> > > >
> > > >
> > > > Author: eadler
> >
Warner Losh imp at bsdimp.com wrote on
Fri Jan 26 06:02:04 UTC 2018 :
> It's a flaw in C++ that you have a choice here. All dtors should be
> virtual because you never know when you'll have new derived classes and
> have to hunt down a hard-to-find bug because you didn't go back and make it
> vir
On Fri, 26 Jan 2018, Ed Schouten wrote:
static void usage(void) __dead2;
This should be spelled:
[[noreturn]] static void usage();
That would be as silly as __dead2, and has a worse syntactic style
(attributes before the return type mess up the formatting). It is
obvious even to lint that u
On Thu, 25 Jan 2018, Warner Losh wrote:
On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote:
Author: eadler
Date: Fri Jan 26 04:40:41 2018
New Revision: 328430
URL: https://svnweb.freebsd.org/changeset/base/328430
Log:
devd: minor nits
- mark usage as noreturn
- config does not need a
2018-01-26 5:52 GMT+01:00 Warner Losh :
> Everything needs a virtual destructor... Please back that part of this
> out...
If you're concerned about inheritance, what about adding the 'final'
keyword to the class?
http://en.cppreference.com/w/cpp/language/final
Eitan:
static void usage(void) __
On Thu, Jan 25, 2018 at 10:04 PM, Eitan Adler wrote:
> On 25 January 2018 at 21:02, Matt Joras wrote:
> > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote:
> >>
> >>
> >> On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler
> wrote:
> >>>
> >>> Author: eadler
> >>> Date: Fri Jan 26 04:40:41 2018
> >
On Thu, Jan 25, 2018 at 10:02 PM, Matt Joras wrote:
> On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote:
> >
> >
> > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote:
> >>
> >> Author: eadler
> >> Date: Fri Jan 26 04:40:41 2018
> >> New Revision: 328430
> >> URL: https://svnweb.freebsd.org/c
On 25 January 2018 at 21:02, Matt Joras wrote:
> On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote:
>>
>>
>> On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote:
>>>
>>> Author: eadler
>>> Date: Fri Jan 26 04:40:41 2018
>>> New Revision: 328430
>>> URL: https://svnweb.freebsd.org/changeset/base/
On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote:
>
>
> On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote:
>>
>> Author: eadler
>> Date: Fri Jan 26 04:40:41 2018
>> New Revision: 328430
>> URL: https://svnweb.freebsd.org/changeset/base/328430
>>
>> Log:
>> devd: minor nits
>>
>> - mark usa
On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote:
> Author: eadler
> Date: Fri Jan 26 04:40:41 2018
> New Revision: 328430
> URL: https://svnweb.freebsd.org/changeset/base/328430
>
> Log:
> devd: minor nits
>
> - mark usage as noreturn
> - config does not need a virtual destructor
>
Ever
11 matches
Mail list logo