On Fri, Jan 27, 2017 at 05:34:45PM +1100, Bruce Evans wrote:
B> > On Thu, Jan 26, 2017 at 02:03:05PM +1100, Bruce Evans wrote:
B> > B> On Thu, 26 Jan 2017, Konstantin Belousov wrote:
B> > B>
B> > B> > On Wed, Jan 25, 2017 at 02:20:06PM -0800, Gleb Smirnoff wrote:
B> > B> >> Thanks, Luiz!
B> > B>
On Thu, 26 Jan 2017, Gleb Smirnoff wrote:
On Thu, Jan 26, 2017 at 02:03:05PM +1100, Bruce Evans wrote:
B> On Thu, 26 Jan 2017, Konstantin Belousov wrote:
B>
B> > On Wed, Jan 25, 2017 at 02:20:06PM -0800, Gleb Smirnoff wrote:
B> >> Thanks, Luiz!
B> >>
B> >> One stylistic nit that I missed in
On Thu, Jan 26, 2017 at 02:03:05PM +1100, Bruce Evans wrote:
B> On Thu, 26 Jan 2017, Konstantin Belousov wrote:
B>
B> > On Wed, Jan 25, 2017 at 02:20:06PM -0800, Gleb Smirnoff wrote:
B> >> Thanks, Luiz!
B> >>
B> >> One stylistic nit that I missed in review:
B> >>
B> >> L> static int
B> >> L>
On Thu, 26 Jan 2017, Konstantin Belousov wrote:
On Wed, Jan 25, 2017 at 02:20:06PM -0800, Gleb Smirnoff wrote:
Thanks, Luiz!
One stylistic nit that I missed in review:
L> static int
L> -in_difaddr_ioctl(caddr_t data, struct ifnet *ifp, struct thread *td)
L> +in_difaddr_ioctl(u_long cmd,
On Thu, Jan 26, 2017 at 12:26:32AM +0200, Konstantin Belousov wrote:
K> On Wed, Jan 25, 2017 at 02:20:06PM -0800, Gleb Smirnoff wrote:
K> > Thanks, Luiz!
K> >
K> > One stylistic nit that I missed in review:
K> >
K> > L> static int
K> > L> -in_difaddr_ioctl(caddr_t data, struct ifnet *ifp, st
On Wed, Jan 25, 2017 at 02:20:06PM -0800, Gleb Smirnoff wrote:
> Thanks, Luiz!
>
> One stylistic nit that I missed in review:
>
> L> static int
> L> -in_difaddr_ioctl(caddr_t data, struct ifnet *ifp, struct thread *td)
> L> +in_difaddr_ioctl(u_long cmd, caddr_t data, struct ifnet *ifp, struc
Thanks, Luiz!
One stylistic nit that I missed in review:
L> static int
L> -in_difaddr_ioctl(caddr_t data, struct ifnet *ifp, struct thread *td)
L> +in_difaddr_ioctl(u_long cmd, caddr_t data, struct ifnet *ifp, struct thread
*td)
L> {
L> const struct ifreq *ifr = (struct ifreq *)data;
