Re: svn commit: r312236 - head/sys/net80211

2017-01-17 Thread Andriy Gapon
On 15/01/2017 22:43, Adrian Chadd wrote: > On 15 January 2017 at 11:56, Ian Lepore wrote: > >> >> What is the point of the !! in these macros? The expressions already >> have boolean type (even in C++ where it matters) due to the ==. >> Removing the !! would also make one level of parens redund

Re: svn commit: r312236 - head/sys/net80211

2017-01-15 Thread Adrian Chadd
On 15 January 2017 at 11:56, Ian Lepore wrote: > > What is the point of the !! in these macros? The expressions already > have boolean type (even in C++ where it matters) due to the ==. > Removing the !! would also make one level of parens redundant. It's just a habit i picked up from linux-la

Re: svn commit: r312236 - head/sys/net80211

2017-01-15 Thread Ian Lepore
On Sun, 2017-01-15 at 19:49 +, Adrian Chadd wrote: > Author: adrian > Date: Sun Jan 15 19:49:47 2017 > New Revision: 312236 > URL: https://svnweb.freebsd.org/changeset/base/312236 > > Log: >   [net80211] add some more "is this XXX" macros for CTRL and DATA. >    >   There's already a macro for