Re: svn commit: r304439 - head/sys/dev/usb/net

2016-08-19 Thread YongHyeon PYUN
On Fri, Aug 19, 2016 at 12:39:58PM +0200, Hans Petter Selasky wrote: > On 08/19/16 11:22, YongHyeon PYUN wrote: > >On Fri, Aug 19, 2016 at 11:11:56AM +0200, Hans Petter Selasky wrote: > >>On 08/19/16 10:55, YongHyeon PYUN wrote: > >>>I think the order is right but it was not tested on big-endian >

Re: svn commit: r304439 - head/sys/dev/usb/net

2016-08-19 Thread Hans Petter Selasky
On 08/19/16 11:22, YongHyeon PYUN wrote: On Fri, Aug 19, 2016 at 11:11:56AM +0200, Hans Petter Selasky wrote: On 08/19/16 10:55, YongHyeon PYUN wrote: I think the order is right but it was not tested on big-endian systems. Hi, I'm pretty sure the ifdef is wrong, because you write the fields

Re: svn commit: r304439 - head/sys/dev/usb/net

2016-08-19 Thread YongHyeon PYUN
On Fri, Aug 19, 2016 at 11:11:56AM +0200, Hans Petter Selasky wrote: > On 08/19/16 10:55, YongHyeon PYUN wrote: > >I think the order is right but it was not tested on big-endian > >systems. > > Hi, > > I'm pretty sure the ifdef is wrong, because you write the fields one at > a time, using htole3

Re: svn commit: r304439 - head/sys/dev/usb/net

2016-08-19 Thread Hans Petter Selasky
On 08/19/16 10:55, YongHyeon PYUN wrote: I think the order is right but it was not tested on big-endian systems. Hi, I'm pretty sure the ifdef is wrong, because you write the fields one at a time, using htole32(): txhdr.mss = 0; txhdr.len = ht

Re: svn commit: r304439 - head/sys/dev/usb/net

2016-08-19 Thread YongHyeon PYUN
On Fri, Aug 19, 2016 at 10:50:47AM +0200, Hans Petter Selasky wrote: > On 08/19/16 02:50, Pyun YongHyeon wrote: > >Modified: head/sys/dev/usb/net/if_axgereg.h > >== > >--- head/sys/dev/usb/net/if_axgereg.hFri Aug 19

Re: svn commit: r304439 - head/sys/dev/usb/net

2016-08-19 Thread Sepherosa Ziehau
On Fri, Aug 19, 2016 at 4:50 PM, Hans Petter Selasky wrote: > On 08/19/16 02:50, Pyun YongHyeon wrote: >> >> Modified: head/sys/dev/usb/net/if_axgereg.h >> >> == >> --- head/sys/dev/usb/net/if_axgereg.h Fri Aug 19 00:03:

Re: svn commit: r304439 - head/sys/dev/usb/net

2016-08-19 Thread Hans Petter Selasky
On 08/19/16 02:50, Pyun YongHyeon wrote: Modified: head/sys/dev/usb/net/if_axgereg.h == --- head/sys/dev/usb/net/if_axgereg.h Fri Aug 19 00:03:41 2016 (r304438) +++ head/sys/dev/usb/net/if_axgereg.h Fri Aug 19