Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Benjamin Kaduk
On Mon, 2 May 2016, Bjoern A. Zeeb wrote: > > > On 02 May 2016, at 16:08 , Conrad Meyer wrote: > > > > On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk wrote: > >> On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb wrote: > On 02 May 2016, at 15:32 , Conrad Meyer wrote: > > Clang sho

Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Conrad Meyer
On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk wrote: > On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb wrote: >> > On 02 May 2016, at 15:32 , Conrad Meyer wrote: >> > >> > Clang should really catch this too. Why didn’t it? >> >> It was only powerpc; sparc64 and mips were good as well. > > 'ch

Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Bjoern A. Zeeb
> On 02 May 2016, at 16:08 , Conrad Meyer wrote: > > On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk wrote: >> On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb wrote: On 02 May 2016, at 15:32 , Conrad Meyer wrote: Clang should really catch this too. Why didn’t it? >>> >>> It w

Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Benjamin Kaduk
On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb wrote: > > > On 02 May 2016, at 15:32 , Conrad Meyer wrote: > > > > Clang should really catch this too. Why didn’t it? > > It was only powerpc; sparc64 and mips were good as well. > > 'char' being signed vs. unsigned? -Ben __

Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Bjoern A. Zeeb
> On 02 May 2016, at 15:32 , Conrad Meyer wrote: > > Clang should really catch this too. Why didn’t it? It was only powerpc; sparc64 and mips were good as well. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/sv

Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Conrad Meyer
Clang should really catch this too. Why didn't it? Best, Conrad On Mon, May 2, 2016 at 8:07 AM, Bjoern A. Zeeb wrote: > Author: bz > Date: Mon May 2 15:07:43 2016 > New Revision: 298924 > URL: https://svnweb.freebsd.org/changeset/base/298924 > > Log: > fgetc returns an int not a char. > >