Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-21 Thread John Baldwin
On Thursday, April 21, 2016 04:01:17 PM Bruce Evans wrote: > On Wed, 20 Apr 2016, John Baldwin wrote: > > > On Wednesday, April 20, 2016 01:06:38 PM Bruce Evans wrote: > >> On Wed, 20 Apr 2016, Marcelo Araujo wrote: > >> > >>> 2016-04-20 0:16 GMT+08:00 John Baldwin : > >>> > On Tuesday, April

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread Bruce Evans
On Wed, 20 Apr 2016, John Baldwin wrote: On Wednesday, April 20, 2016 01:06:38 PM Bruce Evans wrote: On Wed, 20 Apr 2016, Marcelo Araujo wrote: 2016-04-20 0:16 GMT+08:00 John Baldwin : On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: Author: araujo Date: Tue Apr 19 04:46:13 201

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread John Baldwin
On Wednesday, April 20, 2016 01:06:38 PM Bruce Evans wrote: > On Wed, 20 Apr 2016, Marcelo Araujo wrote: > > > 2016-04-20 0:16 GMT+08:00 John Baldwin : > > > >> On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: > >>> Author: araujo > >>> Date: Tue Apr 19 04:46:13 2016 > >>> New Revision

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread Pedro Giffuni
On 04/20/16 10:15, Bruce Evans wrote: On Wed, 20 Apr 2016, Conrad Meyer wrote: On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni wrote: One of the things I dislike is that most of the macros are in lowercase. Lowercase would make sense if these were inline functions but inline functions have d

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread Bruce Evans
On Wed, 20 Apr 2016, Conrad Meyer wrote: On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni wrote: One of the things I dislike is that most of the macros are in lowercase. Lowercase would make sense if these were inline functions but inline functions have disadvantages for these use cases. OTOH, i

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread Pedro Giffuni
On 04/20/16 10:04, Pedro Giffuni wrote: On 04/20/16 09:41, Conrad Meyer wrote: On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni wrote: One of the things I dislike is that most of the macros are in lowercase. Lowercase would make sense if these were inline functions but inline functions have

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread Pedro Giffuni
On 04/20/16 09:41, Conrad Meyer wrote: On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni wrote: One of the things I dislike is that most of the macros are in lowercase. Lowercase would make sense if these were inline functions but inline functions have disadvantages for these use cases. OTOH, if

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread Conrad Meyer
On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni wrote: > One of the things I dislike is that most of the macros are in > lowercase. Lowercase would make sense if these were inline functions > but inline functions have disadvantages for these use cases. > OTOH, if they were uppercase, they would not

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-20 Thread Pedro Giffuni
On 04/19/16 22:06, Bruce Evans wrote: On Wed, 20 Apr 2016, Marcelo Araujo wrote: 2016-04-20 0:16 GMT+08:00 John Baldwin : On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: Author: araujo Date: Tue Apr 19 04:46:13 2016 New Revision: 298247 URL: https://svnweb.freebsd.org/changese

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-19 Thread Bruce Evans
On Wed, 20 Apr 2016, Marcelo Araujo wrote: 2016-04-20 0:16 GMT+08:00 John Baldwin : On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: Author: araujo Date: Tue Apr 19 04:46:13 2016 New Revision: 298247 URL: https://svnweb.freebsd.org/changeset/base/298247 Log: Remove redundant pa

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-19 Thread Marcelo Araujo
2016-04-20 0:16 GMT+08:00 John Baldwin : > On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: > > Author: araujo > > Date: Tue Apr 19 04:46:13 2016 > > New Revision: 298247 > > URL: https://svnweb.freebsd.org/changeset/base/298247 > > > > Log: > > Remove redundant parenthesis. > > > >

Re: svn commit: r298247 - head/sbin/fdisk_pc98

2016-04-19 Thread John Baldwin
On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: > Author: araujo > Date: Tue Apr 19 04:46:13 2016 > New Revision: 298247 > URL: https://svnweb.freebsd.org/changeset/base/298247 > > Log: > Remove redundant parenthesis. > > Submitted by: pfg > MFC after: 2 weeks. For th