Re: svn commit: r297902 - head

2016-04-13 Thread Steve Wills
On 04/13/16 04:12 AM, Peter Jeremy wrote: > On 2016-Apr-13 01:47:05 +, Steve Wills wrote: >> +.if !defined(SVN) || empty(SVN) >> +. for _P in /usr/bin /usr/local/bin >> +. for _S in svn svnlite >> +. if exists(${_P}/${_S}) >> +SVN= ${_P}/${_S} >> +. endif >> +. endfor >> +. endfor >> +

Re: svn commit: r297902 - head

2016-04-13 Thread Peter Jeremy
On 2016-Apr-13 01:47:05 +, Steve Wills wrote: >+.if !defined(SVN) || empty(SVN) >+. for _P in /usr/bin /usr/local/bin >+. for _S in svn svnlite >+. if exists(${_P}/${_S}) >+SVN= ${_P}/${_S} >+. endif >+. endfor >+. endfor >+.endif What is the preferred choice here? The given order pr

Re: svn commit: r297902 - head

2016-04-12 Thread NGie Cooper
> On Apr 12, 2016, at 20:02, Bryan Drewery wrote: > >> On 4/12/2016 8:00 PM, Steve Wills wrote: >>> On 04/12/16 09:59 PM, Ian Lepore wrote: >>> >>> More succinctly: >>> >>> .if empty(SVN) >>> SVN!= which svn || which svnlite >>> .endif >> >> Fair enough, that's basically the intent. I think w

Re: svn commit: r297902 - head

2016-04-12 Thread Bryan Drewery
On 4/12/2016 8:00 PM, Steve Wills wrote: > On 04/12/16 09:59 PM, Ian Lepore wrote: >> >> More succinctly: >> >> .if empty(SVN) >> SVN!= which svn || which svnlite >> .endif >> > > Fair enough, that's basically the intent. I think we like to avoid !=, > at least in ports, and I wanted the logic bet

Re: svn commit: r297902 - head

2016-04-12 Thread Steve Wills
On 04/12/16 09:59 PM, Ian Lepore wrote: > > More succinctly: > > .if empty(SVN) > SVN!= which svn || which svnlite > .endif > Fair enough, that's basically the intent. I think we like to avoid !=, at least in ports, and I wanted the logic between src and ports to match in this case. Steve

Re: svn commit: r297902 - head

2016-04-12 Thread Ian Lepore
On Wed, 2016-04-13 at 01:47 +, Steve Wills wrote: > Author: swills (ports committer) > Date: Wed Apr 13 01:47:04 2016 > New Revision: 297902 > URL: https://svnweb.freebsd.org/changeset/base/297902 > > Log: > Try harder to find svn > > While here, elliminate last references to CVS_UPDATE