Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Andriy Voskoboinyk
Sun, 14 Feb 2016 18:19:02 +0200 було написано Hans Petter Selasky : On 02/14/16 16:13, Andriy Voskoboinyk wrote: Sun, 14 Feb 2016 09:16:36 +0200 було написано Hans Petter Selasky : Author: hselasky Date: Sun Feb 14 07:16:36 2016 New Revision: 295607 URL: https://svnweb.freebsd.org/changeset

Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Hans Petter Selasky
On 02/14/16 16:13, Andriy Voskoboinyk wrote: Sun, 14 Feb 2016 09:16:36 +0200 було написано Hans Petter Selasky : Author: hselasky Date: Sun Feb 14 07:16:36 2016 New Revision: 295607 URL: https://svnweb.freebsd.org/changeset/base/295607 Log: Reduce the number of supported WLAN keys in the rum

Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Andriy Voskoboinyk
Sun, 14 Feb 2016 09:16:36 +0200 було написано Hans Petter Selasky : Author: hselasky Date: Sun Feb 14 07:16:36 2016 New Revision: 295607 URL: https://svnweb.freebsd.org/changeset/base/295607 Log: Reduce the number of supported WLAN keys in the rum driver, else we risk bit shifting overflo

Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Hans Petter Selasky
On 02/14/16 16:42, Andriy Voskoboinyk wrote: Sun, 14 Feb 2016 17:39:32 +0200 було написано Hans Petter Selasky : This does not related to pairwise keys management: static void rum_group_key_set_cb(struct rum_softc *sc, union sec_param *data, uint8_t rvp_id) { ... Then the if_rumreg.h par

Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Andriy Voskoboinyk
Sun, 14 Feb 2016 17:39:32 +0200 було написано Hans Petter Selasky : This does not related to pairwise keys management: static void rum_group_key_set_cb(struct rum_softc *sc, union sec_param *data, uint8_t rvp_id) { ... /* Set cipher mode. */ if (rum_modbits(sc, rvp_id < 2

Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Hans Petter Selasky
On 02/14/16 16:39, Hans Petter Selasky wrote: It is only about bitmanagement, ^ not --HPS ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr.

Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Hans Petter Selasky
On 02/14/16 16:23, Adrian Chadd wrote: uhm, why'd you not just file a separate pr for this? 8 keys limits how many stations it can support in hostap mode :( I'd rather the bitmap management code gets fixed. Hi, From what I can see 8 keys is the maximum due to the following shift: /*

Re: svn commit: r295607 - head/sys/dev/usb/wlan

2016-02-14 Thread Adrian Chadd
uhm, why'd you not just file a separate pr for this? 8 keys limits how many stations it can support in hostap mode :( I'd rather the bitmap management code gets fixed. -a On 13 February 2016 at 23:16, Hans Petter Selasky wrote: > Author: hselasky > Date: Sun Feb 14 07:16:36 2016 > New Revisio