Re: svn commit: r286266 - head/usr.bin/ypmatch

2015-08-09 Thread Marcelo Araujo
Hi bde@ and ed@ I think the patch attached is the latest changes to bring it as it used to be before I synced the code with OpenBSD. Mostly all issues that you both pointed out were addressed. Could you both make a review and point to me if there is any issue still remain? Basically this patch a

Re: svn commit: r286266 - head/usr.bin/ypmatch

2015-08-09 Thread Bruce Evans
On Mon, 10 Aug 2015, Marcelo Araujo wrote: 2015-08-09 19:51 GMT+08:00 Ed Schouten : Hi Marcelo, 2015-08-04 4:34 GMT+02:00 Marcelo Araujo : Sync the code with the OpenBSD version. That's a shame. It looks like improvements that we made to our version have been undone because of this. ...

Re: svn commit: r286266 - head/usr.bin/ypmatch

2015-08-09 Thread Marcelo Araujo
Hi Ed, 2015-08-09 19:51 GMT+08:00 Ed Schouten : > Hi Marcelo, > > 2015-08-04 4:34 GMT+02:00 Marcelo Araujo : > > Sync the code with the OpenBSD version. > > That's a shame. It looks like improvements that we made to our version > have been undone because of this. > > > > -static void > > +void

Re: svn commit: r286266 - head/usr.bin/ypmatch

2015-08-09 Thread Ed Schouten
Hi Marcelo, 2015-08-04 4:34 GMT+02:00 Marcelo Araujo : > Sync the code with the OpenBSD version. That's a shame. It looks like improvements that we made to our version have been undone because of this. > -static void > +void > usage(void) This function could be static. > + fprintf(st