Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread John Baldwin
On Tuesday, November 11, 2014 12:47:40 pm Andrey Chernov wrote: > On 11.11.2014 19:34, John Baldwin wrote: > > On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: > >> On 11.11.2014 18:34, Garrett Cooper wrote: > This code is wrong in any case, setting EOVERFLOW even in unneeded >

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Andrey Chernov
On 11.11.2014 19:34, John Baldwin wrote: > On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: >> On 11.11.2014 18:34, Garrett Cooper wrote: This code is wrong in any case, setting EOVERFLOW even in unneeded no-error cases like breaking from the loop. See how NetBSD does it >>

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread John Baldwin
On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: > On 11.11.2014 18:34, Garrett Cooper wrote: > >> This code is wrong in any case, setting EOVERFLOW even in unneeded > >> no-error cases like breaking from the loop. See how NetBSD does it > >> correctly instead. > > > > Hi! > > I

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Andrey Chernov
On 11.11.2014 18:34, Garrett Cooper wrote: >> This code is wrong in any case, setting EOVERFLOW even in unneeded >> no-error cases like breaking from the loop. See how NetBSD does it >> correctly instead. > > Hi! > I saw your reply earlier but hadn't gotten an opportunity to revise the > patc

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Garrett Cooper
> On Nov 11, 2014, at 05:33, Andrey Chernov wrote: > >> On 11.11.2014 7:07, Garrett Cooper wrote: >> Author: ngie >> Date: Tue Nov 11 04:07:41 2014 >> New Revision: 274365 >> URL: https://svnweb.freebsd.org/changeset/base/274365 >> >> Log: >> Revert WiP to contrib/tzcode accidentally committed

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Andrey Chernov
On 11.11.2014 7:07, Garrett Cooper wrote: > Author: ngie > Date: Tue Nov 11 04:07:41 2014 > New Revision: 274365 > URL: https://svnweb.freebsd.org/changeset/base/274365 > > Log: > Revert WiP to contrib/tzcode accidentally committed with r274364 This code is wrong in any case, setting EOVERFLOW