Re: svn commit: r271182 - head/sys/kern

2014-09-06 Thread Gleb Smirnoff
On Fri, Sep 05, 2014 at 09:54:11PM +0200, Mateusz Guzik wrote: M> > + CURVNET_SET(so->so_vnet); M> >if (V_socket_hhh[HHOOK_FILT_SOREAD]->hhh_nhooks > 0) M> >/* This hook returning non-zero indicates an event, not error */ M> >return (hhook_run_socket(so, NULL, HHOOK_FIL

Re: svn commit: r271182 - head/sys/kern

2014-09-05 Thread Mateusz Guzik
On Fri, Sep 05, 2014 at 04:30:24PM -0700, Adrian Chadd wrote: > How's this look? > Malformed. :-P I would prefer: diff --git a/sys/kern/uipc_socket.c b/sys/kern/uipc_socket.c index c6c3152..de72da5 100644 --- a/sys/kern/uipc_socket.c +++ b/sys/kern/uipc_socket.c @@ -3245,6 +3245,7 @@ static int

Re: svn commit: r271182 - head/sys/kern

2014-09-05 Thread Adrian Chadd
How's this look? adrian@testbox1:~/work/freebsd/head/src % svnlite diff sys/kern/ Index: sys/kern/uipc_socket.c === --- sys/kern/uipc_socket.c (revision 271182) +++ sys/kern/uipc_socket.c (working copy) @@ -448,10 +448

Re: svn commit: r271182 - head/sys/kern

2014-09-05 Thread Adrian Chadd
I'm building a vimage kernel now to at least compile test a fix. Thanks, -a On 5 September 2014 12:59, Garrett Cooper wrote: > >> On Sep 5, 2014, at 12:54, Mateusz Guzik wrote: >> >>> On Fri, Sep 05, 2014 at 07:50:18PM +, Gleb Smirnoff wrote: >>> Author: glebius >>> Date: Fri Sep 5 19:5

Re: svn commit: r271182 - head/sys/kern

2014-09-05 Thread Garrett Cooper
> On Sep 5, 2014, at 12:54, Mateusz Guzik wrote: > >> On Fri, Sep 05, 2014 at 07:50:18PM +, Gleb Smirnoff wrote: >> Author: glebius >> Date: Fri Sep 5 19:50:18 2014 >> New Revision: 271182 >> URL: http://svnweb.freebsd.org/changeset/base/271182 >> >> Log: >> Set vnet context before access

Re: svn commit: r271182 - head/sys/kern

2014-09-05 Thread Mateusz Guzik
On Fri, Sep 05, 2014 at 07:50:18PM +, Gleb Smirnoff wrote: > Author: glebius > Date: Fri Sep 5 19:50:18 2014 > New Revision: 271182 > URL: http://svnweb.freebsd.org/changeset/base/271182 > > Log: > Set vnet context before accessing V_socket_hhh[]. > > Submitted by: "Hiroo Ono (小野