Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-23 Thread Gleb Smirnoff
On Sat, Feb 22, 2014 at 03:28:38PM -0800, Craig Rodrigues wrote: C> Much thanks to you and Nicos for working on pf + VIMAGE. C> I work on FreeNAS at iXsystems, and in FreeNAS we enable C> VIMAGE, because we use jails quiet heavily. C> C> I encouraged Martin to go with his patch, because C> it seem

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-22 Thread Craig Rodrigues
On Wed, Feb 19, 2014 at 7:32 AM, Gleb Smirnoff wrote: > Third. As you already know, there is projects/pf branch, where Nicos > is getting things right wrt pf+VIMAGE. The patches should first go > to this branch and tested in it. Committing to head (even a good > code), you are creating conflicts

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-19 Thread Gleb Smirnoff
On Wed, Feb 19, 2014 at 08:49:01PM +0200, Mikolaj Golub wrote: M> > -SLIST_HEAD(pf_overload_head, pf_overload_entry); M> > +struct pf_overload_head { M> > + SLIST_HEAD(, pf_overload_entry) head; M> > + struct vnet *vnet; M> > +}; M> > static VNET_DEFINE(struct pf_overload_hea

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-19 Thread Mikolaj Golub
On Tue, Feb 18, 2014 at 10:17:12PM +, Martin Matuska wrote: > Author: mm > Date: Tue Feb 18 22:17:12 2014 > New Revision: 262196 > URL: http://svnweb.freebsd.org/changeset/base/262196 > > Log: > De-virtualize pf_mtag_z [1] > Process V_pf_overloadqueue in vnet context [2] Martin I saw you

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-19 Thread Ermal Luçi
On Wed, Feb 19, 2014 at 4:32 PM, Gleb Smirnoff wrote: > Martin, > > M> > On Tue, Feb 18, 2014 at 10:17:12PM +, Martin Matuska wrote: > M> > M> Author: mm > M> > M> Date: Tue Feb 18 22:17:12 2014 > M> > M> New Revision: 262196 > M> > M> URL: http://svnweb.freebsd.org/changeset/base/262196 >

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-19 Thread Gleb Smirnoff
Martin, M> > On Tue, Feb 18, 2014 at 10:17:12PM +, Martin Matuska wrote: M> > M> Author: mm M> > M> Date: Tue Feb 18 22:17:12 2014 M> > M> New Revision: 262196 M> > M> URL: http://svnweb.freebsd.org/changeset/base/262196 M> > M> M> > M> Log: M> > M>   De-virtualize pf_mtag_z [1] M> > M>   Pr

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-19 Thread Martin Matuska
Hi Gleb, I understand your point - if anything is broken (or more broken than before) I can revert this patch anytime. FreeNAS and other folks may fork separate branches and we can wait until about FreeBSD 12.0 for the patch being reviewed so we can commit it around 14.0 - maybe we have switche

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-19 Thread Gleb Smirnoff
Martin, On Tue, Feb 18, 2014 at 10:17:12PM +, Martin Matuska wrote: M> Author: mm M> Date: Tue Feb 18 22:17:12 2014 M> New Revision: 262196 M> URL: http://svnweb.freebsd.org/changeset/base/262196 M> M> Log: M> De-virtualize pf_mtag_z [1] M> Process V_pf_overloadqueue in vnet context [2]