On 2 Nov 2013, at 22:28, Bruce Evans wrote:
> On Sat, 2 Nov 2013, Mark R V Murray wrote:
>
>> On 2 Nov 2013, at 09:32, Mark R V Murray wrote:
Mark - did you initially mean the address of the mbuf m_data pointer,
or the data payload itself?
>>>
>>> As Bruce says - the address of payl
On Sat, 2 Nov 2013, Mark R V Murray wrote:
On 2 Nov 2013, at 09:32, Mark R V Murray wrote:
Mark - did you initially mean the address of the mbuf m_data pointer,
or the data payload itself?
As Bruce says - the address of payload data itself. We don?t have 12-byte
pointers in FreeBSD. :-)
C
Okay. I'll go and re-fix things.
Thanks,
-a
On 2 November 2013 02:44, Mark R V Murray wrote:
>
> On 2 Nov 2013, at 09:32, Mark R V Murray wrote:
>>> Mark - did you initially mean the address of the mbuf m_data pointer,
>>> or the data payload itself?
>>
>> As Bruce says - the address of paylo
On 2 Nov 2013, at 09:32, Mark R V Murray wrote:
>> Mark - did you initially mean the address of the mbuf m_data pointer,
>> or the data payload itself?
>
> As Bruce says - the address of payload data itself. We don’t have 12-byte
> pointers in FreeBSD. :-)
Cancel that.
The address passed must
On 2 Nov 2013, at 05:53, Adrian Chadd wrote:
> Hm! A good question!
>
> On 1 November 2013 22:22, Bruce Evans wrote:
>
>>>if (harvest.point_to_point)
>>> - random_harvest(&(m->m_data), 12, 2, RANDOM_NET_NG);
>>
>>
>> '&(m->m_data)' is not just a pair of style bugs. It
Hm! A good question!
On 1 November 2013 22:22, Bruce Evans wrote:
>> if (harvest.point_to_point)
>> - random_harvest(&(m->m_data), 12, 2, RANDOM_NET_NG);
>
>
> '&(m->m_data)' is not just a pair of style bugs. It gives address of
> the pointer (somewhere in the mbuf header)
On Sat, 2 Nov 2013, Adrian Chadd wrote:
Log:
Teach the netgraph code to use a const char * pointer too.
This actually fixes a much larger bug that was apparently accidentally
exposed by new const poisoning and new smaller type bugs.
Pointy hat to: adrian
Outpointed by the previous bug.
