Re: svn commit: r253887 - head/sys/dev/filemon

2013-08-05 Thread Hiroki Sato
"Simon J. Gerraty" wrote in <20130805201400.a181158...@chaos.jnpr.net>: sj> sj> On Mon, 5 Aug 2013 13:22:06 +0900, Hiroki Sato writes: sj> >"Simon J. Gerraty" wrote sj> > in <20130804151754.8189758...@chaos.jnpr.net>: sj> >sj> I can test it for you. sj> > sj> > Okay, I will wait for the resul

Re: svn commit: r253887 - head/sys/dev/filemon

2013-08-05 Thread Simon J. Gerraty
On Mon, 5 Aug 2013 13:22:06 +0900, Hiroki Sato writes: >"Simon J. Gerraty" wrote > in <20130804151754.8189758...@chaos.jnpr.net>: >sj> I can test it for you. > > Okay, I will wait for the results. Seems to work ok. Thanks --sjg ___ svn-src-head@free

Re: svn commit: r253887 - head/sys/dev/filemon

2013-08-04 Thread Hiroki Sato
"Simon J. Gerraty" wrote in <20130804151754.8189758...@chaos.jnpr.net>: sj> >> Thank you for your comments. Can you review the attached patch? If sj> >> there is no problem, I will commit this and MFC to stable branches. sj> sj> Looks good. sj> But don't commit it untested ;-) sj> I can tes

Re: svn commit: r253887 - head/sys/dev/filemon

2013-08-04 Thread Simon J. Gerraty
>> Thank you for your comments. Can you review the attached patch? If >> there is no problem, I will commit this and MFC to stable branches. Looks good. But don't commit it untested ;-) I can test it for you. >Perhaps it is best to commit this patch, but also add a warning to >filemon(4) that

Re: svn commit: r253887 - head/sys/dev/filemon

2013-08-04 Thread Jilles Tjoelker
On Sun, Aug 04, 2013 at 12:15:23PM +0900, Hiroki Sato wrote: > Jilles Tjoelker wrote > in <20130802152204.ga1...@stack.nl>: > ji> You can simplify the code using the fairly new pget(). This will also > ji> fix the incorrect errno when the process does not exist (should be > ji> [ESRCH]). > ji>

Re: svn commit: r253887 - head/sys/dev/filemon

2013-08-03 Thread Hiroki Sato
Jilles Tjoelker wrote in <20130802152204.ga1...@stack.nl>: ji> You can simplify the code using the fairly new pget(). This will also ji> fix the incorrect errno when the process does not exist (should be ji> [ESRCH]). ji> ji> This change is a step in the right direction but is incomplete. Altho

Re: svn commit: r253887 - head/sys/dev/filemon

2013-08-02 Thread Jilles Tjoelker
On Fri, Aug 02, 2013 at 02:44:11PM +, Hiroki Sato wrote: > Author: hrs > Date: Fri Aug 2 14:44:11 2013 > New Revision: 253887 > URL: http://svnweb.freebsd.org/changeset/base/253887 > Log: > Add p_candebug() check to FILEMON_SET_PID ioctl. > Discussed with: sjg > MFC after: 3 days