On Tuesday, July 30, 2013 2:57:00 pm Sean Bruno wrote:
>
> > >
> > > Ok then what is this ^ ? Doesn't this mean that if
> > > device_find_child() returns a child node that we should abort? Is that
> > > not the same as what I'm going on about?
> >
> > This makes it only add at most one
> >
> > Ok then what is this ^ ? Doesn't this mean that if
> > device_find_child() returns a child node that we should abort? Is that
> > not the same as what I'm going on about?
>
> This makes it only add at most one child device. It is a common idiom in
> identify routines so that i
On Monday, July 29, 2013 6:50:59 pm Sean Bruno wrote:
> [sbruno_comment_blocks == 4]
>
> >
> > The identify function in 7.x has no such check:
> >
> > static void
> > ipmi_isa_identify(driver_t *driver, device_t parent)
> > {
> > struct ipmi_get_info info;
> > uint32_t devid;
> >
> >
[sbruno_comment_blocks == 4]
>
> The identify function in 7.x has no such check:
>
> static void
> ipmi_isa_identify(driver_t *driver, device_t parent)
> {
> struct ipmi_get_info info;
> uint32_t devid;
>
> if (ipmi_smbios_identify(&info) && info.iface_type != SSIF_MODE &&
>
On Monday, July 29, 2013 4:21:28 pm Sean Bruno wrote:
> On Mon, 2013-07-29 at 12:59 -0700, Sean Bruno wrote:
> > On Mon, 2013-07-29 at 10:54 -0400, John Baldwin wrote:
> > > On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote:
> > > > Author: sbruno
> > > > Date: Sat Jul 27 16:32:34 2013
> > >
On Monday, July 29, 2013 3:59:12 pm Sean Bruno wrote:
> On Mon, 2013-07-29 at 10:54 -0400, John Baldwin wrote:
> > On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote:
> > > Author: sbruno
> > > Date: Sat Jul 27 16:32:34 2013
> > > New Revision: 253708
> > > URL: http://svnweb.freebsd.org/chang
On Mon, 2013-07-29 at 12:59 -0700, Sean Bruno wrote:
> On Mon, 2013-07-29 at 10:54 -0400, John Baldwin wrote:
> > On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote:
> > > Author: sbruno
> > > Date: Sat Jul 27 16:32:34 2013
> > > New Revision: 253708
> > > URL: http://svnweb.freebsd.org/change
On Mon, 2013-07-29 at 10:54 -0400, John Baldwin wrote:
> On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote:
> > Author: sbruno
> > Date: Sat Jul 27 16:32:34 2013
> > New Revision: 253708
> > URL: http://svnweb.freebsd.org/changeset/base/253708
> >
> > Log:
> > At some point after stable/7
On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote:
> Author: sbruno
> Date: Sat Jul 27 16:32:34 2013
> New Revision: 253708
> URL: http://svnweb.freebsd.org/changeset/base/253708
>
> Log:
> At some point after stable/7 the ACPI and ISA interfaces to the IPMI
> controller
> no longer hav
