Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-23 Thread Konstantin Belousov
On Mon, Oct 22, 2012 at 09:10:17AM -0700, Maxim Sobolev wrote: > Guys, > > The latest version of the patch against current HEAD is available here: > > http://sobomax.sippysoft.com/cron.diff > > Any comments/suggestions are appreciated. This version should default to > previous behaviour of waki

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-22 Thread Maxim Sobolev
On 10/22/2012 9:35 AM, Eitan Adler wrote: Why? Can this be fixed if this is not intended? Well, I see libcron in the DPADD for the cron(8), so I think as far as normal buildworld is concerned things are good. It's just that if you build the cron only manually, it's not recompiled automaticall

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-22 Thread Eitan Adler
On 22 October 2012 12:10, Maxim Sobolev wrote: > Please make > sure to do `make clean' after applying it, as libcron is not listed as a > dependency for cron, so it's possible that some changes may not be picked > up. Why? Can this be fixed if this is not intended? -- Eitan Adler Source & Port

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-22 Thread Maxim Sobolev
Guys, The latest version of the patch against current HEAD is available here: http://sobomax.sippysoft.com/cron.diff Any comments/suggestions are appreciated. This version should default to previous behaviour of waking up every 60 seconds unless there is @every_second entry in the cron. Kon

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Konstantin Belousov
On Wed, Oct 17, 2012 at 01:47:01PM -0700, Maxim Sobolev wrote: > On 10/17/2012 1:18 PM, Konstantin Belousov wrote: > > As I said, a reversal of all three commits makes the cron(8) operate > > correctly. > > Done, sorry. Do you mind if I send you latest version of the patch later > for testing? T

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Maxim Sobolev
On 10/17/2012 1:18 PM, Konstantin Belousov wrote: As I said, a reversal of all three commits makes the cron(8) operate correctly. Done, sorry. Do you mind if I send you latest version of the patch later for testing? Thanks! -Maxim ___ svn-src-hea

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Konstantin Belousov
On Wed, Oct 17, 2012 at 01:07:20PM -0700, Maxim Sobolev wrote: > On 10/17/2012 10:48 AM, Konstantin Belousov wrote: > > The cron daemon in HEAD is not functional, i.e. no jobs are executed > > at all. Reverting r241625 r241618 r241576 gives me the expected behaviour. > > > > P.S. I do not remember

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Maxim Sobolev
Also, I have avoided using FP, since the old code doesn't, and some of the smaller systems we run on (arm, mips) might not have FPU unit, so it might have a problem with that. And I am still working on new version to revert to 60-seconds polling by default. -Maxim ___

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Maxim Sobolev
OK, thanks guys for valuable suggestions. Am I correct that the general suggestion is to use clock_gettime(CLOCK_REALTIME) instead of the gettimeofday(), and fix few types here and there? -Maxim ___ svn-src-head@freebsd.org mailing list http://lists.f

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Maxim Sobolev
On 10/17/2012 10:48 AM, Konstantin Belousov wrote: The cron daemon in HEAD is not functional, i.e. no jobs are executed at all. Reverting r241625 r241618 r241576 gives me the expected behaviour. P.S. I do not remember a single commit from you which did not failed on tinderbox, or was not found b

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Konstantin Belousov
On Wed, Oct 17, 2012 at 12:44:35AM +, Maxim Sobolev wrote: > Author: sobomax > Date: Wed Oct 17 00:44:34 2012 > New Revision: 241625 > URL: http://svn.freebsd.org/changeset/base/241625 > > Log: > o Use nanosleep(2) to sleep exact amount of time till the next second, > not multiple of 1 sec

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Bruce Evans
On Wed, 17 Oct 2012, Xin Li wrote: On 10/16/12 5:44 PM, Maxim Sobolev wrote: Author: sobomax Date: Wed Oct 17 00:44:34 2012 New Revision: 241625 URL: http://svn.freebsd.org/changeset/base/241625 Log: o Use nanosleep(2) to sleep exact amount of time till the next second, not multiple of 1 secon

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Bruce Evans
On Wed, 17 Oct 2012, Andrey Zonov wrote: On 10/17/12 4:44 AM, Maxim Sobolev wrote: Log: o Use nanosleep(2) to sleep exact amount of time till the next second, not multiple of 1 second, which results in actual time to drift back and forth every run within 1 second of the actual action has

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 10/16/12 5:44 PM, Maxim Sobolev wrote: > Author: sobomax Date: Wed Oct 17 00:44:34 2012 New Revision: > 241625 URL: http://svn.freebsd.org/changeset/base/241625 > > Log: o Use nanosleep(2) to sleep exact amount of time till the next > second

Re: svn commit: r241625 - head/usr.sbin/cron/cron

2012-10-17 Thread Andrey Zonov
On 10/17/12 4:44 AM, Maxim Sobolev wrote: > Author: sobomax > Date: Wed Oct 17 00:44:34 2012 > New Revision: 241625 > URL: http://svn.freebsd.org/changeset/base/241625 > > Log: > o Use nanosleep(2) to sleep exact amount of time till the next second, > not multiple of 1 second, which results in