Re: svn commit: r228071 - head/sys/net

2011-11-29 Thread Gleb Smirnoff
On Tue, Nov 29, 2011 at 09:43:37AM +, Bjoern A. Zeeb wrote: B> On Tue, 29 Nov 2011, Gleb Smirnoff wrote: B> > btw, I don't like the static initializer of cloners, since it require re-compile of B> > dependencies. B> > B> > What about making an API change: remove the static initializer and make

Re: svn commit: r228071 - head/sys/net

2011-11-29 Thread Bjoern A. Zeeb
On Tue, 29 Nov 2011, Gleb Smirnoff wrote: On Mon, Nov 28, 2011 at 07:47:22PM +, Bjoern A. Zeeb wrote: B> On 28. Nov 2011, at 14:44 , Gleb Smirnoff wrote: B> B> > Author: glebius B> > Date: Mon Nov 28 14:44:59 2011 B> > New Revision: 228071 B> > URL: http://svn.freebsd.org/changeset/base/2280

Re: svn commit: r228071 - head/sys/net

2011-11-29 Thread Gleb Smirnoff
On Mon, Nov 28, 2011 at 10:23:07PM +0200, Jaakko Heinonen wrote: J> On 2011-11-28, Bjoern A. Zeeb wrote: J> > > static void J> > > if_clone_free(struct if_clone *ifc) J> > > { J> > > -for (int bytoff = 0; bytoff < ifc->ifc_bmlen; bytoff++) { J> > > -KASSERT(ifc->ifc_units[by

Re: svn commit: r228071 - head/sys/net

2011-11-29 Thread Gleb Smirnoff
On Mon, Nov 28, 2011 at 07:47:22PM +, Bjoern A. Zeeb wrote: B> On 28. Nov 2011, at 14:44 , Gleb Smirnoff wrote: B> B> > Author: glebius B> > Date: Mon Nov 28 14:44:59 2011 B> > New Revision: 228071 B> > URL: http://svn.freebsd.org/changeset/base/228071 B> > B> > Log: B> > - Use generic alloc

Re: svn commit: r228071 - head/sys/net

2011-11-28 Thread Jaakko Heinonen
On 2011-11-28, Bjoern A. Zeeb wrote: > > static void > > if_clone_free(struct if_clone *ifc) > > { > > - for (int bytoff = 0; bytoff < ifc->ifc_bmlen; bytoff++) { > > - KASSERT(ifc->ifc_units[bytoff] == 0x00, > > - ("ifc_units[%d] is not empty", bytoff)); > > - } > > >

Re: svn commit: r228071 - head/sys/net

2011-11-28 Thread Bjoern A. Zeeb
On 28. Nov 2011, at 14:44 , Gleb Smirnoff wrote: > Author: glebius > Date: Mon Nov 28 14:44:59 2011 > New Revision: 228071 > URL: http://svn.freebsd.org/changeset/base/228071 > > Log: > - Use generic alloc_unr(9) allocator for if_clone, instead >of hand-made. > - When registering new cloner

Re: svn commit: r228071 - head/sys/net

2011-11-28 Thread Brooks Davis
On Mon, Nov 28, 2011 at 02:44:59PM +, Gleb Smirnoff wrote: > Author: glebius > Date: Mon Nov 28 14:44:59 2011 > New Revision: 228071 > URL: http://svn.freebsd.org/changeset/base/228071 > > Log: > - Use generic alloc_unr(9) allocator for if_clone, instead > of hand-made. > - When regist