Re: svn commit: r211304 - head/lib/libutil

2010-08-24 Thread Dag-Erling Smørgrav
Bruce Evans writes: > Dag-Erling Smørgrav writes: > > That's awesome! Any way I can convince you to fix expand_number() as > > well? I got a detailed explanation of what's wrong with it (both before > > and after my commits) from bde@ (cc:ed) in private correspondence; I can > > forward it to y

Re: svn commit: r211304 - head/lib/libutil

2010-08-23 Thread Bruce Evans
On Mon, 23 Aug 2010, [utf-8] Dag-Erling Sm??rgrav wrote: Dimitry Andric writes: Dag-Erling Sm??rgrav writes: Bruce Cran writes: Somewhat related, there are overflow bugs in humanize_number - for example df(1) fails to display space from a 100PB filesystem correctly. Patch? :) Attached.

Re: svn commit: r211304 - head/lib/libutil

2010-08-23 Thread Dag-Erling Smørgrav
Dimitry Andric writes: > Dag-Erling Smørgrav writes: > > Bruce Cran writes: > > > Somewhat related, there are overflow bugs in humanize_number - for > > > example df(1) fails to display space from a 100PB filesystem > > > correctly. > > Patch? :) > Attached. This makes humanize_number() work p

Re: svn commit: r211304 - head/lib/libutil

2010-08-22 Thread Dimitry Andric
On 2010-08-16 10:51, Dag-Erling Smørgrav wrote: > Bruce Cran writes: >> Somewhat related, there are overflow bugs in humanize_number - for >> example df(1) fails to display space from a 100PB filesystem >> correctly. > > Patch? :) Attached. This makes humanize_number() work properly for all po

Re: svn commit: r211304 - head/lib/libutil

2010-08-16 Thread Dag-Erling Smørgrav
Bruce Cran writes: > Somewhat related, there are overflow bugs in humanize_number - for > example df(1) fails to display space from a 100PB filesystem > correctly. Patch? :) DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-head@freebsd.org mailin

Re: svn commit: r211304 - head/lib/libutil

2010-08-15 Thread Bruce Cran
On Sat, 14 Aug 2010 14:34:36 + (UTC) Dag-Erling Smorgrav wrote: > Author: des > Date: Sat Aug 14 14:34:36 2010 > New Revision: 211304 > URL: http://svn.freebsd.org/changeset/base/211304 > > Log: > Simplify expand_number() by combining the (unrolled) loop with the > switch. Since expand_

Re: svn commit: r211304 - head/lib/libutil

2010-08-15 Thread Dag-Erling Smørgrav
m...@freebsd.org writes: > I think it's possible for the number to overflow but also not shrink. > e.g. 0x12345678T. Ah, you're right, I didn't think of that. Thanks. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-head@freebsd.org mailing list h

Re: svn commit: r211304 - head/lib/libutil

2010-08-14 Thread mdf
On Sat, Aug 14, 2010 at 2:34 PM, Dag-Erling Smorgrav wrote: > Author: des > Date: Sat Aug 14 14:34:36 2010 > New Revision: 211304 > URL: http://svn.freebsd.org/changeset/base/211304 > > Log: >  Simplify expand_number() by combining the (unrolled) loop with the >  switch.  Since expand_number() doe