Re: svn commit: r209604 - head/lib/libc/gmon

2010-07-02 Thread David Schultz
On Wed, Jun 30, 2010, Marcel Moolenaar wrote: > >>s_scale = ((float)p->kcountsize / o ) * SCALE_1_TO_1; > > > > I can't see any bugs in this expression. p->kcountsize is < o, and the > > scale factor is only 65536, so there should be no problems with overflow. > > This leaves GCC a

Re: svn commit: r209604 - head/lib/libc/gmon

2010-06-30 Thread Marcel Moolenaar
On Jun 30, 2010, at 12:17 PM, Bruce Evans wrote: >> I like this. What about the following (white-space corrupted) >> simplification: > > Almost OK. I orginally wrote it with a conditional operator, but decided > that that might be harder to understand. > >> Index: gmon.c >>

Re: svn commit: r209604 - head/lib/libc/gmon

2010-06-30 Thread Bruce Evans
On Wed, 30 Jun 2010, Marcel Moolenaar wrote: On Jun 30, 2010, at 2:40 AM, Bruce Evans wrote: On Wed, 30 Jun 2010, Marcel Moolenaar wrote: Log: On powerpc, calculate s_scale using the non-FP version previously specific to hp300. Since FreeBSD does not support hp300, hp300 has been removed fro

Re: svn commit: r209604 - head/lib/libc/gmon

2010-06-30 Thread Marcel Moolenaar
On Jun 30, 2010, at 2:40 AM, Bruce Evans wrote: > On Wed, 30 Jun 2010, Marcel Moolenaar wrote: > >> Log: >> On powerpc, calculate s_scale using the non-FP version previously >> specific to hp300. Since FreeBSD does not support hp300, hp300 has >> been removed from the condition altogether. > >

Re: svn commit: r209604 - head/lib/libc/gmon

2010-06-30 Thread Bruce Evans
On Wed, 30 Jun 2010, Marcel Moolenaar wrote: Log: On powerpc, calculate s_scale using the non-FP version previously specific to hp300. Since FreeBSD does not support hp300, hp300 has been removed from the condition altogether. Also, the style of the condition has been regressed from ifndef