Author: qingli
Date: Sat Aug 15 16:48:58 2020
New Revision: 364257
URL: https://svnweb.freebsd.org/changeset/base/364257
Log:
Correct the mask byte order when checking for reserved bits.
Reviewed by: gnn
Approved by: gnn
MFC after:2 weeks
Differential Revision:https://re
On Sun, Jun 5, 2016 at 11:06 PM, Alexander V. Chernikov <
melif...@freebsd.org> wrote:
> 06.06.2016, 04:40, "George Neville-Neil" :
> > On 4 Jun 2016, at 15:05, Alexander V. Chernikov wrote:
> >
> >> 02.06.2016, 20:51, "George V. Neville-Neil" :
> >>> Author: gnn
> >>> Date: Thu Jun 2 17:51:29
Author: qingli
Date: Tue Jun 25 00:10:49 2013
New Revision: 252184
URL: http://svnweb.freebsd.org/changeset/base/252184
Log:
Due to the routing related networking kernel redesign work
in FBSD 8.0, interface routes have been returened to the
applications without the RTF_GATEWAY bit. This inco
Author: qingli
Date: Mon Jun 24 05:01:13 2013
New Revision: 252141
URL: http://svnweb.freebsd.org/changeset/base/252141
Log:
Delete the nd6 entries associated with an off-link prefix
if the same prefix cannot be found on an alternative
interface.
Reviewed by: hrs
MFC after:1 week
o I can have
a better look at the issue, and possibly make a suggestion for an alternative
patch ?
--Qing
2012/4/8 Gleb Smirnoff :
> Qing,
>
> On Sun, Apr 08, 2012 at 10:41:11AM -0700, Qing Li wrote:
> Q> This is not the right way to support RFC3021.
> Q>
> Q> The code you
This is not the right way to support RFC3021.
The code you removed is used for checking against attempt at adding
duplicate entry.
Both the message and the code apply in that context. I tried to state
clearly and concisely
what r201282 was intended in solving and was verified by actual users
who r
>
> first I'd like to notice that we are speaking about obsoleted interfaces.
>
Yup, that's why you don't see me commenting on your other commits around
ia_netmask stuff, do you ?
>
> Back to your comments:
>
> I have made a test case that proves, that usage of deleted address isn't
> prevente
>
> From my point of view logically speaking, we should first remove route,
> then remove address. Otherwise, for a short time we've got an invalid
> route in table.
>
For a short time you have an invalid address, it is faster to remove the
address from the list to prevent usage, then to flush the
Logically speaking the prefix route should not be removed until all of the
address related housing keeping tasks have been completed successfully.
Putting "in_scrubprefix()" at the top does not gain you anything at
all, but can
potentially be problematic if additional tasks are in fact performed
i
Author: qingli
Date: Fri Nov 11 23:22:38 2011
New Revision: 227460
URL: http://svn.freebsd.org/changeset/base/227460
Log:
A default route learned from the RAs could be deleted manually
after its installation. This removal may be accidental and can
prevent the default route from being install
Author: qingli
Date: Tue Oct 25 04:06:29 2011
New Revision: 226713
URL: http://svn.freebsd.org/changeset/base/226713
Log:
Exclude host routes when checking for prefix coverage on multiple
interfaces. A host route has a NULL mask so check for that condition.
I have also been told by developer
Author: qingli
Date: Tue Oct 25 00:34:39 2011
New Revision: 226710
URL: http://svn.freebsd.org/changeset/base/226710
Log:
The host-id/interface-id can have a specific value and is properly
masked out when adding a prefix route through the "route" command.
However, when deleting the route, si
Author: qingli
Date: Sun Oct 16 22:24:04 2011
New Revision: 226453
URL: http://svn.freebsd.org/changeset/base/226453
Log:
The code change made in r226040 was incomplete and resulted in
routes such as fe80::1%lo0 no being installed. This patch completes
the original intended fix.
Reviewe
Author: qingli
Date: Sun Oct 16 22:15:13 2011
New Revision: 226451
URL: http://svn.freebsd.org/changeset/base/226451
Log:
The IPv6 code was influx at the time of r196865 due to the L2/L3
separation rewrite changes. r196865 was committed to fix a scope
violation problem in the following test
MFC 225946 is the original patch, 225947 messed up the logic a bit
while putting in the fix for another issue. 226224 is the fix to 225947,
which I will MFC tomorrow.
--Qing
2011/10/10 Gleb Smirnoff :
> Qing,
>
> On Mon, Oct 10, 2011 at 05:41:11PM +0000, Qing Li wrote:
> Q> Aut
Author: qingli
Date: Mon Oct 10 17:41:11 2011
New Revision: 226224
URL: http://svn.freebsd.org/changeset/base/226224
Log:
All indirect routes will fail the rtcheck, except for a special host
route where the destination IP and the gateway IP is the same. This
special case handling is only mea
Okay, now I know what's confusing you ... it's that bug I introduced :-)
The 2nd "if()" check on the RTF_GATEWAY flag should have been
an "else if()".
In a nutshell, the logic is any indirect route should fail the check,
except for that special host route.
Attached is the rework of that part of
Hi Gleb,
>
> On Mon, Oct 03, 2011 at 07:51:19PM +, Qing Li wrote:
> Q> Author: qingli
> Q> Date: Mon Oct 3 19:51:18 2011
> Q> New Revision: 225947
> Q> URL: http://svn.freebsd.org/changeset/base/225947
> Q>
> Q> Log:
> Q> A system may have m
Author: qingli
Date: Fri Oct 7 22:22:19 2011
New Revision: 226120
URL: http://svn.freebsd.org/changeset/base/226120
Log:
Do not try removing an ARP entry associated with a given interface
address if that interface does not support ARP. Otherwise the
system will generate error messages unnec
Author: qingli
Date: Fri Oct 7 18:01:34 2011
New Revision: 226114
URL: http://svn.freebsd.org/changeset/base/226114
Log:
Remove the reference held on the loopback route when the interface
address is being deleted. Only the last reference holder deletes the
loopback route. All other delete o
, Oct 5, 2011 at 4:21 PM, Bjoern A. Zeeb
wrote:
>
> On 5. Oct 2011, at 16:27 , Qing Li wrote:
>
>> Author: qingli
>> Date: Wed Oct 5 16:27:11 2011
>> New Revision: 226040
>> URL: http://svn.freebsd.org/changeset/base/226040
>>
>> Log:
>> The IFA_RTS
Author: qingli
Date: Wed Oct 5 16:27:11 2011
New Revision: 226040
URL: http://svn.freebsd.org/changeset/base/226040
Log:
The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to
determine if a loopback route should be installed for an interface
IPv6 address. Another condition is th
Author: qingli
Date: Mon Oct 3 19:51:18 2011
New Revision: 225947
URL: http://svn.freebsd.org/changeset/base/225947
Log:
A system may have multiple physical interfaces, all of which are on the
same prefix. Since a single route entry is installed for the prefix
(without RADIX_MPATH), incomin
Author: qingli
Date: Mon Oct 3 19:06:55 2011
New Revision: 225946
URL: http://svn.freebsd.org/changeset/base/225946
Log:
This patch allows ARP to work properly in the presence of
self-referencing routes. This patch is a rework of r223862.
Reviewed by: bz, zec
MFC after:5 days
Mod
Author: qingli
Date: Mon Sep 5 17:54:19 2011
New Revision: 225405
URL: http://svn.freebsd.org/changeset/base/225405
Log:
The maximum read size of incoming packets is done in 1024-byte increments.
The current code was rounding down the maximum frame size instead of
routing up, resulting in a
Author: qingli
Date: Sun Aug 28 00:14:40 2011
New Revision: 225223
URL: http://svn.freebsd.org/changeset/base/225223
Log:
When an interface address route is removed from the system, another
route with the same prefix is searched for as a replacement. The
current code did not bypass routes th
Author: qingli
Date: Thu Aug 25 04:31:20 2011
New Revision: 225163
URL: http://svn.freebsd.org/changeset/base/225163
Log:
When the RADIX_MPATH kernel option is enabled, the RADIX_MPATH code tries
to find the first route node of an ECMP chain before executing the route
command. If the system
Author: qingli
Date: Sun May 29 02:21:35 2011
New Revision: 222438
URL: http://svn.freebsd.org/changeset/base/222438
Log:
Supply the LLE_STATIC flag bit to in_ifscurb() when scrubbing interface
address so that proper clean up will take place in the routing code.
This patch fixes the bootp pa
Author: qingli
Date: Fri May 20 19:12:20 2011
New Revision: 222143
URL: http://svn.freebsd.org/changeset/base/222143
Log:
The statically configured (permanent) ARP entries are removed when an
interface is brought down, even though the interface address is still
valid. This patch maintains th
Author: qingli
Date: Sun Sep 12 18:04:47 2010
New Revision: 212502
URL: http://svn.freebsd.org/changeset/base/212502
Log:
Adding an address on an interface also requires the loopback route to
that address be installed.
PR: kern/150481
Submitted by: Ingo Flaschberger
MFC aft
Author: qingli
Date: Tue May 25 20:42:35 2010
New Revision: 208553
URL: http://svn.freebsd.org/changeset/base/208553
Log:
This patch fixes the problem where proxy ARP entries cannot be added
over the if_ng interface.
MFC after:3 days
Modified:
head/sys/net/if.c
head/sys/net/if_va
Author: qingli
Date: Thu Mar 18 00:23:39 2010
New Revision: 205272
URL: http://svn.freebsd.org/changeset/base/205272
Log:
Need to set the proper flag bit when inserting ARP
entries into the kernel.
MFC after:3 days
Modified:
head/usr.sbin/ppp/arp.c
Modified: head/usr.sbin/ppp/arp.
Author: qingli
Date: Wed Mar 17 22:12:12 2010
New Revision: 205268
URL: http://svn.freebsd.org/changeset/base/205268
Log:
Set the device capabilities to include dynamic link-state for
those modern drivers.
Reviewed by: imp (and suggested by imp)
MFC after:3 days
Modified:
head/s
Author: qingli
Date: Tue Mar 16 17:59:12 2010
New Revision: 205222
URL: http://svn.freebsd.org/changeset/base/205222
Log:
Verify interface up status using its link state only
if the interface has such capability. The interface
capability flag indicates whether such capability
exists. This
>
> We've got LINK_STATE_UNKNOWN, we can just initialize if_link_state to
> this value in ether_ifattach(). And Qing should treat this value as
> LINK_STATE_UP in routing decision until better times.
>
Thanks everyone for your input.
I generally try to avoid overloading a variable to have more th
Author: qingli
Date: Fri Mar 12 10:24:58 2010
New Revision: 205077
URL: http://svn.freebsd.org/changeset/base/205077
Log:
The flow-table module retrieves the destination and source
address as well as the transport protocol port information
from the outbound packets. The routing code is gener
Nope, I meant Julian, and what he proposed, and if I understood
correctly, is the simplest
approach and easily done.
-- Qing
On Fri, Mar 12, 2010 at 12:29 AM, Robert N. M. Watson
wrote:
>
> On Mar 12, 2010, at 8:11 AM, Qing Li wrote:
>
>> I like Julian's suggestion beca
12, 2010 at 12:26 AM, Robert N. M. Watson
wrote:
>
> On Mar 12, 2010, at 8:11 AM, Qing Li wrote:
>
>> I like Julian's suggestion because it is simple and very low risk.
>> And there isn't a need to check for interface type any more.
>> Here is why:
>>
>>
wrote:
>
> On Mar 12, 2010, at 7:52 AM, Qing Li wrote:
>
>>> Is there any way we can pick up via an assertion that an interface driver
>>> has failed to implement this functionality? This has never been a historic
>>> requirement, so I suspect there are a lot
>
> Is there any way we can pick up via an assertion that an interface driver has
> failed to implement this functionality? This has never been a historic
> requirement, so I suspect there are a lot of drivers floating around that
> fail to meet the requirement. Also, is this for IFT_ETHER only,
That's a good idea. I will take your approach.
-- Qing
On Thu, Mar 11, 2010 at 11:15 PM, Julian Elischer wrote:
> Juli Mallett wrote:
>>
>> On Thu, Mar 11, 2010 at 15:39, Qing Li wrote:
>>>
>>> I guess it's a good time to clean things up. The if_
>
> If you can think of a way to add some invariants (warn the first time
> a driver receives a packet without having ever set the link state,
> make sure the media status callback sets the valid flag in the
> request, etc) that would probably be very helpful for people who are
> writing network dr
On Thu, Mar 11, 2010 at 3:35 PM, Juli Mallett wrote:
> On Thu, Mar 11, 2010 at 15:30, Qing Li wrote:
>>>
>>> A couple of questions:
>>>
>>> (1) It used to be the case that quite a few interface drivers and types
>>> didn't have a notion of &qu
>
> A couple of questions:
>
> (1) It used to be the case that quite a few interface drivers and types
> didn't have a notion of "link up" -- especially older ethernet devices. Do
> those all have the same problem? It was probably a design oversight that
> devices don't declare an explicit capabi
Author: qingli
Date: Thu Mar 11 17:56:46 2010
New Revision: 205024
URL: http://svn.freebsd.org/changeset/base/205024
Log:
The if_tap interface is of IFT_ETHERNET type, but it
does not set or update the if_link_state variable.
As such RT_LINK_IS_UP() fails for the if_tap interface.
Also,
>
> I looked at it, and at the diff of his original commit. The changes were
> large enough that I don't want to assume his patch takes care of all the
> issues given that patch hasn't been committed verbatim.
>
The change itself is not a huge change but if you disagree, then
please be specific.
Author: qingli
Date: Tue Mar 9 01:11:45 2010
New Revision: 204902
URL: http://svn.freebsd.org/changeset/base/204902
Log:
One of the advantages of enabling ECMP (a.k.a RADIX_MPATH) is to
allow for connection load balancing across interfaces. Currently
the address alias handling method is col
Author: qingli
Date: Sat Feb 27 07:12:25 2010
New Revision: 204402
URL: http://svn.freebsd.org/changeset/base/204402
Log:
Use reference counting instead of locking to secure an address while
that address is being used to generate temporary IPv6 address. This
approach is sufficient and avoids
48 matches
Mail list logo
