Author: qingli
Date: Sat Aug 15 16:48:58 2020
New Revision: 364257
URL: https://svnweb.freebsd.org/changeset/base/364257
Log:
Correct the mask byte order when checking for reserved bits.
Reviewed by: gnn
Approved by: gnn
MFC after:2 weeks
Differential Revision:https://re
t this change.
> >
> > Hi,
> >
> > I'm going to limit the scope of this reply to just you, me and Mike
> > Karels, from whom this originated.
> No, please keep the discussion open. The decision on having that
> particular L2 caching implementation (and L2 cac
'm going to limit the scope of this reply to just you, me and Mike
> Karels, from whom this originated.
>>No, please keep the discussion open. The decision on having that particular
>>L2 caching
>>implementation (and L2 caching in general) i
Author: qingli
Date: Tue Jun 25 00:10:49 2013
New Revision: 252184
URL: http://svnweb.freebsd.org/changeset/base/252184
Log:
Due to the routing related networking kernel redesign work
in FBSD 8.0, interface routes have been returened to the
applications without the RTF_GATEWAY bit. This inco
Author: qingli
Date: Mon Jun 24 05:01:13 2013
New Revision: 252141
URL: http://svnweb.freebsd.org/changeset/base/252141
Log:
Delete the nd6 entries associated with an off-link prefix
if the same prefix cannot be found on an alternative
interface.
Reviewed by: hrs
MFC after:1 week
o I can have
a better look at the issue, and possibly make a suggestion for an alternative
patch ?
--Qing
2012/4/8 Gleb Smirnoff :
> Qing,
>
> On Sun, Apr 08, 2012 at 10:41:11AM -0700, Qing Li wrote:
> Q> This is not the right way to support RFC3021.
> Q>
> Q> The code you
ran into the
described problems.
If we actually need to support RFC 3021, then better do it properly.
--Qing
On Mon, Apr 2, 2012 at 3:44 AM, Gleb Smirnoff wrote:
> Author: glebius
> Date: Mon Apr 2 10:44:25 2012
> New Revision: 233773
> URL: http://svn.freebsd.org/changeset/base/23
or: can't configure address! */
> }
>
> And this is correct way. Look into this from viewpoint of say quagga
> developer.
> One doesn't need to know about this tricks in FreeBSD kernel.
>
Yes, you have a good point there and I agree completely.
--Qing
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
)", again, a failure is just
an indication of an EEXIST.
You may ask why not check for EEXIST before calling these functions, and
I can tell you having worked those code regions for quite some time, the
actual work amounts to the same efforts, but complicates the logic WRT
the callers. It's
from
the return of "if_ioctl()". So why removing the flexibility of what
"if_ioctl()" is
intended for as part of the address configuration logic ?
--Qing
On Mon, Nov 21, 2011 at 6:10 AM, Gleb Smirnoff wrote:
> Author: glebius
> Date: Mon Nov 21 14:10:13 2011
> New Revisio
Author: qingli
Date: Fri Nov 11 23:22:38 2011
New Revision: 227460
URL: http://svn.freebsd.org/changeset/base/227460
Log:
A default route learned from the RAs could be deleted manually
after its installation. This removal may be accidental and can
prevent the default route from being install
Author: qingli
Date: Tue Oct 25 04:06:29 2011
New Revision: 226713
URL: http://svn.freebsd.org/changeset/base/226713
Log:
Exclude host routes when checking for prefix coverage on multiple
interfaces. A host route has a NULL mask so check for that condition.
I have also been told by developer
Author: qingli
Date: Tue Oct 25 00:34:39 2011
New Revision: 226710
URL: http://svn.freebsd.org/changeset/base/226710
Log:
The host-id/interface-id can have a specific value and is properly
masked out when adding a prefix route through the "route" command.
However, when deleting the route, si
Author: qingli
Date: Sun Oct 16 22:24:04 2011
New Revision: 226453
URL: http://svn.freebsd.org/changeset/base/226453
Log:
The code change made in r226040 was incomplete and resulted in
routes such as fe80::1%lo0 no being installed. This patch completes
the original intended fix.
Reviewe
Author: qingli
Date: Sun Oct 16 22:15:13 2011
New Revision: 226451
URL: http://svn.freebsd.org/changeset/base/226451
Log:
The IPv6 code was influx at the time of r196865 due to the L2/L3
separation rewrite changes. r196865 was committed to fix a scope
violation problem in the following test
MFC 225946 is the original patch, 225947 messed up the logic a bit
while putting in the fix for another issue. 226224 is the fix to 225947,
which I will MFC tomorrow.
--Qing
2011/10/10 Gleb Smirnoff :
> Qing,
>
> On Mon, Oct 10, 2011 at 05:41:11PM +0000, Qing Li wrote:
> Q> Aut
Author: qingli
Date: Mon Oct 10 17:41:11 2011
New Revision: 226224
URL: http://svn.freebsd.org/changeset/base/226224
Log:
All indirect routes will fail the rtcheck, except for a special host
route where the destination IP and the gateway IP is the same. This
special case handling is only mea
is the rework of that part of the patch, with some cleaning up
per your suggestion.
Thank you very much for catching that bug.
--Qing
> Q> > Well, after third review it is clear, that
> Q> > next if() case would definitely be true, and you would proceed
> Q> > with re
Hi Gleb,
>
> On Mon, Oct 03, 2011 at 07:51:19PM +, Qing Li wrote:
> Q> Author: qingli
> Q> Date: Mon Oct 3 19:51:18 2011
> Q> New Revision: 225947
> Q> URL: http://svn.freebsd.org/changeset/base/225947
> Q>
> Q> Log:
> Q> A system may have m
Author: qingli
Date: Fri Oct 7 22:22:19 2011
New Revision: 226120
URL: http://svn.freebsd.org/changeset/base/226120
Log:
Do not try removing an ARP entry associated with a given interface
address if that interface does not support ARP. Otherwise the
system will generate error messages unnec
Author: qingli
Date: Fri Oct 7 18:01:34 2011
New Revision: 226114
URL: http://svn.freebsd.org/changeset/base/226114
Log:
Remove the reference held on the loopback route when the interface
address is being deleted. Only the last reference holder deletes the
loopback route. All other delete o
Correct, but local addresses assigned to interfaces that support
address resolution are
still reachable. For those addresses mapped to pseduo interfaces,
those are not reachable
anyways.
See ML thread
http://unix.derkeiler.com/Mailing-Lists/FreeBSD/net/2009-09/msg00241.html
--Qing
On Wed
Author: qingli
Date: Wed Oct 5 16:27:11 2011
New Revision: 226040
URL: http://svn.freebsd.org/changeset/base/226040
Log:
The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to
determine if a loopback route should be installed for an interface
IPv6 address. Another condition is th
Author: qingli
Date: Mon Oct 3 19:51:18 2011
New Revision: 225947
URL: http://svn.freebsd.org/changeset/base/225947
Log:
A system may have multiple physical interfaces, all of which are on the
same prefix. Since a single route entry is installed for the prefix
(without RADIX_MPATH), incomin
Author: qingli
Date: Mon Oct 3 19:06:55 2011
New Revision: 225946
URL: http://svn.freebsd.org/changeset/base/225946
Log:
This patch allows ARP to work properly in the presence of
self-referencing routes. This patch is a rework of r223862.
Reviewed by: bz, zec
MFC after:5 days
Mod
Author: qingli
Date: Mon Sep 5 17:54:19 2011
New Revision: 225405
URL: http://svn.freebsd.org/changeset/base/225405
Log:
The maximum read size of incoming packets is done in 1024-byte increments.
The current code was rounding down the maximum frame size instead of
routing up, resulting in a
Author: qingli
Date: Sun Aug 28 00:14:40 2011
New Revision: 225223
URL: http://svn.freebsd.org/changeset/base/225223
Log:
When an interface address route is removed from the system, another
route with the same prefix is searched for as a replacement. The
current code did not bypass routes th
Author: qingli
Date: Thu Aug 25 04:31:20 2011
New Revision: 225163
URL: http://svn.freebsd.org/changeset/base/225163
Log:
When the RADIX_MPATH kernel option is enabled, the RADIX_MPATH code tries
to find the first route node of an ECMP chain before executing the route
command. If the system
Author: qingli
Date: Sun May 29 02:21:35 2011
New Revision: 222438
URL: http://svn.freebsd.org/changeset/base/222438
Log:
Supply the LLE_STATIC flag bit to in_ifscurb() when scrubbing interface
address so that proper clean up will take place in the routing code.
This patch fixes the bootp pa
Author: qingli
Date: Fri May 20 19:12:20 2011
New Revision: 222143
URL: http://svn.freebsd.org/changeset/base/222143
Log:
The statically configured (permanent) ARP entries are removed when an
interface is brought down, even though the interface address is still
valid. This patch maintains th
Author: qingli
Date: Sun Sep 12 18:04:47 2010
New Revision: 212502
URL: http://svn.freebsd.org/changeset/base/212502
Log:
Adding an address on an interface also requires the loopback route to
that address be installed.
PR: kern/150481
Submitted by: Ingo Flaschberger
MFC aft
Author: qingli
Date: Tue May 25 20:42:35 2010
New Revision: 208553
URL: http://svn.freebsd.org/changeset/base/208553
Log:
This patch fixes the problem where proxy ARP entries cannot be added
over the if_ng interface.
MFC after:3 days
Modified:
head/sys/net/if.c
head/sys/net/if_va
Author: qingli
Date: Thu Mar 18 00:23:39 2010
New Revision: 205272
URL: http://svn.freebsd.org/changeset/base/205272
Log:
Need to set the proper flag bit when inserting ARP
entries into the kernel.
MFC after:3 days
Modified:
head/usr.sbin/ppp/arp.c
Modified: head/usr.sbin/ppp/arp.
Author: qingli
Date: Wed Mar 17 22:12:12 2010
New Revision: 205268
URL: http://svn.freebsd.org/changeset/base/205268
Log:
Set the device capabilities to include dynamic link-state for
those modern drivers.
Reviewed by: imp (and suggested by imp)
MFC after:3 days
Modified:
head/s
Author: qingli
Date: Tue Mar 16 17:59:12 2010
New Revision: 205222
URL: http://svn.freebsd.org/changeset/base/205222
Log:
Verify interface up status using its link state only
if the interface has such capability. The interface
capability flag indicates whether such capability
exists. This
>
> We've got LINK_STATE_UNKNOWN, we can just initialize if_link_state to
> this value in ether_ifattach(). And Qing should treat this value as
> LINK_STATE_UP in routing decision until better times.
>
Thanks everyone for your input.
I generally try to avoid overloading a v
Author: qingli
Date: Fri Mar 12 10:24:58 2010
New Revision: 205077
URL: http://svn.freebsd.org/changeset/base/205077
Log:
The flow-table module retrieves the destination and source
address as well as the transport protocol port information
from the outbound packets. The routing code is gener
Nope, I meant Julian, and what he proposed, and if I understood
correctly, is the simplest
approach and easily done.
-- Qing
On Fri, Mar 12, 2010 at 12:29 AM, Robert N. M. Watson
wrote:
>
> On Mar 12, 2010, at 8:11 AM, Qing Li wrote:
>
>> I like Julian's suggestion beca
I believe what Julian means is the following:
1. in the driver, I do this
ifp->if_flags |= IFF_KNOWS_LINK_STATE;
2. In route.h, I do this
if (ifp->flags & IFF_KNOWS_LINK_STATE) && (ifp->if_link_state ==
LINK_STATE_UP)
return 1;
-- Qing
On Fri, Mar
le when the physical link is down, that person can ping the ML
and ask for driver compatibility list. If we haven't converted that
particular driver by then, we will update the driver if it's capable
at that time.
-- Qing
On Fri, Mar 12, 2010 at 12:00 AM, Robert N. M. Watson
IFT_ETHER only, or also other
> link types?
>
Not sure if I get the assertion suggestion. How would an assertion help here ?
-- Qing
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe,
That's a good idea. I will take your approach.
-- Qing
On Thu, Mar 11, 2010 at 11:15 PM, Julian Elischer wrote:
> Juli Mallett wrote:
>>
>> On Thu, Mar 11, 2010 at 15:39, Qing Li wrote:
>>>
>>> I guess it's a good time to clean things up. The if_
e your patience on this one and will try to get
it resolved quickly.
-- Qing
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
I guess it's a good time to clean things up. The if_link_state code has been
around for quite some time, either it be fully utilized or not be there at all.
The inconsistency is the root cause.
I will try going through these tonight and hopefully the fix all take a
common approach.
-- Qing
ture enhancement is definitely coming but I cannot yet prvoide
a timeline for merge back.
It's mostly a time issue.
Let me know if I have answered these questions to your satisfaction.
-- Qing
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Author: qingli
Date: Thu Mar 11 17:56:46 2010
New Revision: 205024
URL: http://svn.freebsd.org/changeset/base/205024
Log:
The if_tap interface is of IFT_ETHERNET type, but it
does not set or update the if_link_state variable.
As such RT_LINK_IS_UP() fails for the if_tap interface.
Also,
he if_link_state
variable except PPP.
>
> We also have reports of the patch not working in freebsd-curr...@.
>
I have seen that report but it lacks detail. I have asked for more
information and
will investigate further as soon as it becomes available.
-- Qing
___
Author: qingli
Date: Tue Mar 9 01:11:45 2010
New Revision: 204902
URL: http://svn.freebsd.org/changeset/base/204902
Log:
One of the advantages of enabling ECMP (a.k.a RADIX_MPATH) is to
allow for connection load balancing across interfaces. Currently
the address alias handling method is col
Author: qingli
Date: Sat Feb 27 07:12:25 2010
New Revision: 204402
URL: http://svn.freebsd.org/changeset/base/204402
Log:
Use reference counting instead of locking to secure an address while
that address is being used to generate temporary IPv6 address. This
approach is sufficient and avoids
49 matches
Mail list logo
