svn commit: r368743 - head/tests/sys/net

2020-12-17 Thread Kristof Provost
Author: kp Date: Thu Dec 17 21:54:25 2020 New Revision: 368743 URL: https://svnweb.freebsd.org/changeset/base/368743 Log: net tests: Re-enable most if_clone tests All but one of these (tap_ipv6_up_stress) currently pass, so we should enable them so we don't regress. Modified: head/test

svn commit: r368588 - head/sys/netpfil/pf

2020-12-12 Thread Kristof Provost
Author: kp Date: Sat Dec 12 20:14:39 2020 New Revision: 368588 URL: https://svnweb.freebsd.org/changeset/base/368588 Log: pf: Allow net.pf.request_maxcount to be set from loader.conf Mark request_maxcount as RWTUN so we can set it both at runtime and from loader.conf. This avoids usings g

svn commit: r368277 - head/tests/sys/netpfil/pf

2020-12-02 Thread Kristof Provost
Author: kp Date: Wed Dec 2 16:33:23 2020 New Revision: 368277 URL: https://svnweb.freebsd.org/changeset/base/368277 Log: pf tests: Test case for bug #251414 Changing a table from not having counters to having counters (or vice versa) may trigger panics. PR: 251414 MFC af

svn commit: r368239 - head/tests/sys/netpfil/pf

2020-12-01 Thread Kristof Provost
Author: kp Date: Tue Dec 1 16:44:36 2020 New Revision: 368239 URL: https://svnweb.freebsd.org/changeset/base/368239 Log: pf tests: Re-enable panicing tests We've fixed the vnet/epair cleanup race, so it is now safe to re-enable these tests. MFC after:2 weeks Sponsored by: Modi

svn commit: r368238 - head/sys/net

2020-12-01 Thread Kristof Provost
Author: kp Date: Tue Dec 1 16:34:43 2020 New Revision: 368238 URL: https://svnweb.freebsd.org/changeset/base/368238 Log: net: Revert vnet/epair cleanup race mitigation Revert the mitigation code for the vnet/epair cleanup race (done in r365457). r368237 introduced a more reliable fix.

svn commit: r368237 - head/sys/net

2020-12-01 Thread Kristof Provost
Author: kp Date: Tue Dec 1 16:23:59 2020 New Revision: 368237 URL: https://svnweb.freebsd.org/changeset/base/368237 Log: if: Fix panic when destroying vnet and epair simultaneously When destroying a vnet and an epair (with one end in the vnet) we often panicked. This was the result of th

svn commit: r368025 - head/sys/net

2020-11-25 Thread Kristof Provost
Author: kp Date: Wed Nov 25 17:15:24 2020 New Revision: 368025 URL: https://svnweb.freebsd.org/changeset/base/368025 Log: if: Fix non-VIMAGE build if_link_ifnet() and if_unlink_ifnet() are needed even when VIMAGE is not enabled. MFC after:2 weeks Sponsored by: Modirum MDPay Mo

svn commit: r368020 - head/sys/net

2020-11-25 Thread Kristof Provost
Author: kp Date: Wed Nov 25 15:07:22 2020 New Revision: 368020 URL: https://svnweb.freebsd.org/changeset/base/368020 Log: if: Protect V_ifnet in vnet_if_return() When we terminate a vnet (i.e. jail) we move interfaces back to their home vnet. We need to protect our access to the V_ifnet C

svn commit: r368015 - head/sys/net

2020-11-25 Thread Kristof Provost
Author: kp Date: Wed Nov 25 10:56:38 2020 New Revision: 368015 URL: https://svnweb.freebsd.org/changeset/base/368015 Log: if: Remove ifnet_rwlock It no longer serves any purpose, as evidenced by the fact that we never take it without ifnet_sxlock. Sponsored by: Modirum MDPay Diffe

svn commit: r367990 - head/tests/sys/netpfil/pf/ioctl

2020-11-24 Thread Kristof Provost
Author: kp Date: Tue Nov 24 17:32:49 2020 New Revision: 367990 URL: https://svnweb.freebsd.org/changeset/base/367990 Log: pf tests: provoke tag hashing panic Attempt to provoke the panic fixed in r367987. MFC after:1 week Differential Revision:https://reviews.freebsd.org/

svn commit: r367869 - head/tests/sys/netpfil/pf

2020-11-20 Thread Kristof Provost
@@ +# $FreeBSD$ +# +# SPDX-License-Identifier: BSD-2-Clause-FreeBSD +# +# Copyright (c) 2020 Kristof Provost +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code

svn commit: r367867 - head/sys/netpfil/pf

2020-11-20 Thread Kristof Provost
Author: kp Date: Fri Nov 20 10:08:33 2020 New Revision: 367867 URL: https://svnweb.freebsd.org/changeset/base/367867 Log: pf: Fix incorrect assertion We never set PFRULE_RULESRCTRACK when calling pf_insert_src_node(). We do set PFRULE_SRCTRACK, so update the assertion to match. MFC a

Re: svn commit: r367321 - head/sys/amd64/linux

2020-11-04 Thread Kristof Provost
On 4 Nov 2020, at 11:45, Gordon Bergling wrote: Shouldn't such a commit be approved by someone? The committer’s guide seems clear that doc committers may fix comments: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/committer.types.html doc committers may commit documen

svn commit: r367078 - head/sys/riscv/riscv

2020-10-27 Thread Kristof Provost
Author: kp Date: Tue Oct 27 12:44:49 2020 New Revision: 367078 URL: https://svnweb.freebsd.org/changeset/base/367078 Log: riscv: Minor cleanup in startup code - remove setting of register value which is not used until the next value is set - Use the L2_SHIFT constant when setting u

svn commit: r366667 - head/sys/netpfil/pf

2020-10-13 Thread Kristof Provost
Author: kp Date: Tue Oct 13 11:04:00 2020 New Revision: 37 URL: https://svnweb.freebsd.org/changeset/base/37 Log: pf: do not remove kifs that are referenced by rules Even if a kif doesn't have an ifp or if_group pointer we still can't delete it if it's referenced by a rule. In oth

svn commit: r366648 - head/tests/sys/netpfil/pf

2020-10-12 Thread Kristof Provost
Author: kp Date: Mon Oct 12 12:41:10 2020 New Revision: 366648 URL: https://svnweb.freebsd.org/changeset/base/366648 Log: pf tests: Test that 'set skip on ' works on new group members There's a know issue where new group members don't get the 'set skip on' applied until the rules are re-l

svn commit: r366647 - head/sys/netpfil/pf

2020-10-12 Thread Kristof Provost
Author: kp Date: Mon Oct 12 12:39:37 2020 New Revision: 366647 URL: https://svnweb.freebsd.org/changeset/base/366647 Log: pf: create a kif for flags If userspace tries to set flags (e.g. 'set skip on ') and doesn't exist we should create a kif so that we apply the flags when the does

svn commit: r366500 - head/sys/net

2020-10-06 Thread Kristof Provost
Author: kp Date: Tue Oct 6 19:19:56 2020 New Revision: 366500 URL: https://svnweb.freebsd.org/changeset/base/366500 Log: bridge: call member interface ioctl() without NET_EPOCH We're not allowed to hold NET_EPOCH while sleeping, so when we call ioctl() handlers for member interfaces we c

svn commit: r366461 - head/sbin/devfs

2020-10-05 Thread Kristof Provost
Author: kp Date: Mon Oct 5 19:26:54 2020 New Revision: 366461 URL: https://svnweb.freebsd.org/changeset/base/366461 Log: devfs.rules: unhide pf in vnet jails /dev/pf is usable in vnet jails, so don't hide the node there. We shouldn't expose /dev/pf in regular jails, as that gives them

svn commit: r366355 - head/sys/riscv/riscv

2020-10-02 Thread Kristof Provost
Author: kp Date: Fri Oct 2 07:30:11 2020 New Revision: 366355 URL: https://svnweb.freebsd.org/changeset/base/366355 Log: riscv: handle access faults in user mode Access faults in user mode are treated like TLB misses, which leads to an endless loop of faults. It's less serious than the s

svn commit: r366315 - in head/sys/riscv: include riscv

2020-10-01 Thread Kristof Provost
Author: kp Date: Thu Oct 1 15:04:55 2020 New Revision: 366315 URL: https://svnweb.freebsd.org/changeset/base/366315 Log: riscv: Add memmmap so we can mmap /dev/mem Reviewed by: mhorne Sponsored by: Axiado Differential Revision:https://reviews.freebsd.org/D26622 Modified: he

svn commit: r366284 - head/sys/riscv/riscv

2020-09-30 Thread Kristof Provost
Author: kp Date: Wed Sep 30 08:23:43 2020 New Revision: 366284 URL: https://svnweb.freebsd.org/changeset/base/366284 Log: riscv: Panic on PMP errors Load/store/fetch access exceptions always indicate a violation of a PMP rule. We can't treat those as page faults, because updating the page

svn commit: r365626 - in head/sys/cddl/dev: dtrace/riscv fbt/riscv

2020-09-11 Thread Kristof Provost
Author: kp Date: Fri Sep 11 09:15:49 2020 New Revision: 365626 URL: https://svnweb.freebsd.org/changeset/base/365626 Log: dtrace: fix fbt return probes on RISC-V Return values are passed in a0, so read it from there. We also pass a1 through to userspace, as the ABI allows small structs to

svn commit: r365457 - head/sys/net

2020-09-08 Thread Kristof Provost
Author: kp Date: Tue Sep 8 14:54:10 2020 New Revision: 365457 URL: https://svnweb.freebsd.org/changeset/base/365457 Log: net: mitigate vnet / epair cleanup races There's a race where dying vnets move their interfaces back to their original vnet, and if_epair cleanup (where deleting one i

svn commit: r365246 - head/sys/netgraph

2020-09-02 Thread Kristof Provost
Author: kp Date: Wed Sep 2 11:49:22 2020 New Revision: 365246 URL: https://svnweb.freebsd.org/changeset/base/365246 Log: ng_ether: Enter NET_EPOCH where required We must enter NET_EPOCH before calling ether_output_frame(). Several of the functions it calls (pfil_run_hooks, if_transmit) e

svn commit: r365245 - head/sys/riscv/riscv

2020-09-02 Thread Kristof Provost
Author: kp Date: Wed Sep 2 11:33:31 2020 New Revision: 365245 URL: https://svnweb.freebsd.org/changeset/base/365245 Log: riscv: very large dma mappings can cause integer overflow Fix the return type for _bus_dmamap_addseg(). Based on the same fix done for arm64 in r348571. Sponsored

svn commit: r363796 - in head: lib/libc/riscv/gen sys/riscv/include

2020-08-03 Thread Kristof Provost
= --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lib/libc/riscv/gen/fpgetmask.c Mon Aug 3 12:48:51 2020 (r363796) @@ -0,0 +1,41 @@ +/*- + * Copyright (c) 2020 Axiado + * All rights reserved. + * + * This software was developed by Kristof Provost under + * s

Re: svn commit: r363308 - head/sys/net

2020-07-18 Thread Kristof Provost
On 18 Jul 2020, at 20:47, Konstantin Belousov wrote: On Sat, Jul 18, 2020 at 12:43:11PM +, Kristof Provost wrote: Author: kp Date: Sat Jul 18 12:43:11 2020 New Revision: 363308 URL: https://svnweb.freebsd.org/changeset/base/363308 Log: bridge: Don't sleep during epoch Whi

svn commit: r363308 - head/sys/net

2020-07-18 Thread Kristof Provost
Author: kp Date: Sat Jul 18 12:43:11 2020 New Revision: 363308 URL: https://svnweb.freebsd.org/changeset/base/363308 Log: bridge: Don't sleep during epoch While it doesn't trigger INVARIANTS or WITNESS on head it does in stable/12. There's also no reason for it, as we can easily report th

svn commit: r362977 - head/sys/riscv/riscv

2020-07-06 Thread Kristof Provost
Author: kp Date: Mon Jul 6 21:29:50 2020 New Revision: 362977 URL: https://svnweb.freebsd.org/changeset/base/362977 Log: riscv plic: Do not complete interrupts until the interrupt handler has run We cannot complete the interrupt (i.e. write to the claims/complete register until the inter

svn commit: r362853 - in head/sys/riscv: include riscv

2020-07-01 Thread Kristof Provost
Author: kp Date: Wed Jul 1 19:15:43 2020 New Revision: 362853 URL: https://svnweb.freebsd.org/changeset/base/362853 Log: riscv pmap: zero reserved pte bits in ppn The top 10 bits of a pte are reserved by specification[1] and are not part of the PPN. [1] 'Volume II: RISC-V Privileged

svn commit: r362852 - head/sys/riscv/riscv

2020-07-01 Thread Kristof Provost
Author: kp Date: Wed Jul 1 19:12:47 2020 New Revision: 362852 URL: https://svnweb.freebsd.org/changeset/base/362852 Log: riscv locore.S: load constant prior to loop A very minor micro-optimization; t0 is not clobbered between the loop top and bottom and there appear to be no other branch

svn commit: r362851 - head/sys/riscv/riscv

2020-07-01 Thread Kristof Provost
Author: kp Date: Wed Jul 1 19:11:02 2020 New Revision: 362851 URL: https://svnweb.freebsd.org/changeset/base/362851 Log: riscv: Log missing registers in dump_regs() If we panic we dump the registers for debugging. This is very useful, but it missed several registers (ra, sp, gp and tp).

svn commit: r362235 - head/contrib/llvm-project/clang/lib/Driver/ToolChains/Arch

2020-06-16 Thread Kristof Provost
Author: kp Date: Tue Jun 16 18:39:56 2020 New Revision: 362235 URL: https://svnweb.freebsd.org/changeset/base/362235 Log: llvm: Default to -mno-relax on RISC-V Compiling on a RISC-V system fails with 'relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-r

Re: svn commit: r362217 - head/stand/common

2020-06-16 Thread Kristof Provost
On 16 Jun 2020, at 19:11, Ed Maste wrote: On Tue, 16 Jun 2020 at 13:01, Ian Lepore wrote: As much as I prefer doing it this way, style(9) doesn't allow for variable declarations inside a for() statement (or even inside a local block, which is just too 1980s for me, but it is still our standa

svn commit: r361893 - head/tests/sys/net

2020-06-07 Thread Kristof Provost
Author: kp Date: Sun Jun 7 13:53:02 2020 New Revision: 361893 URL: https://svnweb.freebsd.org/changeset/base/361893 Log: bridge tests: Re-enable STP test This test should no longer provoke large amounts of traffic, which can overwhelm single-core systems, preventing them from making prog

svn commit: r361701 - head/tests/sys/net

2020-06-01 Thread Kristof Provost
Author: kp Date: Mon Jun 1 19:26:16 2020 New Revision: 361701 URL: https://svnweb.freebsd.org/changeset/base/361701 Log: bridge tests: Avoid building a switching loop Enable STP before bringing the bridges up. This avoids a switching loop, which has a tendency to drown out progress in us

svn commit: r361279 - head/sys/dev/bnxt

2020-05-20 Thread Kristof Provost
Author: kp Date: Wed May 20 16:07:37 2020 New Revision: 361279 URL: https://svnweb.freebsd.org/changeset/base/361279 Log: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two Reviewed by: gallatin, rpokala MFC after:2 weeks Differential Revision:https://reviews.freebsd

Re: svn commit: r347418 - head/sys/net

2020-05-19 Thread Kristof Provost
On 19 May 2020, at 17:02, Andrew Gallatin wrote: On 2020-05-19 04:21, Kristof Provost wrote: The if_bnxt driver initialises |.isc_nrxd_max = {INT32_MAX, INT32_MAX, INT32_MAX},|, so presumably that’s the cause. I don’t know what a sane value would be though. I’ve defaulted to 4096 (because

Re: svn commit: r347418 - head/sys/net

2020-05-19 Thread Kristof Provost
On 10 May 2019, at 2:41, Eric Joyner wrote: Author: erj Date: Fri May 10 00:41:42 2019 New Revision: 347418 URL: https://svnweb.freebsd.org/changeset/base/347418 Log: iflib: use default ntxd and nrxd when user value is not power of 2 From Jake: A user may set a sysctl to override the defa

svn commit: r360935 - head/sys/opencrypto

2020-05-11 Thread Kristof Provost
Author: kp Date: Mon May 11 21:42:19 2020 New Revision: 360935 URL: https://svnweb.freebsd.org/changeset/base/360935 Log: opencrypto: Add missing ioctl exit SDTs The opencrypto ioctl code has very useful probe points at the various exit points. These allow us to figure out exactly why a r

svn commit: r360609 - head/sys/netpfil/pf

2020-05-03 Thread Kristof Provost
Author: kp Date: Sun May 3 16:09:35 2020 New Revision: 360609 URL: https://svnweb.freebsd.org/changeset/base/360609 Log: pf: Improve DIOCADDRULE validation We expect the addrwrap.p.dyn value to be set to NULL (and assert such), but do not verify it on input. Reported-by: syzbot+936

svn commit: r360347 - head/sys/netpfil/pf

2020-04-26 Thread Kristof Provost
Author: kp Date: Sun Apr 26 16:30:00 2020 New Revision: 360347 URL: https://svnweb.freebsd.org/changeset/base/360347 Log: pf: Virtualise pf_frag_mtx The pf_frag_mtx mutex protects the fragments queue. The fragments queue is virtualised already (i.e. per-vnet) so it makes no sense to block

svn commit: r360346 - head/tests/sys/net

2020-04-26 Thread Kristof Provost
Author: kp Date: Sun Apr 26 16:27:03 2020 New Revision: 360346 URL: https://svnweb.freebsd.org/changeset/base/360346 Log: bridge tests: Test for #216510 We used to have an issue with recursive locking with net.link.bridge.inherit_mac. This causes us to send an ARP request while we hold

svn commit: r360345 - head/sys/net

2020-04-26 Thread Kristof Provost
Author: kp Date: Sun Apr 26 16:22:35 2020 New Revision: 360345 URL: https://svnweb.freebsd.org/changeset/base/360345 Log: bridge: epoch-ification Run the bridge datapath under epoch, rather than under the BRIDGE_LOCK(). We still take the BRIDGE_LOCK() whenever we insert or delete ite

svn commit: r360344 - head/sys/netpfil/pf

2020-04-26 Thread Kristof Provost
Author: kp Date: Sun Apr 26 16:16:39 2020 New Revision: 360344 URL: https://svnweb.freebsd.org/changeset/base/360344 Log: pf: Improve input validation If we pass an anchor name which doesn't exist pfr_table_count() returns -1, which leads to an overflow in mallocarray() and thus a panic.

svn commit: r360231 - head/lib/libc/net

2020-04-23 Thread Kristof Provost
Author: kp Date: Thu Apr 23 21:16:51 2020 New Revision: 360231 URL: https://svnweb.freebsd.org/changeset/base/360231 Log: libc: Shortcut if_indextoname() if index == 0 If the index we're trying to convert is 0 we can avoid a potentially expensive call to getifaddrs(). No interface has an

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-21 Thread Kristof Provost
On 21 Apr 2020, at 4:34, Kyle Evans wrote: On Mon, Apr 20, 2020 at 9:14 PM Kyle Evans wrote: On Mon, Apr 20, 2020 at 8:15 PM Eric van Gyzen wrote: + sz = asprintf(&buf, M_TEMP, "%s-%s-%s", uuid, if_name(ifp), + jailname); + if (sz < 0) { + /* Fall back to a random mac addr

svn commit: r360099 - head/tests/sys/net

2020-04-19 Thread Kristof Provost
Author: kp Date: Sun Apr 19 16:30:49 2020 New Revision: 360099 URL: https://svnweb.freebsd.org/changeset/base/360099 Log: bridge tests: Ensure that bridges in different jails get different MAC addresses We used to have a problem where bridges created in different vnet jails would end up

svn commit: r360098 - head/sys/netpfil/pf

2020-04-19 Thread Kristof Provost
Author: kp Date: Sun Apr 19 16:10:20 2020 New Revision: 360098 URL: https://svnweb.freebsd.org/changeset/base/360098 Log: pf: Improve ioctl() input validation Both DIOCCHANGEADDR and DIOCADDADDR take a struct pf_pooladdr from userspace. They failed to validate the dyn pointer contained in

svn commit: r360097 - head/sbin/pfctl

2020-04-19 Thread Kristof Provost
Author: kp Date: Sun Apr 19 15:37:13 2020 New Revision: 360097 URL: https://svnweb.freebsd.org/changeset/base/360097 Log: pfctl: Call ifa_load() before ifa_grouplookup() ifa_grouplookup() uses the data loaded in ifa_load() (through is_a_group()), so we must call ifa_load() before we can

svn commit: r360096 - head/sbin/pfctl

2020-04-19 Thread Kristof Provost
Author: kp Date: Sun Apr 19 15:32:14 2020 New Revision: 360096 URL: https://svnweb.freebsd.org/changeset/base/360096 Log: pfctl: Remove unused variable Submitted by: Nick Rogers MFC after:1 week Sponsored by: RG Nets Modified: head/sbin/pfctl/pfctl_parser.c Modified: head/sbin/p

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-19 Thread Kristof Provost
On 19 Apr 2020, at 15:33, Ronald Klop wrote: On Sat, 18 Apr 2020 09:50:30 +0200, Kristof Provost wrote: Author: kp Date: Sat Apr 18 07:50:30 2020 New Revision: 360068 URL: https://svnweb.freebsd.org/changeset/base/360068 Log: ethersubr: Make the mac address generation more robust If we

svn commit: r360069 - head/sys/net

2020-04-18 Thread Kristof Provost
Author: kp Date: Sat Apr 18 08:00:58 2020 New Revision: 360069 URL: https://svnweb.freebsd.org/changeset/base/360069 Log: bridge: Simplify mac address generation Unconditionally use ether_gen_addr() to generate bridge mac addresses. This function is now less likely to generate duplicate

svn commit: r360068 - in head/sys: kern net sys

2020-04-18 Thread Kristof Provost
Author: kp Date: Sat Apr 18 07:50:30 2020 New Revision: 360068 URL: https://svnweb.freebsd.org/changeset/base/360068 Log: ethersubr: Make the mac address generation more robust If we create two (vnet) jails and create a bridge interface in each we end up with the same mac address on both

svn commit: r360043 - head/tests/sys/net

2020-04-17 Thread Kristof Provost
Author: kp Date: Fri Apr 17 14:57:15 2020 New Revision: 360043 URL: https://svnweb.freebsd.org/changeset/base/360043 Log: bridge tests: Test deleting a bridge with members Reviewed by: philip, emaste Sponsored by: The FreeBSD Foundation Differential Revision:https://reviews.fre

svn commit: r360042 - head/sys/netpfil/pf

2020-04-17 Thread Kristof Provost
Author: kp Date: Fri Apr 17 14:35:11 2020 New Revision: 360042 URL: https://svnweb.freebsd.org/changeset/base/360042 Log: pf: Do not allow negative ps_len in DIOCGETSTATES Userspace may pass a negative ps_len value to us, which causes an assertion failure in malloc(). Treat negative val

svn commit: r359828 - head/tests/sys/netinet

2020-04-12 Thread Kristof Provost
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/tests/sys/netinet/carp.sh Sun Apr 12 16:13:05 2020 (r359828) @@ -0,0 +1,152 @@ +# $FreeBSD$ +# +# SPDX-License-Identifier: BSD-2-Clause-FreeBSD +# +# Copyright (c) 2020 Kristof Provost

svn commit: r359827 - head/sys/netinet

2020-04-12 Thread Kristof Provost
Author: kp Date: Sun Apr 12 16:09:21 2020 New Revision: 359827 URL: https://svnweb.freebsd.org/changeset/base/359827 Log: carp: Widen epoch coverage Fix panics related to calling code which expects to be running inside the NET_EPOCH from outside that epoch. This leads to panics (with

svn commit: r359641 - head/sys/net

2020-04-05 Thread Kristof Provost
Author: kp Date: Sun Apr 5 17:15:20 2020 New Revision: 359641 URL: https://svnweb.freebsd.org/changeset/base/359641 Log: bridge: Change lists to CK_LIST as a peparation for epochification Prepare the ground for a rework of the bridge locking approach. We will use an epoch-based approach

Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Kristof Provost
On 31 Mar 2020, at 17:28, Kristof Provost wrote: On 31 Mar 2020, at 17:17, Mark Johnston wrote: On Tue, Mar 31, 2020 at 03:51:27PM +0800, Li-Wen Hsu wrote: On Tue, Mar 31, 2020 at 3:00 PM Kristof Provost wrote: On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote: On Tue, Mar 31, 2020 at 10:55 AM Mark

Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Kristof Provost
On 31 Mar 2020, at 17:17, Mark Johnston wrote: On Tue, Mar 31, 2020 at 03:51:27PM +0800, Li-Wen Hsu wrote: On Tue, Mar 31, 2020 at 3:00 PM Kristof Provost wrote: On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote: On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston wrote: It seems could be triggered by

Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Kristof Provost
On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote: > On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston wrote: It seems could be triggered by sys.netinet6.frag6.* sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there are lots of test cases timed out. Can you help check these?

svn commit: r359130 - head/sbin/pfctl

2020-03-19 Thread Kristof Provost
Author: kp Date: Thu Mar 19 12:54:43 2020 New Revision: 359130 URL: https://svnweb.freebsd.org/changeset/base/359130 Log: pfctl: improve rule load times with thousands of interfaces r343287 / D18759 introduced ifa_add_groups_to_map() which is now run by ifa_load/ifa_lookup/host_if. When l

svn commit: r359010 - head/tests/sys/net

2020-03-16 Thread Kristof Provost
Author: kp Date: Mon Mar 16 08:44:46 2020 New Revision: 359010 URL: https://svnweb.freebsd.org/changeset/base/359010 Log: bridge tests: Basic span test Reviewed by: philip, emaste (previous version) Sponsored by: The FreeBSD Foundation Differential Revision:https://reviews.free

svn commit: r358830 - head/tests/sys/net

2020-03-09 Thread Kristof Provost
Author: kp Date: Tue Mar 10 06:29:59 2020 New Revision: 358830 URL: https://svnweb.freebsd.org/changeset/base/358830 Log: bridge test: adding and removing static addresses Reviewed by: philip Sponsored by: The FreeBSD Foundation Differential Revision:https://reviews.freebsd.org

svn commit: r358829 - head/tests/sys/net

2020-03-09 Thread Kristof Provost
Author: kp Date: Tue Mar 10 06:28:45 2020 New Revision: 358829 URL: https://svnweb.freebsd.org/changeset/base/358829 Log: bridge test: spanning tree Basic test case where we create a bridge loop, verify that we really are looping and then enable spanning tree to resolve the loop. Rev

Re: svn commit: r358463 - head/sbin/pfctl/tests/files

2020-02-29 Thread Kristof Provost
> On 29 Feb 2020, at 14:24, Li-Wen Hsu wrote: > > Author: lwhsu > Date: Sat Feb 29 13:24:41 2020 > New Revision: 358463 > URL: https://svnweb.freebsd.org/changeset/base/358463 > > Log: > Fix test cases after r358448 > > sbin.pfctl.pfctl_test.pf0087 > sbin.pfctl.pfctl_test.selfpf0087 > Th

svn commit: r358325 - head/sys/net

2020-02-26 Thread Kristof Provost
Author: kp Date: Wed Feb 26 08:47:18 2020 New Revision: 358325 URL: https://svnweb.freebsd.org/changeset/base/358325 Log: bridge: Move locking defines into if_bridge.c The locking defines for if_bridge used to live in if_bridgevar.h, but they're only ever used by the bridge implementation

Re: svn commit: r358167 - head/sys/netinet6

2020-02-25 Thread Kristof Provost
On 24 Feb 2020, at 15:21, Hans Petter Selasky wrote: On 2020-02-20 11:56, Bjoern A. Zeeb wrote: + + unfragpartlen = optlen + sizeof(struct ip6_hdr); + Hi Bjoren, This change introduces a slight regression when a host replies to IPv6 ping fragmented packets. The problem is the "

Re: svn commit: r358262 - head/sys/conf

2020-02-23 Thread Kristof Provost
Thanks! On 23 Feb 2020, at 20:04, Warner Losh wrote: Author: imp Date: Sun Feb 23 19:04:15 2020 New Revision: 358262 URL: https://svnweb.freebsd.org/changeset/base/358262 Log: Use MACHINE_ARCH instead of TARGET_ARCH TARGET_ARCH is only for use in Makefile.inc1 contexts. MACHINE_ARCH is th

svn commit: r358247 - in head/sys: conf riscv/include

2020-02-22 Thread Kristof Provost
Author: kp Date: Sat Feb 22 13:23:27 2020 New Revision: 358247 URL: https://svnweb.freebsd.org/changeset/base/358247 Log: riscv: Set MACHINE_ARCH correctly MACHINE_ARCH sets the hw.machine_arch sysctl in the kernel. In userspace it sets MACHINE_ARCH in bmake, which bsd.cpu.mk uses to conf

svn commit: r358178 - head/sys/dev/virtio/mmio

2020-02-20 Thread Kristof Provost
Author: kp Date: Thu Feb 20 17:26:08 2020 New Revision: 358178 URL: https://svnweb.freebsd.org/changeset/base/358178 Log: virtio: Pass the interrupt type in mmio mode When we register an interrupt handler we need to pass the intr_type along in bus_setup_intr(). The interrupt type mat

svn commit: r358124 - head/tests/sys/net

2020-02-19 Thread Kristof Provost
# # This software was developed by Kristof Provost under sponsorship # from the FreeBSD Foundation. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r357998 - in head/tests/sys: common net

2020-02-16 Thread Kristof Provost
reeBSD Foundation +# All rights reserved. +# +# This software was developed by Kristof Provost under sponsorship +# from the FreeBSD Foundation. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met

svn commit: r357857 - head/tests/sys

2020-02-13 Thread Kristof Provost
Author: kp Date: Thu Feb 13 14:09:09 2020 New Revision: 357857 URL: https://svnweb.freebsd.org/changeset/base/357857 Log: tests: Enable net tests We have a number of tests in the net subdirectory that were not executed. List the net directory so we run those tests. Modified: head/tests

Re: svn commit: r357233 - head/sys/net

2020-02-04 Thread Kristof Provost
On 4 Feb 2020, at 11:32, Gleb Smirnoff wrote: On Sat, Feb 01, 2020 at 07:26:48PM +, Kristof Provost wrote: K> > K> -/* The below interface used only by epair(4). */ K> > K> +/* The below interfaces are used only by epair(4). */ K> > K> +void if_clone_addif(stru

svn commit: r357375 - head/tests/sys/net

2020-02-01 Thread Kristof Provost
Author: kp Date: Sat Feb 1 19:40:11 2020 New Revision: 357375 URL: https://svnweb.freebsd.org/changeset/base/357375 Log: tests: epair: Don't fail if we load if_epair kldload() returns a positive integer when it loads a ko, so check that the return value is -1 to detect error cases, not t

Re: svn commit: r357233 - head/sys/net

2020-02-01 Thread Kristof Provost
On 30 Jan 2020, at 16:34, Gleb Smirnoff wrote: On Tue, Jan 28, 2020 at 10:44:25PM +, Kristof Provost wrote: K> Author: kp K> Date: Tue Jan 28 22:44:24 2020 K> New Revision: 357233 K> URL: https://svnweb.freebsd.org/changeset/base/357233 K> K> Log: K> epair: D

svn commit: r357365 - head/tests/sys/net

2020-02-01 Thread Kristof Provost
Author: kp Date: Sat Feb 1 11:31:45 2020 New Revision: 357365 URL: https://svnweb.freebsd.org/changeset/base/357365 Log: tests: epair: Don't fail if the if_epair module is already loaded kldload() returns an error (EEXIST) if the module is already loaded. That's not a problem for us, so

svn commit: r357356 - head/sys/net

2020-01-31 Thread Kristof Provost
Author: kp Date: Fri Jan 31 22:54:44 2020 New Revision: 357356 URL: https://svnweb.freebsd.org/changeset/base/357356 Log: vlan: Fix panic when vnet jail with a vlan interface is destroyed During vnet cleanup vnet_if_uninit() checks that no more interfaces remain in the vnet. Any interface

svn commit: r357234 - head/tests/sys/net

2020-01-28 Thread Kristof Provost
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/tests/sys/net/if_epair.c Tue Jan 28 22:46:51 2020 (r357234) @@ -0,0 +1,73 @@ +/*- + * Copyright (c) 2020 Kristof Provost

svn commit: r357233 - head/sys/net

2020-01-28 Thread Kristof Provost
Author: kp Date: Tue Jan 28 22:44:24 2020 New Revision: 357233 URL: https://svnweb.freebsd.org/changeset/base/357233 Log: epair: Do not abuse params to register the second interface if_epair used the 'params' argument to pass a pointer to the b interface through if_clone_create(). This

svn commit: r357113 - head/tests/sys/net/routing

2020-01-25 Thread Kristof Provost
Author: kp Date: Sat Jan 25 10:51:51 2020 New Revision: 357113 URL: https://svnweb.freebsd.org/changeset/base/357113 Log: tests: Routing tests overwrote net tests The routing subdirectory installed into the same directory as the test tests, which caused them to overwrite the net Kyuafile.

svn commit: r357061 - head/sys/netpfil/pf

2020-01-23 Thread Kristof Provost
Author: kp Date: Thu Jan 23 22:13:41 2020 New Revision: 357061 URL: https://svnweb.freebsd.org/changeset/base/357061 Log: pf: Apply kif flags to new group members If we have a 'set skip on ' rule this flag it set on the group kif, but must also be set on all members. pfctl does this when

svn commit: r356995 - head/sys/netpfil/pf

2020-01-22 Thread Kristof Provost
Author: kp Date: Wed Jan 22 21:01:19 2020 New Revision: 356995 URL: https://svnweb.freebsd.org/changeset/base/356995 Log: pfsync: Ensure we enter network epoch before calling ip_output As of r356974 calls to ip_output() require us to be in the network epoch. That wasn't the case for the c

svn commit: r356816 - head/usr.sbin/periodic/etc/security

2020-01-16 Thread Kristof Provost
Author: kp Date: Thu Jan 16 22:08:05 2020 New Revision: 356816 URL: https://svnweb.freebsd.org/changeset/base/356816 Log: Fix pfdenied not returning any results When _a is empty we end up with an invalid invocation of pfctl, and no output. We must add quotes to make it clear to pfctl that

svn commit: r356687 - in head/usr.bin: . gprof

2020-01-13 Thread Kristof Provost
Author: kp Date: Mon Jan 13 16:52:26 2020 New Revision: 356687 URL: https://svnweb.freebsd.org/changeset/base/356687 Log: gprof: Enable riscv Add a missing riscv.h header file, and fix the check for riscv (must test MACHINE_CPUARCH, not MACHINE_ARCH, if we want to use 'riscv'). Spons

svn commit: r356484 - head/sys/dev/virtio/network

2020-01-08 Thread Kristof Provost
Author: kp Date: Wed Jan 8 10:06:32 2020 New Revision: 356484 URL: https://svnweb.freebsd.org/changeset/base/356484 Log: vtnet: Pre-allocate debugnet data immediately Don't wait until the vtnet_debugnet_init() call happens, because at that point we might already have allocated something

svn commit: r356438 - head/sys/riscv/sifive

2020-01-07 Thread Kristof Provost
Author: kp Date: Tue Jan 7 09:02:14 2020 New Revision: 356438 URL: https://svnweb.freebsd.org/changeset/base/356438 Log: sifive: Fix incorrect tx/rx ctrl defines Happily these were never used, but they should be correct anyway. Reported by: Nicholas O'Brien Sponsored by: Axiado M

svn commit: r356223 - head/sys/riscv/riscv

2019-12-31 Thread Kristof Provost
Author: kp Date: Tue Dec 31 11:45:19 2019 New Revision: 356223 URL: https://svnweb.freebsd.org/changeset/base/356223 Log: riscv: Remove unused variable Fix the build that was broken by r356221. Pointy hat to myself. Modified: head/sys/riscv/riscv/mp_machdep.c Modified: head/sys/riscv/ri

svn commit: r356222 - head/sys/riscv/sifive

2019-12-31 Thread Kristof Provost
(r356222) @@ -0,0 +1,543 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * + * Copyright (c) 2019 Axiado Corporation + * All rights reserved. + * + * This software was developed in part by Kristof Provost under contract for + * Axiado Corporation. + * + * Redistribution and use in source and

svn commit: r356221 - head/sys/riscv/riscv

2019-12-31 Thread Kristof Provost
Author: kp Date: Tue Dec 31 10:53:03 2019 New Revision: 356221 URL: https://svnweb.freebsd.org/changeset/base/356221 Log: riscv: Remove pointless loop There's no point in checking for absent CPUs if we're not going to do anything about either the present or absent case. This loop can just

Re: svn commit: r356078 - head/sys/conf

2019-12-25 Thread Kristof Provost
> On 25 Dec 2019, at 19:24, Ian Lepore wrote: > > Author: ian > Date: Wed Dec 25 18:24:38 2019 > New Revision: 356078 > URL: https://svnweb.freebsd.org/changeset/base/356078 > > Log: > Revert r356077, apparently the change doesn't work after all (failed to > build in CI). I built with (an

svn commit: r355744 - head/sys/netpfil/pf

2019-12-13 Thread Kristof Provost
Author: kp Date: Sat Dec 14 02:06:07 2019 New Revision: 355744 URL: https://svnweb.freebsd.org/changeset/base/355744 Log: pf: Make request_maxcount runtime adjustable There's no reason for this to be a tunable. It's perfectly safe to change this at runtime. Reviewed by: Lutz Donnerh

svn commit: r355743 - head/sbin/pfctl

2019-12-13 Thread Kristof Provost
Author: kp Date: Sat Dec 14 02:03:47 2019 New Revision: 355743 URL: https://svnweb.freebsd.org/changeset/base/355743 Log: pfctl: Warn users when they run into kernel limits Warn users when they try to add/delete/modify more items than the kernel will allow. Reviewed by: allanjude (p

svn commit: r355518 - head/share/man/man5

2019-12-07 Thread Kristof Provost
Author: kp Date: Sun Dec 8 02:11:06 2019 New Revision: 355518 URL: https://svnweb.freebsd.org/changeset/base/355518 Log: pf: Remove references to 'egress' Avoid giving users the impression that FreeBSD has the automatic interface group 'egress'. Submitted by: tj AT mrsk.me Modified

svn commit: r355425 - head/sys/netinet6

2019-12-05 Thread Kristof Provost
Author: kp Date: Thu Dec 5 16:50:54 2019 New Revision: 355425 URL: https://svnweb.freebsd.org/changeset/base/355425 Log: Remove useless NULL check Coverity points out that we've already dereferenced m by the time we check, so there's no reason to keep the check. Moreover, it's safe to pa

svn commit: r355054 - head/sys/netpfil/pf

2019-11-24 Thread Kristof Provost
Author: kp Date: Sun Nov 24 13:53:36 2019 New Revision: 355054 URL: https://svnweb.freebsd.org/changeset/base/355054 Log: pf: Add endline to all DPFPRINTF() DPFPRINTF() doesn't automatically add an endline, so be consistent and always add it. Modified: head/sys/netpfil/pf/pf.c head/s

Re: svn commit: r354553 - in head/tests/sys: netinet6 netpfil/common netpfil/pf

2019-11-09 Thread Kristof Provost
Thank you! Kristof > On 8 Nov 2019, at 19:56, Li-Wen Hsu wrote: > > Author: lwhsu > Date: Fri Nov 8 18:56:02 2019 > New Revision: 354553 > URL: https://svnweb.freebsd.org/changeset/base/354553 > > Log: > Reenable netinet6 and netpfil tests on i386, net/scapy 2.4.3_2 contains the > fix > >

  1   2   3   4   5   >