Re: svn commit: r333911 - head/sys/netinet

2018-05-21 Thread Jonathan Looney
On Sat, May 19, 2018 at 10:27 PM, Matt Macy wrote: > + il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb > *), M_TEMP, M_WAITOK|M_ZERO); > + inp_list = il->il_inp_list; > Why does this need M_ZERO? Jonathan ___ svn-src-head@f

Re: svn commit: r333494 - head/share/man/man7

2018-05-15 Thread Jonathan Looney
On Sun, May 13, 2018 at 8:14 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > It did take me some time to track down this "crazy concept you all > think I just invented", but it is infact in the GNU groff info > documentaton (found on my 5.4 systems in /usr/share/info/groff.info.gz

Re: svn commit: r332770 - in head/sys: conf netinet netinet/tcp_stacks sys

2018-05-01 Thread Jonathan Looney
On Mon, Apr 30, 2018 at 3:16 AM, hiren panchasara < hi...@strugglingcoder.info> wrote: > > In my understanding, default stack currently cannot use this mechanism. When do > you think that'll be possible? I think I can speak to Randall's plans for this. Randall chose not to include in this commit

Re: svn commit: r332860 - head/sys/kern

2018-04-21 Thread Jonathan Looney
On Sat, Apr 21, 2018 at 1:53 PM, Conrad Meyer wrote: > > I don't think this should be enabled by default. Can we leave it > disabled by default and let consumers opt-in? I'm willing to change the default if there's a good reason or consensus for that. However, it is not obvious to me that the de

Re: svn commit: r331347 - in head: etc/mtree include sys/conf sys/dev/tcp_log sys/kern sys/netinet usr.bin/netstat

2018-03-24 Thread Jonathan Looney
Compilation should be fixed as of r331483. I also made this an optional feature in r331485. If you find more problems, please let me know. Jonathan ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsub

Re: svn commit: r331347 - in head: etc/mtree include sys/conf sys/dev/tcp_log sys/kern sys/netinet usr.bin/netstat

2018-03-23 Thread Jonathan Looney
On Thu, Mar 22, 2018 at 9:05 PM, Justin Hibbits wrote: > On Thu, Mar 22, 2018 at 3:44 PM, Andriy Gapon wrote: > > On 22/03/2018 17:39, Jonathan Looney wrote: > >> A tinderbox build didn't complain about atomic_fetchadd_64, so I assume > it is OK. > >> &

Re: svn commit: r331347 - in head: etc/mtree include sys/conf sys/dev/tcp_log sys/kern sys/netinet usr.bin/netstat

2018-03-22 Thread Jonathan Looney
A tinderbox build didn't complain about atomic_fetchadd_64, so I assume it is OK. Yes, this can be made optional, if there is a need for that. Jonathan On Thu, Mar 22, 2018 at 2:22 PM, Ruslan Bukin wrote: > Also can this be pluggable ? > It looks like it is optional device which means it can f

Re: svn commit: r330539 - in head/sys: amd64/amd64 amd64/include arm/include conf gdb i386/include mips/include powerpc/include sparc64/include

2018-03-07 Thread Jonathan Looney
On Tue, Mar 6, 2018 at 6:31 PM, Oliver Pinter wrote: > X-MFC-with: > > commit 27ac811b7acd31b1bdbf959fe49a957cdeabf780 > Author: bde > Date: Fri Mar 24 17:34:55 2017 + > ACK. Thanks! Jonathan ___ svn-src-head@freebsd.org mailing list https://li

Re: svn commit: r330407 - head/sys/dev/iicbus

2018-03-05 Thread Jonathan Looney
It looks like this is causing compilation failures: /home/jtl/head/sys/dev/iicbus/ds1672.c:147:20: error: use of undeclared identifier 'sc' clock_dbgprint_ts(sc->sc_dev, CLOCK_DBG_READ, ts); ^ /home/jtl/head/sys/dev/iicbus/ds1672.c:162:20: error: use of undeclared

Re: svn commit: r329171 - head/sys/amd64/amd64

2018-02-12 Thread Jonathan Looney
On Mon, Feb 12, 2018 at 12:27 PM, Jonathan T. Looney wrote: > Author: jtl > Date: Mon Feb 12 17:27:50 2018 > New Revision: 329171 > URL: https://svnweb.freebsd.org/changeset/base/329171 > > Log: > Mark the pages used for the initial page-table entries as wired. This > makes them consistent wi

Re: svn commit: r324179 - head/sys/netinet

2017-10-16 Thread Jonathan Looney
Hi Julien, I apologize for just getting to this, but your code just made it into my local tree. The non-INVARIANTS case looks incorrect. Because tw stays on the list, it can end up stuck at the front of the queue and block everything behind it. Personally, I would be more comfortable just panic'

Re: svn commit: r323942 - head/sys/net

2017-09-23 Thread Jonathan Looney
On Sat, Sep 23, 2017 at 4:37 AM, Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net> wrote: > > Then this makes no sense as we don’t do LRO if forwarding is enabled on > the machine; > https://svnweb.freebsd.org/base/head/sys/netinet/tcp_lro.c? > annotate=317390#l645 Yes, that is true. However, thi

Re: svn commit: r319720 - head/sys/dev/vt

2017-06-10 Thread Jonathan Looney
Hi Konstantin, On Sat, Jun 10, 2017 at 2:12 AM, Konstantin Belousov wrote: > No, acquire is only specified for loads, and release for stores. In other > words, on some hypothetical ll/sc architecture, the atomic_add_acq() > could be implemented as follows, in asm-pseudocode > atomic_add_acq(int

Re: svn commit: r319720 - head/sys/dev/vt

2017-06-09 Thread Jonathan Looney
Hi John, Konstantin, This crash occurs during system startup when we are trying to switch from having each write to the vt device do an immediate flush to using a callout-based asynchronous flushing mechanism. It appears the crash was caused by having the VDF_ASYNC flag set while the vd_timer_arm

Re: svn commit: r314216 - head/sys/x86/x86

2017-02-24 Thread Jonathan Looney
On Fri, Feb 24, 2017 at 3:19 PM, hiren panchasara < hi...@strugglingcoder.info> wrote: > On 02/24/17 at 06:56P, Jonathan T. Looney wrote: > > Author: jtl > > Date: Fri Feb 24 18:56:00 2017 > > New Revision: 314216 > > URL: https://svnweb.freebsd.org/changeset/base/314216 > > > > Log: > > We have

Re: svn commit: r314116 - head/sys/kern

2017-02-22 Thread Jonathan Looney
On Wed, Feb 22, 2017 at 8:18 PM, Jonathan T. Looney wrote: > Author: jtl > Date: Thu Feb 23 01:18:47 2017 > New Revision: 314116 > URL: https://svnweb.freebsd.org/changeset/base/314116 > > Log: > Fix a panic during boot caused by inadequate locking of some vt(4) driver > data structures. > >

Re: svn commit: r307082 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/conf sys/i386/conf sys/mips/conf sys/modules/cc sys/modules/khelp sys/netinet sys/netinet/tcp_stacks sys/pc98/conf s

2016-10-14 Thread Jonathan Looney
Thanks! Yes, that was clearly an error on my part, and your patch is an obvious solution. I committed it at r307336. Thanks again! Jonathan On Fri, Oct 14, 2016 at 8:01 PM, Shawn Webb wrote: > On Wed, Oct 12, 2016 at 02:16:42AM +, Jonathan T. Looney wrote: > > Author: jtl > > Date: Wed Oc

Re: svn commit: r307082 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/conf sys/i386/conf sys/mips/conf sys/modules/cc sys/modules/khelp sys/netinet sys/netinet/tcp_stacks sys/pc98/conf s

2016-10-12 Thread Jonathan Looney
On Wed, Oct 12, 2016 at 5:44 AM, Slawa Olhovchenkov wrote: > Do you perform estimate of performane impact of this overhead? > > Somewhat, but not precisely. It will depend on (at least) a few factors: a. The hardware * How fast is your CPU? Your L1/L2/L3 cache? * How many CPUs? * How sm

Re: svn commit: r307083 - head/sys/netinet

2016-10-11 Thread Jonathan Looney
On Tue, Oct 11, 2016 at 10:30 PM, Jonathan T. Looney wrote: > Author: jtl > Date: Wed Oct 12 02:30:33 2016 > New Revision: 307083 > URL: https://svnweb.freebsd.org/changeset/base/307083 > > Log: > Currently, when tcp_input() receives a packet on a session that matches a > TCPCB, it checks (so

Re: svn commit: r296387 - head

2016-03-07 Thread Jonathan Looney
On Fri, Mar 4, 2016 at 12:49 AM, Warner Losh wrote: > It's trivial so worth having. We should discuss what our "oldest > supported upgrade" release should be as currently it is 8.1. > > We put it to 8.1 based on Juniper wanted it for their operations. > Normally we'd set this closer to 9.0 or so

Re: svn commit: r289276 - in head/sys: conf kern netinet sys

2015-10-14 Thread Jonathan Looney
On 10/13/15, 10:33 PM, "Hiren Panchasara" wrote: >> >> I also replied to the review with style findings just now. >> >I'll ask Jonathan to look at it. Thanks for the comments. I'll prepare a cleanup patch which addresses this, and other comments which arrived after the commit. Jonathan __

Re: svn commit: r289276 - in head/sys: conf kern netinet sys

2015-10-14 Thread Jonathan Looney
On 10/14/15, 7:38 AM, "Gleb Smirnoff" wrote: >What if we write it down this way (thanks C11): > >struct tcpcb { > ... > union { >#ifdef TCPPCAP > struct { > struct mbufq t_inpkts; > struct mbufq t_outpkts; > }; >#e