Re: svn commit: r358133 - head/sys/vm

2020-02-19 Thread Joerg Sonnenberger
On Wed, Feb 19, 2020 at 10:34:23PM +, Jeff Roberson wrote: > Author: jeff > Date: Wed Feb 19 22:34:22 2020 > New Revision: 358133 > URL: https://svnweb.freebsd.org/changeset/base/358133 > > Log: > Silence a gcc warning about no return from a function that handles every > possible enum in a

Re: svn commit: r355569 - head/sys/amd64/linux32

2019-12-09 Thread Joerg Sonnenberger
On Mon, Dec 09, 2019 at 07:18:06PM +, John Baldwin wrote: > Author: jhb > Date: Mon Dec 9 19:18:05 2019 > New Revision: 355569 > URL: https://svnweb.freebsd.org/changeset/base/355569 > > Log: > Use 4 byte stack alignment instead of 8 byte. > > This was an old bug prior to r355373 and m

Re: svn commit: r343633 - head/usr.bin/shar

2019-02-02 Thread Joerg Sonnenberger
On Thu, Jan 31, 2019 at 03:29:03PM -0800, Bryan Drewery wrote: > On 1/31/19 3:21 PM, Bryan Drewery wrote: > > Author: bdrewery > > Date: Thu Jan 31 23:21:18 2019 > > New Revision: 343633 > > URL: https://svnweb.freebsd.org/changeset/base/343633 > > > > Log: > > Shar files may be seen as binary b

Re: svn commit: r331510 - in head: share/man/man4 sys/conf sys/dev/vmware/vmci sys/modules/vmware sys/modules/vmware/vmci

2018-03-25 Thread Joerg Sonnenberger
On Sun, Mar 25, 2018 at 09:03:20AM -0700, Rodney W. Grimes wrote: > Kirk would have to back me up on this, but my understanding of the > decisions that the UCB Regents legal staff came to was that each > file should have a complete copyright and license clause and any > thing less causes problems b

Re: svn commit: r329164 - in head: include sys/amd64/include sys/i386/include sys/mips/include sys/powerpc/include sys/sparc64/include

2018-02-12 Thread Joerg Sonnenberger
On Mon, Feb 12, 2018 at 02:48:14PM +, Warner Losh wrote: > Author: imp > Date: Mon Feb 12 14:48:14 2018 > New Revision: 329164 > URL: https://svnweb.freebsd.org/changeset/base/329164 > > Log: > We don't support gcc < 4.2.1, so varargs.h now is just #error > always. Unifdef for versions pri

Re: svn commit: r321969 - in head/sys/boot: arm/at91/libat91 arm/ixp425/boot2 i386/boot2

2017-08-03 Thread Joerg Sonnenberger
On Thu, Aug 03, 2017 at 05:53:43PM +1000, Bruce Evans wrote: > Freestanding versions (static and otherwise) cause problems with builtins. > -ffreestanding turns off all builtins. The static memcpy used to be > ifdefed so as to use __builtin_memcpy instead of the static one if the > compiler is gcc

Re: svn commit: r308563 - in head/lib: libgcc_eh libgcc_s

2016-11-11 Thread Joerg Sonnenberger
On Fri, Nov 11, 2016 at 11:28:08PM +, Ed Maste wrote: > Author: emaste > Date: Fri Nov 11 23:28:07 2016 > New Revision: 308563 > URL: https://svnweb.freebsd.org/changeset/base/308563 > > Log: > libcc_{s,eh}: build without SSP > > As in the gnu/lib/libgcc Makefile: > libgcc is link

Re: svn commit: r300375 - head/sys/arm/include

2016-05-21 Thread Joerg Sonnenberger
On Sat, May 21, 2016 at 04:52:38PM +, Ian Lepore wrote: > Author: ian > Date: Sat May 21 16:52:38 2016 > New Revision: 300375 > URL: https://svnweb.freebsd.org/changeset/base/300375 > > Log: > Adjust _ALIGNBYTES to the proper value for arm and armv6 arches. Modern > compilers can emit arm

Re: svn commit: r287217 - head/usr.sbin/syslogd

2015-08-28 Thread Joerg Sonnenberger
On Fri, Aug 28, 2015 at 10:17:56PM +1000, Bruce Evans wrote: > >-static void die(int); > >+static void die(int) __dead2; > > Since the function is static, it is very easy for the compiler to see > that it doesn't return. But the compiler can't tell if it is the *intention* that the function never

Re: svn commit: r243665 - head/sbin/dump

2012-11-29 Thread Joerg Sonnenberger
On Thu, Nov 29, 2012 at 02:01:47PM +0200, Konstantin Belousov wrote: > Also, being quite removed from the function definition, there is a chance > that some future modification would make the attribute a lie. At least clang enforces the correctness of the attribute. Joerg

Re: svn commit: r236582 - head/lib/libc/stdlib

2012-06-05 Thread Joerg Sonnenberger
On Wed, Jun 06, 2012 at 01:01:54AM +0400, Andrey Chernov wrote: > On Wed, Jun 06, 2012 at 06:11:01AM +1000, Bruce Evans wrote: > > This is essentially unusable (so a bad idea). Instead of unconditionally > > saving and restoring errno around calls to free(), portable POSIX code > > can soon use a

Re: svn commit: r236582 - head/lib/libc/stdlib

2012-06-05 Thread Joerg Sonnenberger
On Tue, Jun 05, 2012 at 06:31:14PM +0400, Andrey Chernov wrote: > BTW, if general consensus will be to track unpublished standard, I will > back out my change (in hope our malloc() maintainer will change free() to > directly save errno). The standard is quite irrelevant here. FreeBSD is free to

Re: svn commit: r236582 - head/lib/libc/stdlib

2012-06-05 Thread Joerg Sonnenberger
On Tue, Jun 05, 2012 at 05:13:05PM +0400, Andrey Chernov wrote: > On Tue, Jun 05, 2012 at 02:55:20PM +0200, Joerg Sonnenberger wrote: > > On Tue, Jun 05, 2012 at 04:39:01PM +0400, Andrey Chernov wrote: > > > Moreover, standard metion "unsuccessful call" case for free()

Re: svn commit: r236582 - head/lib/libc/stdlib

2012-06-05 Thread Joerg Sonnenberger
On Tue, Jun 05, 2012 at 04:39:01PM +0400, Andrey Chernov wrote: > Moreover, standard metion "unsuccessful call" case for free() where errno > state is totally undefined. ...which would be a programming mistake in first place and is valid as justification. Joerg __

Re: svn commit: r228435 - in head/libexec/rtld-elf: . amd64 arm i386 ia64 mips powerpc powerpc64 sparc64

2011-12-12 Thread Joerg Sonnenberger
On Mon, Dec 12, 2011 at 11:03:15AM +, Konstantin Belousov wrote: > To allow use of external references from the dispatch function, resolution > of the R_MACHINE_IRESOLVE relocations in PLT is postponed until GOT entries > for PLT are prepared, and normal resolution of the GOT entries is f