svn commit: r365967 - head/sbin/nvmecontrol

2020-09-21 Thread David Bright
Author: dab Date: Mon Sep 21 18:34:13 2020 New Revision: 365967 URL: https://svnweb.freebsd.org/changeset/base/365967 Log: Whitespace fix after r365948 MFC after:1 week Sponsored by: Dell EMC Isilon Modified: head/sbin/nvmecontrol/firmware.c Modified: head/sbin/nvmecontrol/firmwar

svn commit: r365948 - head/sbin/nvmecontrol

2020-09-21 Thread David Bright
Author: dab Date: Mon Sep 21 15:45:49 2020 New Revision: 365948 URL: https://svnweb.freebsd.org/changeset/base/365948 Log: Honor the FWUG value of some drives in nvmecontrol nvmecontrol tries to upload firmware in chunks as large as it thinks the device permits. It fails to take into acco

svn commit: r365946 - head/sys/dev/nvme

2020-09-21 Thread David Bright
Author: dab Date: Mon Sep 21 15:41:47 2020 New Revision: 365946 URL: https://svnweb.freebsd.org/changeset/base/365946 Log: Add an ioctl to get an NVMe device's maximum transfer size Reviewed by: imp, chuck Obtained from:Dell EMC Isilon MFC after:1 week Sponsored by: Dell

svn commit: r362634 - head/lib/libutil

2020-06-25 Thread David Bright
Author: dab Date: Thu Jun 25 21:34:43 2020 New Revision: 362634 URL: https://svnweb.freebsd.org/changeset/base/362634 Log: Add CAP_EVENT to pidfiles. CAP_EVENT was omitted on pidfiles (in pidfile_open()). There seems no reason why a process that creates and writes a pidfile cannot monit

svn commit: r360568 - head/sys/dev/nvme

2020-05-02 Thread David Bright
Author: dab Date: Sat May 2 20:47:58 2020 New Revision: 360568 URL: https://svnweb.freebsd.org/changeset/base/360568 Log: Fix various Coverity-detected errors in nvme driver This fixes several Coverity-detected errors in the nvme driver. CIDs addressed: 1008344, 1009377, 1009380, 1193

svn commit: r359717 - in head: etc/mtree sbin/nvmecontrol sbin/nvmecontrol/tests

2020-04-07 Thread David Bright
Author: dab Date: Tue Apr 7 20:26:42 2020 New Revision: 359717 URL: https://svnweb.freebsd.org/changeset/base/359717 Log: Add a basic test for nvmecontrol I recently made some bug fixes in nvmecontrol. It occurred to me that since nvmecontrol lacks any kyua tests, I should convert the in

svn commit: r359562 - in head/sbin/nvmecontrol: . modules/wdc

2020-04-02 Thread David Bright
Author: dab Date: Thu Apr 2 13:52:54 2020 New Revision: 359562 URL: https://svnweb.freebsd.org/changeset/base/359562 Log: Fix various Coverity-detected errors in nvmecontrol This fixes several Coverity-detected errors in nvmecontrol. While in here, a couple additional errors with shift/m

svn commit: r359129 - head/sys/cam/nvme

2020-03-19 Thread David Bright
Author: dab Date: Thu Mar 19 12:22:20 2020 New Revision: 359129 URL: https://svnweb.freebsd.org/changeset/base/359129 Log: Fix parameter reversal potentially causing buffer overrun. Two arguments were reversed in calls to cam_strvis() in nvme_da.c. This was found by a Coverity scan of thi

svn commit: r354854 - head/sys/sys

2019-11-19 Thread David Bright
Author: dab Date: Tue Nov 19 14:46:28 2019 New Revision: 354854 URL: https://svnweb.freebsd.org/changeset/base/354854 Log: Don't sanitize linker_set The assumptions of linker_set don't play nicely with AddressSanitizer. AddressSanitizer adds a 'redzone' of zeros around globals (includin

svn commit: r354808 - in head: contrib/openbsm/etc contrib/openbsm/sys/bsm sys/bsm sys/compat/freebsd32 sys/kern sys/security/audit sys/sys tests/sys/posixshm

2019-11-18 Thread David Bright
Author: dab Date: Mon Nov 18 13:31:16 2019 New Revision: 354808 URL: https://svnweb.freebsd.org/changeset/base/354808 Log: Jail and capability mode for shm_rename; add audit support for shm_rename Co-mingling two things here: * Addressing some feedback from Konstantin and Kyle re: ja

svn commit: r352756 - head/lib/libc/sys

2019-09-26 Thread David Bright
Author: dab Date: Thu Sep 26 16:13:17 2019 New Revision: 352756 URL: https://svnweb.freebsd.org/changeset/base/352756 Log: Correct mistake in MLINKS introduced in r352747 Messed up a merge conflict resolution and didn't catch that before commit. Sponsored by: Dell EMC Isilon Modifie

svn commit: r352751 - in head/sys: compat/freebsd32 kern sys

2019-09-26 Thread David Bright
Author: dab Date: Thu Sep 26 15:41:10 2019 New Revision: 352751 URL: https://svnweb.freebsd.org/changeset/base/352751 Log: sysent: regenerate after r352747. Sponsored by: Dell EMC Isilon Modified: head/sys/compat/freebsd32/freebsd32_syscall.h head/sys/compat/freebsd32/freebsd32_syscall

svn commit: r352747 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys tests/sys/posixshm usr.bin/truss

2019-09-26 Thread David Bright
Author: dab Date: Thu Sep 26 15:32:28 2019 New Revision: 352747 URL: https://svnweb.freebsd.org/changeset/base/352747 Log: Add an shm_rename syscall Add an atomic shm rename operation, similar in spirit to a file rename. Atomically unlink an shm from a source path and link it to a desti

Re: svn commit: r345009 - head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini

2019-03-11 Thread David Bright
On Mar 11, 2019, at 9:26 AM, David Bright wrote: > > Author: dab > Date: Mon Mar 11 14:26:45 2019 > New Revision: 345009 > URL: https://svnweb.freebsd.org/changeset/base/345009 > > Log: > Fix a scribbler in the PMS driver. Oops. Reviewed by:Anton Rang htt

svn commit: r345009 - head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini

2019-03-11 Thread David Bright
Author: dab Date: Mon Mar 11 14:26:45 2019 New Revision: 345009 URL: https://svnweb.freebsd.org/changeset/base/345009 Log: Fix a scribbler in the PMS driver. The ESGL bit was left uninitialized when executing the REPORT LUNS ioctl. This could allow a zeroed data buffer to be treated as a

svn commit: r344553 - head/sys/dev/asmc

2019-02-25 Thread David Bright
Author: dab Date: Mon Feb 25 21:59:01 2019 New Revision: 344553 URL: https://svnweb.freebsd.org/changeset/base/344553 Log: asmc: Add support for Mac mini 2,1 PR: 235798 Submitted by: Trev Reported by: Trev MFC after:1 week Modified: head/sys/dev/asmc/asmc.c head/

svn commit: r344473 - head/sys/dev/pms/RefTisa/tisa/sassata/sas/ini

2019-02-22 Thread David Bright
Author: dab Date: Fri Feb 22 18:43:27 2019 New Revision: 344473 URL: https://svnweb.freebsd.org/changeset/base/344473 Log: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c A pointer is first tested for NULL. If non-NULL, another pointer is set equal to

svn commit: r344470 - head/usr.sbin/newsyslog

2019-02-22 Thread David Bright
Author: dab Date: Fri Feb 22 15:31:50 2019 New Revision: 344470 URL: https://svnweb.freebsd.org/changeset/base/344470 Log: Fix several Coverity-detected issues in newsyslog. - CID 1394815, CID 1305673: Dereference before null check - memory was allocated and the allocation checked for N

Re: svn commit: r344389 - head/usr.sbin/newsyslog

2019-02-22 Thread David Bright
) (and thus are already inferred as __dead2 by any compiler > written in this millenium) I’ve reverted (r344468) the two commits that contained the memory leak fixes at issue. Thanks for the feedback. -- David Bright d...@freebsd.org ___ svn-s

svn commit: r344468 - head/usr.sbin/newsyslog

2019-02-22 Thread David Bright
Author: dab Date: Fri Feb 22 14:59:40 2019 New Revision: 344468 URL: https://svnweb.freebsd.org/changeset/base/344468 Log: Revert r344389 & r343906 - Fix Coverity errors in newsyslog It was pointed out that a couple of the "memory leak" CIDs that I fixed were arguably Coverity errors rath

svn commit: r344389 - head/usr.sbin/newsyslog

2019-02-20 Thread David Bright
Author: dab Date: Wed Feb 20 22:05:44 2019 New Revision: 344389 URL: https://svnweb.freebsd.org/changeset/base/344389 Log: Complete fix for CID 1007454, CID 1007453: Resource leak in newsyslog The result of a strdup() was stored in a global variable and not freed before program exit. This

svn commit: r344024 - head/sys/cam/scsi

2019-02-11 Thread David Bright
Author: dab Date: Mon Feb 11 22:09:26 2019 New Revision: 344024 URL: https://svnweb.freebsd.org/changeset/base/344024 Log: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c In `probedone()`, for the `PROBE_REPORT_LUNS` case, all paths that fall to the bottom of the case set `lp`

svn commit: r343906 - head/usr.sbin/newsyslog

2019-02-08 Thread David Bright
Author: dab Date: Fri Feb 8 13:54:16 2019 New Revision: 343906 URL: https://svnweb.freebsd.org/changeset/base/343906 Log: Fix several Coverity-detected issues in newsyslog. - CID 1394815, CID 1305673: Dereference before null check - memory was allocated and the allocation checked for N

Re: svn commit: r343906 - head/usr.sbin/newsyslog

2019-02-08 Thread David Bright
On Feb 8, 2019, at 7:54 AM, David Bright wrote: > > Author: dab > Date: Fri Feb 8 13:54:16 2019 > New Revision: 343906 > URL: https://svnweb.freebsd.org/changeset/base/343906 > > Log: > Fix several Coverity-detected issues in newsyslog. Oops: Diffe

svn commit: r342822 - head/sys/dev/asmc

2019-01-06 Thread David Bright
Author: dab Date: Sun Jan 6 23:43:12 2019 New Revision: 342822 URL: https://svnweb.freebsd.org/changeset/base/342822 Log: asmc: Add support for Mac mini 4,1 (Mid-2010) MFC after:1 week Modified: head/sys/dev/asmc/asmc.c head/sys/dev/asmc/asmcvar.h Modified: head/sys/dev/asmc/asmc

svn commit: r342770 - head/sys/dev/asmc

2019-01-04 Thread David Bright
Author: dab Date: Fri Jan 4 18:21:49 2019 New Revision: 342770 URL: https://svnweb.freebsd.org/changeset/base/342770 Log: asmc: Patch to add MacBook Pro 9,2 support PR: 211513 Submitted by: William Theesfeld Jr Reported by: William Theesfeld Jr MFC after:1 week Modi

svn commit: r342218 - head/sys/dev/asmc

2018-12-19 Thread David Bright
Author: dab Date: Wed Dec 19 16:45:37 2018 New Revision: 342218 URL: https://svnweb.freebsd.org/changeset/base/342218 Log: asmc: Add support for MacPro1,1 PR: 203431 Submitted by: j...@alisa.org & holin...@saunalahti.fi Reported by: j...@alisa.org MFC after:1 week Modi

svn commit: r342171 - head/sys/dev/asmc

2018-12-17 Thread David Bright
Author: dab Date: Mon Dec 17 17:21:45 2018 New Revision: 342171 URL: https://svnweb.freebsd.org/changeset/base/342171 Log: asmc: Add support for mid-2011 Macmini 5,2 PR: 225911 Submitted by: trev Reported by: trev MFC after:1 week Modified: head/sys/dev/asmc/asmc.c

svn commit: r341988 - head/sys/dev/asmc

2018-12-12 Thread David Bright
Author: dab Date: Wed Dec 12 13:43:55 2018 New Revision: 341988 URL: https://svnweb.freebsd.org/changeset/base/341988 Log: asmc: Add Support for Macbook Pro 8,1 PR: 217505 Submitted by: John O. Brickley , updated by Maciej Pasternacki Reported by: John O. Brickley MFC af

svn commit: r341820 - head/sys/dev/asmc

2018-12-11 Thread David Bright
Author: dab Date: Tue Dec 11 16:35:59 2018 New Revision: 341820 URL: https://svnweb.freebsd.org/changeset/base/341820 Log: asmc: Add Support for MacBookAir 7,1 and 7,2 PR: 226172 Submitted by: James Wright Reported by: James Wright MFC after:1 week Differential Revi

svn commit: r341806 - head/share/vt/keymaps

2018-12-10 Thread David Bright
Author: dab Date: Tue Dec 11 02:14:40 2018 New Revision: 341806 URL: https://svnweb.freebsd.org/changeset/base/341806 Log: Add uk.macbook.kbd keymap (vt) PR: 215185 Submitted by: James Wright Reported by: James Wright Reviewed by: emaste (earlier version) MFC after:

svn commit: r341068 - head/tests/sys/kqueue/libkqueue

2018-11-27 Thread David Bright
Author: dab Date: Tue Nov 27 15:12:34 2018 New Revision: 341068 URL: https://svnweb.freebsd.org/changeset/base/341068 Log: Make whitespace more consistent in libkqueue tests. After r337820, which "corrected" some spaces-instead-of-tab whitespace issues in the libkqueue tests, jmg@ pointed

svn commit: r337820 - head/tests/sys/kqueue/libkqueue

2018-08-14 Thread David Bright
Author: dab Date: Tue Aug 14 20:26:54 2018 New Revision: 337820 URL: https://svnweb.freebsd.org/changeset/base/337820 Log: Fix a couple whitespace errors in r337814. Reported by: Renato Botelho MFC after:3 days X-MFC-with: r337814 Sponsored by: Dell EMC Modified: head/tests

svn commit: r337814 - head/tests/sys/kqueue/libkqueue

2018-08-14 Thread David Bright
Author: dab Date: Tue Aug 14 19:31:06 2018 New Revision: 337814 URL: https://svnweb.freebsd.org/changeset/base/337814 Log: Fix several (more) memory leaks. A follow-up to r337812 to catch a couple more memory leaks that should have been included in that change. Reported by: Coverity

svn commit: r337812 - in head: sys/dev/netmap tests/sys/kqueue/libkqueue

2018-08-14 Thread David Bright
Author: dab Date: Tue Aug 14 19:12:45 2018 New Revision: 337812 URL: https://svnweb.freebsd.org/changeset/base/337812 Log: Fix several memory leaks. The libkqueue tests have several places that leak memory by using an idiom like: puts(kevent_to_str(kevp)); Rework to save the poi

svn commit: r336905 - head/tests/sys/kqueue/libkqueue

2018-07-30 Thread David Bright
Author: dab Date: Mon Jul 30 14:21:49 2018 New Revision: 336905 URL: https://svnweb.freebsd.org/changeset/base/336905 Log: Correct possible misleading error message in kqtest. ian@ pointed out that in the test_abstime() function time(NULL) is used twice; once in an "if" test and again in

svn commit: r336802 - head/tests/sys/kqueue/libkqueue

2018-07-27 Thread David Bright
Author: dab Date: Sat Jul 28 02:53:36 2018 New Revision: 336802 URL: https://svnweb.freebsd.org/changeset/base/336802 Log: Fix compilation error on some arches after r336761 & r336781. Another cast for printing an intmax_t was needed in a kqueue test for some arches. Pointy-hat: me

svn commit: r336781 - head/tests/sys/kqueue/libkqueue

2018-07-27 Thread David Bright
Author: dab Date: Fri Jul 27 20:14:58 2018 New Revision: 336781 URL: https://svnweb.freebsd.org/changeset/base/336781 Log: Fix compilation error on some arches after r336761. A cast for printing an intmax_t was needed in a kqueue test for some arches. MFC after:1 week X-MFC-wit

svn commit: r336761 - in head: lib/libc/sys sys/kern tests/sys/kqueue/libkqueue

2018-07-27 Thread David Bright
Author: dab Date: Fri Jul 27 13:49:17 2018 New Revision: 336761 URL: https://svnweb.freebsd.org/changeset/base/336761 Log: Allow a EVFILT_TIMER kevent to be updated. If a timer is updated (re-added) with a different time period (specified in the .data field of the kevent), the new time pe

svn commit: r336457 - head/sys/sys

2018-07-18 Thread David Bright
Author: dab Date: Wed Jul 18 13:04:03 2018 New Revision: 336457 URL: https://svnweb.freebsd.org/changeset/base/336457 Log: Make the definition of struct kevent in event.h match what the man page for kevent(2) says. This is a trivial comment-only fix. The man page for kevent(2) gives the

svn commit: r336186 - head/sys/sys

2018-07-10 Thread David Bright
Author: dab Date: Wed Jul 11 02:09:11 2018 New Revision: 336186 URL: https://svnweb.freebsd.org/changeset/base/336186 Log: Address some (although not all) style(9) issues in event.h after r335776. Reported by: bde@ MFC after:1 day Sponsored by: Dell EMC Modified: head/sys/sys/ev

svn commit: r335776 - head/sys/sys

2018-06-28 Thread David Bright
Author: dab Date: Thu Jun 28 20:37:17 2018 New Revision: 335776 URL: https://svnweb.freebsd.org/changeset/base/335776 Log: Fix compilation error in r335765 under gcc 4.2.1. The anonymous object initialization introduced in r335765 was acceptable to clang, but not gcc 4.2.1. Fix it for bot

svn commit: r335765 - head/sys/sys

2018-06-28 Thread David Bright
Author: dab Date: Thu Jun 28 17:01:04 2018 New Revision: 335765 URL: https://svnweb.freebsd.org/changeset/base/335765 Log: Remove potential identifier conflict in the EV_SET macro. PR43905 pointed out a problem with the EV_SET macro if the passed struct kevent pointer were specified with

svn commit: r331015 - head/etc/rc.d

2018-03-15 Thread David Bright
Author: dab Date: Thu Mar 15 18:29:56 2018 New Revision: 331015 URL: https://svnweb.freebsd.org/changeset/base/331015 Log: Modify rc.d/fsck to handle new status from fsck/fsck_ffs r328013 introduced a new error code from fsck_ffs that indicates that it could not completely fix the file sy

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-10 Thread David Bright
uent mount would fail because the filesystem was not clean, and *then* the boot would stop and drop to single user. -- David Bright d...@freebsd.org ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To u

Re: svn commit: r328013 - head/sbin/fsck_ffs

2018-03-09 Thread David Bright
checker, but I think fsck_ffs is the only one that currently implements such a flag. -- David Bright d...@freebsd.org ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r330245 - in head/usr.sbin/pw: . tests

2018-03-01 Thread David Bright
Author: dab Date: Thu Mar 1 17:47:28 2018 New Revision: 330245 URL: https://svnweb.freebsd.org/changeset/base/330245 Log: Allow the "@" and "!" characters in passwd file GECOS fields. Two PRs (152084 & 210187) request allowing the "@" and/or "!" characters in the passwd file GECOS field.

svn commit: r330085 - head/sbin/dhclient

2018-02-27 Thread David Bright
Author: dab Date: Tue Feb 27 21:59:23 2018 New Revision: 330085 URL: https://svnweb.freebsd.org/changeset/base/330085 Log: dhclient violates RFC2131 when sending early DHCPREQUEST message to re-obtain old IP When dhclient first starts, if an old IP address exists in the dhclient.leases f

svn commit: r330034 - head/usr.sbin/syslogd

2018-02-26 Thread David Bright
Author: dab Date: Mon Feb 26 19:27:59 2018 New Revision: 330034 URL: https://svnweb.freebsd.org/changeset/base/330034 Log: Fix two memory leaks in syslogd A memory leak in syslogd for processing of forward actions was reported. This modification adapts the patch submitted with that bug

svn commit: r330027 - head/sys/libkern

2018-02-26 Thread David Bright
Author: dab Date: Mon Feb 26 18:23:36 2018 New Revision: 330027 URL: https://svnweb.freebsd.org/changeset/base/330027 Log: iconv uses strlen directly on user supplied memory `iconv_sysctl_add` from `sys/libkern/iconv.c` incorrectly limits the size of user strings, such that several out of

svn commit: r328013 - head/sbin/fsck_ffs

2018-01-15 Thread David Bright
Author: dab Date: Mon Jan 15 19:25:11 2018 New Revision: 328013 URL: https://svnweb.freebsd.org/changeset/base/328013 Log: Exit fsck_ffs with non-zero status when file system is not repaired. When the fsck_ffs program cannot fully repair a file system, it will output the message PLEASE RE

svn commit: r323252 - head/libexec/getty

2017-09-06 Thread David Bright
Author: dab Date: Thu Sep 7 00:20:17 2017 New Revision: 323252 URL: https://svnweb.freebsd.org/changeset/base/323252 Log: Add a new getty/gettytab capability to generate an initial message dynamically. This modification adds a new gettytab(5) option (iM) to specify a program to run that

svn commit: r318960 - in head/usr.sbin/newsyslog: . tests

2017-05-26 Thread David Bright
Author: dab Date: Fri May 26 16:36:30 2017 New Revision: 318960 URL: https://svnweb.freebsd.org/changeset/base/318960 Log: Add newsyslog capability to write RFC5424 compliant rotation message. This modification adds the capability to newsyslog to write the rotation message in a format tha

svn commit: r309019 - head/share/misc

2016-11-22 Thread David Bright
csjp [label="Christian S.J. Peron\nc...@freebsd.org\n2004/05/04"] +dab [label="David Bright\n...@freebsd.org\n2016/10/24"] das [label="David Schultz\n...@freebsd.org\n2003/02/21"] davide [label="Davide Italiano\ndav...@freebsd.org\n2012/01/27"] dchagi