Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Ben Kaduk
On Wed, Nov 14, 2012 at 11:27 AM, Eitan Adler wrote: > On 14 November 2012 11:12, Ben Kaduk wrote: >> Andre, they are used (for better or for worse) in a multi-site >> database synchronization protocol that currently works portably across >> operating systems. Removing

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Ben Kaduk
ber :) Andre, they are used (for better or for worse) in a multi-site database synchronization protocol that currently works portably across operating systems. Removing them would change the semantics of that protocol in a subtle way that might introduce breakage. -Ben Kaduk __

Re: svn commit: r241933 - head/sys/conf

2012-11-12 Thread Ben Kaduk
On Mon, Nov 12, 2012 at 7:47 PM, David O'Brien wrote: > On Mon, Nov 12, 2012 at 04:29:07PM -0800, David O'Brien (@FreeBSD) wrote: >> $ diff -Bbw files.mips.r241680,sorted files.mips.r241933,sorted | egrep -v >> '^(\+|-|@@)' | wc -l >> 43 > > Sorry, should have better ensured all input lines

Re: svn commit: r242934 - head/sys/dev/xen/netback

2012-11-12 Thread Ben Kaduk
t; /** > - * Writes an error message to buffer if cond is false, and returns true > - * iff the assertion failed. Note the implied parameters buffer and > + * Writes an error message to buffer if cond is false > + * Note the implied parameters buffer and At risk of being Bruce, are

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Ben Kaduk
I do not wish to belabor the point; we all have better things to do with our time. Hopefully this is my last message on the topic. On Tue, Nov 6, 2012 at 6:10 PM, Attilio Rao wrote: > The point is that KPI/KBI of -CURRENT can change as long as > __FreeBSD_version is bumped (and if you really wa

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Ben Kaduk
On Tue, Nov 6, 2012 at 5:53 PM, Attilio Rao wrote: > On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk wrote: >> On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov >> wrote: > Hi Ben, > no, ports/thirdy part should be adjusted on the -CURRENT ABI. > Leaving MPSAFE would ju

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Ben Kaduk
quire Giant if needed. */ It seems that removing the definition of MPSAFE causes out-of-tree filesystem modules to not build. Perhaps a definition can remain for some period to allow a smoother transition? Conditional on __FreeBSD_Version is the proper fix, of course, but takes longer to get everywhere.

Re: svn commit: r238962 - head/sys/dev/ath/ath_rate/sample

2012-07-31 Thread Ben Kaduk
On Tue, Jul 31, 2012 at 8:18 PM, Adrian Chadd wrote: > --- head/sys/dev/ath/ath_rate/sample/sample.c Tue Jul 31 23:54:15 2012 > (r238961) > +++ head/sys/dev/ath/ath_rate/sample/sample.c Wed Aug 1 00:18:02 2012 > (r238962) > @@ -504,7 +504,7 @@ ath_rate_findrate(struct ath_soft

Re: svn commit: r232496 - head/share/man/man4

2012-03-04 Thread Ben Kaduk
On Sun, Mar 4, 2012 at 2:32 PM, Eitan Adler wrote: > On Sun, Mar 4, 2012 at 1:52 PM, John Baldwin wrote: >> Can you do a forced commit to add a commit log of the actual change please? > > I don't know of any real way to do forced commits so does the > following look acceptable? You should be abl

Re: svn commit: r232473 - in head: share/mk sys/conf

2012-03-03 Thread Ben Kaduk
On Sat, Mar 3, 2012 at 3:03 PM, Doug Barton wrote: > On 03/03/2012 10:58, Dimitry Andric wrote: >> However, since it is apparently an expected use case to build using old >>   .mk files, > > Expected how? It shouldn't happen if you're building in /usr/src. > Wouldn't it be better to track down the

Re: svn commit: r232238 - in head: share/man/man4 sys/dev/e1000 sys/dev/ixgbe sys/dev/netmap sys/dev/re sys/net tools/tools/netmap

2012-02-27 Thread Ben Kaduk
ve unfortunately require an API change, so while >     at it add a version field and some spares to the ioctl() argument >     to help detect mismatches. Is it worth bumping __FreeBSD_version? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list htt

Re: svn commit: r230207 - in head/sys: netinet sys

2012-01-19 Thread Ben Kaduk
in) that instead uses the IN_CLASSA() family of macros, so I could preserve compatibility. But if you go and remove those too, I am screwed. Please don't just assume that no one is using classful addressing and remove things ahead of a reasonable deprecation schedule. -Ben Kaduk __

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2012-01-01 Thread Ben Kaduk
On Fri, Dec 30, 2011 at 3:04 PM, Glen Barber wrote: > On Fri, Dec 30, 2011 at 07:54:44PM +, Alexey Dokuchaev wrote: >> On Fri, Dec 30, 2011 at 02:43:22PM -0500, Ben Kaduk wrote: >> > On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein wrote: >> > > -            

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2012-01-01 Thread Ben Kaduk
On Sun, Jan 1, 2012 at 12:33 PM, Ulrich Spoerlein wrote: > On Fri, 2011-12-30 at 14:43:22 -0500, Ben Kaduk wrote: >> On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein wrote: >> > Modified: head/usr.sbi

Re: svn commit: r228992 - in head/usr.bin: csup finger fstat indent ipcs lex limits locate/locate login mail make man ncplogin netstat pr rpcgen rpcinfo systat talk tip/tip top vgrind xlint/lint1 xlin

2011-12-30 Thread Ben Kaduk
in a reasonable amount Merriam-Webster thinks it's "acknowledgment", but I always have to double-check this one. >  * of time >  */ >  void > > Modified: head/usr.bin/yacc/NEW_FEATURES > ==

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2011-12-30 Thread Ben Kaduk
e_sz, const char *archive_dir, > @@ -1612,7 +1612,7 @@ gen_clasiclog_fname(char *fname, size_t >  } > >  /* > - * Delete a rotated logfiles, when using clasic filenames. > + * Delete a rotated logfiles, when using classic filenames. "a logfiles" is inconsistent. Without looking up the implementation, I'm going to guess that "a rotated logfile" is correct. >  */ >  static void >  delete_clasiclog(const char *archive_dir, const char *namepart, int numlog_c) > > Modified: head/usr.sbin/ntp/doc/ntp.conf.5 > == > --- head/usr.sbin/ntp/doc/ntp.conf.5    Fri Dec 30 10:45:00 2011         > (r228989) > +++ head/usr.sbin/ntp/doc/ntp.conf.5    Fri Dec 30 10:58:14 2011         > (r228990) > @@ -783,7 +783,7 @@ The remaining files are necessary only f >  Autokey protocol. >  .Pp >  Certificates imported from OpenSSL or public certificate > -authorities have certian limitations. > > *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** Hmm, that's unfortunate. Pulling out a svn client, it looks like: usr.sbin/pkg_install/lib/plist.c changes a misspelled form to the still-misspelled "occurrance" (not occurrence) Thanks for doing this cleanup along with the encoding cleanup! -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r228143 - in head: . share/mk tools/build/options

2011-12-20 Thread Ben Kaduk
; "The common case" of what, though? "People using src.conf", or "people rebuilding world", or just "people using FreeBSD"? The answer may change, depending. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list h

Re: svn commit: r228571 - in head: . lib/libc/net sbin/ifconfig share/man/man4 sys/net sys/netinet sys/netinet6 sys/sys

2011-12-16 Thread Ben Kaduk
asymmetric routing > +.\"of incoming and outgoing traffic, and thus combining it with > +.\".Xr pfsync 4 > +.\"is dangerous, because this creates a race condition between > +.\"balanced routers and a host they are serving. > +.\"Imagine an incoming pa

Re: svn commit: r227797 - head/share/mk

2011-11-22 Thread Ben Kaduk
2011/11/22 Rui Paulo : > On 2011/11/22, at 21:33, Dag-Erling Smørgrav wrote: > >> Rui Paulo writes: >>> With this change, I can no longer update a FreeBSD 9.0-current system >>> from June 2010 to FreeBSD 10.0. I suspect I'm not the only one. >> >> Sorry, my mind reader is broken at the moment, so

Re: svn commit: r227778 - head/sys/net

2011-11-20 Thread Ben Kaduk
modules ever want to use that ABI, something that we just ran into with vm_page_t and friends and had a long thread on -current about. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscr

Re: svn commit: r226635 - head/usr.bin/tar

2011-10-22 Thread Ben Kaduk
.googlecode.com. > > MFC after: 3 days Thanks! (Your earlier mail was unclear whether you would actually get to it, so I had been planning to take a look, but hadn't had time, yet.) -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http:/

Re: svn commit: r224475 - head/usr.sbin/jail

2011-07-28 Thread Ben Kaduk
ges. Per rwatson's comment on the other jail.8 thread we've got going, we might recommend that the separate file system for a jail might also be mounted nosuid, which would close off this class of attack. I don't have a good sense of whether suid applications are frequently useful/

Re: svn commit: r223722 - in head/sys: kern sys

2011-07-02 Thread Ben Kaduk
n be used by drivers to add ioctls to the *.init and >  *.lock devices. This commit breaks the ttydevsw ABI, since this Aren't __FreeBSD_version bumps cheap, these days? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.o

Re: svn commit: r223380 - head/sys/dev/xl

2011-06-21 Thread Ben Kaduk
al operation so we can afford > - * to make it a function. > + * to make it a function.  Spress warning when card gone. ^^^u -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/s

Re: svn commit: r223262 - in head: cddl/contrib/opensolaris/lib/libdtrace/common contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config contrib/binutils/ld contrib/binutils/opcodes cont

2011-06-18 Thread Ben Kaduk
gt; 4)) & 0x0F0F0F0F0F0F0F0FULL; > @@ -827,6 +827,8 @@ dt_popc(ulong_t x) >        x = x + (x >> 16); >        x = x + (x >> 32); >        return (x & 0x7F); > +#else > +# warning need td_popc() implementation We seem to still be in dt_popc(), here. -Ben Kaduk >  #endif >  } > ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r219667 - head/usr.sbin/bsdinstall/partedit

2011-03-15 Thread Ben Kaduk
ther that > is wise to others. It's a little bit of a pain on the implementation side, > since you can't turn it on from newfs, but that isn't a serious obstacle. I suspect the consensus of people like -arch and -fs will be that the burn-in time before it is considere

Re: svn commit: r219573 - head/sbin/geom/class/part

2011-03-12 Thread Ben Kaduk
es backward compatibility" is more standard English usage. Not knowing much about the EBR scheme, I would also guess that "for partition names in the EBR scheme" is what is intended here, but that would be something of a guess. > +of the EBR scheme. Also it makes impossible any

Re: svn commit: r217097 - in head/sys: amd64/include arm/include i386/include ia64/include mips/include powerpc/include sparc64/include sun4v/include

2011-01-07 Thread Ben Kaduk
   AT_STACKPROT    23      /* Initial stack protection. */ > > -#define        AT_COUNT        22      /* Count of defined aux entry types. > */ > +#define        AT_COUNT        24      /* Count of defined aux entry types. > */ Is there a reason to skip 22? -Ben Kaduk _

Re: svn commit: r216591 - head

2010-12-20 Thread Ben Kaduk
                        [6] >         There is of course the issue of when a file is erroneously listed in ObsoleteFiles.inc and deleted by delete-old. The previous order would have installworld come in and correct the error, but the current version leaves that file deleted. So there is someth

Re: svn commit: r216212 - head/sys/sys

2010-12-05 Thread Ben Kaduk
benefit of ports such as opencity and inkscape that have workarounds for >  the lack of a log2() in the base system. Awesome; thanks! -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe

Re: svn commit: r215178 - in head: lib/libc/sys sys/kern sys/sys

2010-11-12 Thread Ben Kaduk
will not need to be recompiled, but I haven't yet checked. That said, I hear __FreeBSD_version bumps are cheap. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r215176 - in head: . share/man/man9

2010-11-12 Thread Ben Kaduk
;   svn r147332 (by jeff): "Don't make vgonel() globally visible". >  While here, specify the vnode locking scheme for vgone(). Thanks! (I was going to send a follow-up to -hackers in a few days, otherwise.) -Ben Kaduk ___

Re: svn commit: r213643 - head/usr.bin/ar

2010-10-08 Thread Ben Kaduk
ers to zero and >  modes to 0644.  Useful for producing libraries that are >  bitwise identical across multiple build runs. Thanks! Has anyone looked at the feasibility of setting AR?=ar -D in sys.mk? I will probably try this when I get my scr

Re: svn commit: r213398 - head/bin/rm

2010-10-04 Thread Ben Kaduk
ich this could happen, the easiest to see of which would be if a filesystem like ZFS was used as the backing store for the fileserver partitions. > > also: is this really something belonging into a BUGS section? personally i > think the BUGS section in rm(1) sho

Re: svn commit: r211650 - head/share/man/man4

2010-08-22 Thread Ben Kaduk
be used on the > +specified device. > +Non-zero value enables I/O space register mapping. "Non-zero values enable" or "A non-zero value enables" is better. > +For controllers that have no I/O space register mapping this tunable > +should be set to 0 to use I/O

Re: svn commit: r210065 - head/usr.bin/gcore

2010-07-14 Thread Ben Kaduk
the > +behavior of the application is fully understood and the fallouts can > +be easily controlled. >  .It Fl s >  Stop the process while gathering the core image, and resume it >  when done. Still has the style bug of not starting new

Re: svn commit: r207709 - head/sys/dev/iwn

2010-05-06 Thread Ben Kaduk
passive to active scans. Basicly disable it by increasing the > amount packets to be received to an amount which can't be reached > during dwell times. Is this expected to fix the firmware errors that have cropped up periodically for me? (Sorry for the lack of useful bug

Re: svn commit: r207283 - head/usr.bin/gzip

2010-04-27 Thread Ben Kaduk
ead of "files that are". The new version has a comma splice, though -- the comma in "32-bit integer, therefore" should be replaced with either a semicolon or a full stop. I would probably also put in two "the"s in the text following this change -- "the -l option

Re: svn commit: r203825 - head/share/man/man9

2010-02-13 Thread Ben Kaduk
nformation about witness(9) to the section about interactions, and >  expand 'contexts' table. > > Modified: >  head/share/man/man9/locking.9 Hi Edward, Please consider looking at docs/136918 and docs/134074 (which both have patches to loc