svn commit: r361239 - head

2020-05-18 Thread Kyle Evans
Author: kevans Date: Tue May 19 03:19:01 2020 New Revision: 361239 URL: https://svnweb.freebsd.org/changeset/base/361239 Log: Belated RELNOTES entry for r361238 This may get revised later if the larger change lands, but we should note this. Modified: head/RELNOTES Modified: head/RELNO

svn commit: r361238 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2020-05-18 Thread Kyle Evans
Author: kevans Date: Tue May 19 02:41:05 2020 New Revision: 361238 URL: https://svnweb.freebsd.org/changeset/base/361238 Log: zfs: reject read(2) of a dirfd with EISDIR This is independent of the recently-discussed global change, which is still in review/discussion stage. This is eff

svn commit: r361237 - head/tests/sys/netinet

2020-05-18 Thread Li-Wen Hsu
Author: lwhsu Date: Tue May 19 02:07:08 2020 New Revision: 361237 URL: https://svnweb.freebsd.org/changeset/base/361237 Log: Temporarily disable test case causes kernel panic in CI: - sys.netinet.so_reuseport_lb_test.basic_ipv6 PR: 246560 Sponsored by: The FreeBSD Foundatio

svn commit: r361232 - head/sys/powerpc/aim

2020-05-18 Thread Justin Hibbits
Author: jhibbits Date: Tue May 19 01:06:31 2020 New Revision: 361232 URL: https://svnweb.freebsd.org/changeset/base/361232 Log: powerpc/mmu: Don't use the cache instructions to zero pages A page (even physmem) can be marked as cache-inhibited. Attempting to use 'dcbz' to zero a page mapp

svn commit: r361231 - head/sys/netinet

2020-05-18 Thread Mike Karels
Author: karels Date: Tue May 19 01:05:13 2020 New Revision: 361231 URL: https://svnweb.freebsd.org/changeset/base/361231 Log: Fix NULL-pointer bug from r361228. Note that in_pcb_lport and in_pcb_lport_dest can be called with a NULL local address for IPv6 sockets; handle it. Found by syzk

svn commit: r361230 - head/contrib/blacklist/bin

2020-05-18 Thread Ed Maste
Author: emaste Date: Tue May 19 00:15:19 2020 New Revision: 361230 URL: https://svnweb.freebsd.org/changeset/base/361230 Log: blacklistd.conf.5: typo/grammar fixes PR: 246467 Submitted by: Mike Lempriere Modified: head/contrib/blacklist/bin/blacklistd.conf.5 Modified: head/c

svn commit: r361229 - head/tests/sys/geom/class/multipath

2020-05-18 Thread Li-Wen Hsu
Author: lwhsu Date: Mon May 18 23:43:48 2020 New Revision: 361229 URL: https://svnweb.freebsd.org/changeset/base/361229 Log: Revert 357780, `dtrace -c` has been fixed in head` PR: 244053 Sponsored by: The FreeBSD Foundation Modified: head/tests/sys/geom/class/multipath/faillo

svn commit: r361228 - in head/sys: netinet netinet6

2020-05-18 Thread Mike Karels
Author: karels Date: Mon May 18 22:53:12 2020 New Revision: 361228 URL: https://svnweb.freebsd.org/changeset/base/361228 Log: Allow TCP to reuse local port with different destinations Previously, tcp_connect() would bind a local port before connecting, forcing the local port to be unique

Re: svn commit: r361136 - head/sys/fs/ext2fs

2020-05-18 Thread Pedro Giffuni
... On 17/05/2020 09:52, Fedor Uporov wrote: Author: fsu Date: Sun May 17 14:52:54 2020 New Revision: 361136 URL: https://svnweb.freebsd.org/changeset/base/361136 Log: Add BE architectures support. Author of most initial version: pfg (https://reviews.freebsd.org/D23259) Reviewe

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 23:09, Ian Lepore wrote: > > On Mon, 2020-05-18 at 23:01 +0200, Michael Tuexen wrote: >>> On 18. May 2020, at 22:48, Ian Lepore wrote: >>> >>> On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: > Sure. You can certainly ignore user reports corresponding to >

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Ian Lepore
On Mon, 2020-05-18 at 23:01 +0200, Michael Tuexen wrote: > > On 18. May 2020, at 22:48, Ian Lepore wrote: > > > > On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: > > > > Sure. You can certainly ignore user reports corresponding to > > > > bogus > > > > flags, though, and encourage use o

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 22:48, Ian Lepore wrote: > > On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: >>> Sure. You can certainly ignore user reports corresponding to bogus >>> flags, though, and encourage use of various flags. >> >> I could, but decided to improve the situation for some

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Ian Lepore
On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: > > Sure. You can certainly ignore user reports corresponding to bogus > > flags, though, and encourage use of various flags. > > I could, but decided to improve the situation for some people, but > wasn't realising that I made it worse for

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 22:17, Conrad Meyer wrote: > > Hi Michael, > > On Mon, May 18, 2020 at 12:05 PM Michael Tuexen wrote: >> >>> On 18. May 2020, at 20:23, Conrad Meyer wrote: >> >>> If truncation is intended, the GCC warning is spurious. Given how >>> often snprintf is used in this way,

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
Hi Michael, On Mon, May 18, 2020 at 12:05 PM Michael Tuexen wrote: > > > On 18. May 2020, at 20:23, Conrad Meyer wrote: > > > If truncation is intended, the GCC warning is spurious. Given how > > often snprintf is used in this way, I wonder if it would make sense to > > just disable it across t

svn commit: r361227 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 19:48:38 2020 New Revision: 361227 URL: https://svnweb.freebsd.org/changeset/base/361227 Log: Remove assignment without effect. MFC after:3 days Modified: head/sys/netinet/sctp_auth.c Modified: head/sys/netinet/sctp_auth.c

svn commit: r361226 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 19:35:46 2020 New Revision: 361226 URL: https://svnweb.freebsd.org/changeset/base/361226 Log: Don't check an unsigned variable for being negative. MFC after:3 days. Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrre

svn commit: r361225 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 19:23:01 2020 New Revision: 361225 URL: https://svnweb.freebsd.org/changeset/base/361225 Log: Remove redundant assignment. MFC after:3 days Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c ===

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 20:23, Conrad Meyer wrote: > > On Mon, May 18, 2020 at 10:35 AM Michael Tuexen wrote: >> >>> On 18. May 2020, at 17:38, Conrad Meyer wrote: >>> >>> These changes are a bit odd. The only reason a standards-compliant >>> snprintf() would fail to nul-terminate a buffer is

svn commit: r361224 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 18:42:43 2020 New Revision: 361224 URL: https://svnweb.freebsd.org/changeset/base/361224 Log: Cleanup, no functional change intended. MFC after:3 days Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c

svn commit: r361223 - head/tests/sys/fs/fusefs

2020-05-18 Thread Alan Somers
Author: asomers Date: Mon May 18 18:36:32 2020 New Revision: 361223 URL: https://svnweb.freebsd.org/changeset/base/361223 Log: fusefs: fix intermittency in some ENOENT tests When a FUSE operation other than LOOKUP returns ENOENT, the kernel will reclaim that vnode, resuling in a FUSE_FORG

svn commit: r361222 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 18:32:58 2020 New Revision: 361222 URL: https://svnweb.freebsd.org/changeset/base/361222 Log: Avoid an integer underflow. MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c Modified: head/sys/netinet/sctp_asconf.c ==

svn commit: r361221 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 18:27:10 2020 New Revision: 361221 URL: https://svnweb.freebsd.org/changeset/base/361221 Log: Remove redundant check. MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c Modified: head/sys/netinet/sctp_asconf.c ==

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
On Mon, May 18, 2020 at 10:35 AM Michael Tuexen wrote: > > > On 18. May 2020, at 17:38, Conrad Meyer wrote: > > > > These changes are a bit odd. The only reason a standards-compliant > > snprintf() would fail to nul-terminate a buffer is if the provided > > buffer had length zero. Since this is

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 17:48, Conrad Meyer wrote: > > (In fact, I don't believe snprintf(9) can return a negative value at > all. And snprintf(3) will only do so in some special circumstances > for features snprintf(9) does not support: buffer size or formatted > result longer than INT_MAX; inval

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 17:38, Conrad Meyer wrote: > > Hi Michael, > > These changes are a bit odd. The only reason a standards-compliant > snprintf() would fail to nul-terminate a buffer is if the provided > buffer had length zero. Since this is not the case in any of these > uses, I wonder why

svn commit: r361220 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2020-05-18 Thread John Baldwin
Author: jhb Date: Mon May 18 16:47:44 2020 New Revision: 361220 URL: https://svnweb.freebsd.org/changeset/base/361220 Log: Correct the order of arguments to copyin() for Q_SETQUOTA. MFC after:2 weeks Sponsored by: DARPA Differential Revision:https://reviews.freebsd.org/D2465

svn commit: r361218 - head/contrib/binutils/gas

2020-05-18 Thread Ed Maste
Author: emaste Date: Mon May 18 16:07:14 2020 New Revision: 361218 URL: https://svnweb.freebsd.org/changeset/base/361218 Log: GNU as: move deprecation message after option parsing Some cmake test parses the output of the first line of as --version, and emits an error if it does not contai

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
(In fact, I don't believe snprintf(9) can return a negative value at all. And snprintf(3) will only do so in some special circumstances for features snprintf(9) does not support: buffer size or formatted result longer than INT_MAX; invalid *nn$ field width or precision specifiers. I don't think e

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
Hi Michael, These changes are a bit odd. The only reason a standards-compliant snprintf() would fail to nul-terminate a buffer is if the provided buffer had length zero. Since this is not the case in any of these uses, I wonder why this revision was made? Does a SCTP downstream have a broken sn

svn commit: r361216 - head/usr.sbin/acpi/acpidump

2020-05-18 Thread Andrew Turner
Author: andrew Date: Mon May 18 15:05:59 2020 New Revision: 361216 URL: https://svnweb.freebsd.org/changeset/base/361216 Log: Allow the FACS and XFACS to be zero in acpidump. These are allowed to be zero when the hardware reduced APCI flag is set Sponsored by: Innovate UK Differentia

svn commit: r361215 - head/usr.sbin/bhyve

2020-05-18 Thread Aleksandr Fedorov
Author: afedorov Date: Mon May 18 15:03:52 2020 New Revision: 361215 URL: https://svnweb.freebsd.org/changeset/base/361215 Log: bhyve(8): Add the netgraph network backend decription to the manpage. Reviewed by: vmaffione, bcr Approved by: vmaffione (mentor) Sponsored by: vstack.com

svn commit: r361214 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 15:02:15 2020 New Revision: 361214 URL: https://svnweb.freebsd.org/changeset/base/361214 Log: Fix logical condition by looking at usecs. This issue was found by cpp-check running on the userland stack. MFC after:3 days Modified: head/sys/n

svn commit: r361213 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 15:00:18 2020 New Revision: 361213 URL: https://svnweb.freebsd.org/changeset/base/361213 Log: Whitespace change. MFC after:3 days Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c =

svn commit: r361210 - head/contrib/netbsd-tests/lib/libexecinfo

2020-05-18 Thread Li-Wen Hsu
Author: lwhsu Date: Mon May 18 12:36:28 2020 New Revision: 361210 URL: https://svnweb.freebsd.org/changeset/base/361210 Log: Temporarily disable failing case in CI of amd64: - lib.libexecinfo.backtrace_test.backtrace_fmt_basic PR: 246537 Sponsored by: The FreeBSD Foundation

svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 10:07:01 2020 New Revision: 361209 URL: https://svnweb.freebsd.org/changeset/base/361209 Log: Handle failures of snprintf(). MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c head/sys/netinet/sctp_indata.c head/sys/netinet/sctp_inpu