Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Kubilay Kocak
On 27/09/2019 12:48 am, Charlie Li via svn-src-head wrote: Gleb Smirnoff wrote: Modified: head/sys/conf/options == --- head/sys/conf/options Wed Sep 25 18:09:19 2019(r352706) +++ head/sys/conf/options

svn commit: r352787 - head/sys/dev/ioat

2019-09-26 Thread Alexander Motin
Author: mav Date: Fri Sep 27 02:09:20 2019 New Revision: 352787 URL: https://svnweb.freebsd.org/changeset/base/352787 Log: Replace argument checks with assertions. Those functions are used by kernel, and we can't check all possible argument errors in production kernel. Plus according to

Re: svn commit: r352778 - in head/sys: conf sys

2019-09-26 Thread Warner Losh
This is a developer only option. Out-of-tree consumers would need to be compiled with the kernel directory, much like they would need to be for other things. You wouldn't run a system with this normally: it's only to debug specific instances of bad behavior. I think, like other debugging options, t

svn commit: r352786 - in head/contrib/ipfilter: man tools

2019-09-26 Thread Cy Schubert
Author: cy Date: Fri Sep 27 00:29:12 2019 New Revision: 352786 URL: https://svnweb.freebsd.org/changeset/base/352786 Log: Implement the dynamic add (-A) and removal (-R) of ippool pools from the command line. Prior to this the functionality was mostly there however since the pool type (-t) w

svn commit: r352784 - head/contrib/ipfilter/man

2019-09-26 Thread Cy Schubert
Author: cy Date: Fri Sep 27 00:29:06 2019 New Revision: 352784 URL: https://svnweb.freebsd.org/changeset/base/352784 Log: Sync with source: Only a role of "ipf" is currentlysupported as the other documented (and undocumented) roles are #ifdef'd out. The plan is to complete ippool(8)

svn commit: r352785 - head/contrib/ipfilter/tools

2019-09-26 Thread Cy Schubert
Author: cy Date: Fri Sep 27 00:29:09 2019 New Revision: 352785 URL: https://svnweb.freebsd.org/changeset/base/352785 Log: The no resolve (OPT_NORESOLVE) does nothing. Additionally, it (-R) conflicts with the command option of the same name (also -R). Remove the superfluous and confusing non-

svn commit: r352783 - head/contrib/ipfilter/man

2019-09-26 Thread Cy Schubert
Author: cy Date: Fri Sep 27 00:29:03 2019 New Revision: 352783 URL: https://svnweb.freebsd.org/changeset/base/352783 Log: Fix a typo. MFC after:3 days Modified: head/contrib/ipfilter/man/ippool.8 Modified: head/contrib/ipfilter/man/ippool.8 ==

Re: svn commit: r352778 - in head/sys: conf sys

2019-09-26 Thread Ryan Stone
Is this enough? Won't out-of-tree modules get compiled without EPOCH_TRACE set? If such a module is loaded on a kernel with EPOCH_TRACE set then the module will call epoch_enter_preempt() with a epoch_tracker that is too small and have its stack corrupted, won't it? On Thu, Sep 26, 2019 at 5:12

svn commit: r352778 - in head/sys: conf sys

2019-09-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 26 21:12:47 2019 New Revision: 352778 URL: https://svnweb.freebsd.org/changeset/base/352778 Log: Move EPOCH_TRACE to opt_global.h, so that any external modules that use epoch don't need Makefile tweaks. The downside is that any developer who wants EPOCH_TRACE

svn commit: r352776 - head/sys/dev/sound/pci/hda

2019-09-26 Thread Oleksandr Tymoshenko
Author: gonzo Date: Thu Sep 26 21:04:36 2019 New Revision: 352776 URL: https://svnweb.freebsd.org/changeset/base/352776 Log: snd_hda: Add Intel Cannon Lake support Add missing header change ommitted in r352775 MFC after:2 weeks X-MFC-with: 352775 Modified: head/sys/dev/sound

svn commit: r352775 - head/sys/dev/sound/pci/hda

2019-09-26 Thread Oleksandr Tymoshenko
Author: gonzo Date: Thu Sep 26 21:02:21 2019 New Revision: 352775 URL: https://svnweb.freebsd.org/changeset/base/352775 Log: snd_hda: Add Intel Cannon Lake support Add PCI ids for Intel Cannon Lake PCH Tested on:HP Spectre x360 13-p0043dx PR: 240574 Submitted by: Neel

Re: svn commit: r352747 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys tests/sys/posixshm usr.bin/truss

2019-09-26 Thread Konstantin Belousov
On Thu, Sep 26, 2019 at 03:32:28PM +, David Bright wrote: > Author: dab > Date: Thu Sep 26 15:32:28 2019 > New Revision: 352747 > URL: https://svnweb.freebsd.org/changeset/base/352747 > > Log: > Add an shm_rename syscall > Modified: head/sys/kern/uipc_shm.c > ===

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Warner Losh
Kinda my point exactly... Warner On Thu, Sep 26, 2019 at 11:25 AM Ryan Stone wrote: > We also shouldn't have ifdef's that change the size of a kernel > structure that's part of the KBI. Isn't struct epoch_tracker part of > the KBI? > > On Thu, Sep 26, 2019 at 12:46 PM Warner Losh wrote: > > >

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Ryan Stone
We also shouldn't have ifdef's that change the size of a kernel structure that's part of the KBI. Isn't struct epoch_tracker part of the KBI? On Thu, Sep 26, 2019 at 12:46 PM Warner Losh wrote: > > But we shouldn't be including opt_foo.h files in sys/*.h files. That's the > root cause of troubl

Re: svn commit: r338888 - head/sbin/devd

2019-09-26 Thread Renato Botelho
On 22/09/18 12:32, Warner Losh wrote: > Author: imp > Date: Sat Sep 22 15:32:53 2018 > New Revision: 33 > URL: https://svnweb.freebsd.org/changeset/base/33 > > Log: > We don't need shell protection for when we're expanding matches. > Don't add it. This should fix when we do regepx matc

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Warner Losh
But we shouldn't be including opt_foo.h files in sys/*.h files. That's the root cause of trouble here. Warner On Thu, Sep 26, 2019 at 9:11 AM Niclas Zeising wrote: > On 2019-09-26 17:03, Charlie Li via freebsd-x11 wrote: > > Kyle Evans wrote: > >> On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrot

svn commit: r352757 - in head: lib/libc/sys lib/libregex/tests stand/lua tests/sys/kern

2019-09-26 Thread Kyle Evans
Author: kevans Date: Thu Sep 26 16:19:22 2019 New Revision: 352757 URL: https://svnweb.freebsd.org/changeset/base/352757 Log: Further normalize copyright notices - s/C/c/ where I've been inconsistent about it - +SPDX tags - Remove "All rights reserved" where possible Requested by:

svn commit: r352756 - head/lib/libc/sys

2019-09-26 Thread David Bright
Author: dab Date: Thu Sep 26 16:13:17 2019 New Revision: 352756 URL: https://svnweb.freebsd.org/changeset/base/352756 Log: Correct mistake in MLINKS introduced in r352747 Messed up a merge conflict resolution and didn't catch that before commit. Sponsored by: Dell EMC Isilon Modifie

Re: svn commit: r352747 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys tests/sys/posixshm usr.bin/truss

2019-09-26 Thread Kyle Evans
On Thu, Sep 26, 2019 at 10:32 AM David Bright wrote: > > Author: dab > Date: Thu Sep 26 15:32:28 2019 > New Revision: 352747 > URL: https://svnweb.freebsd.org/changeset/base/352747 > > Log: > Add an shm_rename syscall > > Add an atomic shm rename operation, similar in spirit to a file > rena

svn commit: r352751 - in head/sys: compat/freebsd32 kern sys

2019-09-26 Thread David Bright
Author: dab Date: Thu Sep 26 15:41:10 2019 New Revision: 352751 URL: https://svnweb.freebsd.org/changeset/base/352751 Log: sysent: regenerate after r352747. Sponsored by: Dell EMC Isilon Modified: head/sys/compat/freebsd32/freebsd32_syscall.h head/sys/compat/freebsd32/freebsd32_syscall

svn commit: r352748 - head/sys/kern

2019-09-26 Thread Mark Johnston
Author: markj Date: Thu Sep 26 15:35:35 2019 New Revision: 352748 URL: https://svnweb.freebsd.org/changeset/base/352748 Log: Fix handling of invalid pages in exec_map_first_page(). exec_map_first_page() would unconditionally free an unbacked, invalid page from the executable image. Howev

svn commit: r352747 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys tests/sys/posixshm usr.bin/truss

2019-09-26 Thread David Bright
Author: dab Date: Thu Sep 26 15:32:28 2019 New Revision: 352747 URL: https://svnweb.freebsd.org/changeset/base/352747 Log: Add an shm_rename syscall Add an atomic shm rename operation, similar in spirit to a file rename. Atomically unlink an shm from a source path and link it to a desti

svn commit: r352746 - head/sys/netinet

2019-09-26 Thread Jonathan T. Looney
Author: jtl Date: Thu Sep 26 15:18:57 2019 New Revision: 352746 URL: https://svnweb.freebsd.org/changeset/base/352746 Log: Add new functionality to switch to using cookies exclusively when we the syn cache overflows. Whether this is due to an attack or due to the system having more legitimat

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Niclas Zeising
On 2019-09-26 17:03, Charlie Li via freebsd-x11 wrote: Kyle Evans wrote: On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrote: This breaks building the drm-kmod ports, as the build cannot find opt_epoch.h (drm-devel-kmod example shown, drm-current-kmod dies the exact same way): --- linux_anon_inod

svn commit: r352745 - head/sys/netinet

2019-09-26 Thread Jonathan T. Looney
Author: jtl Date: Thu Sep 26 15:06:46 2019 New Revision: 352745 URL: https://svnweb.freebsd.org/changeset/base/352745 Log: Access the syncache secret directly from the V_tcp_syncache variable, rather than indirectly through the backpointer to the tcp_syncache structure stored in the hashtabl

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Charlie Li via svn-src-head
Kyle Evans wrote: > On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrote: >> This breaks building the drm-kmod ports, as the build cannot find >> opt_epoch.h (drm-devel-kmod example shown, drm-current-kmod dies the >> exact same way): >> >> --- linux_anon_inodes.o --- >> cc -O2 -pipe -fno-strict-alias

svn commit: r352744 - head/sys/netinet

2019-09-26 Thread Jonathan T. Looney
Author: jtl Date: Thu Sep 26 15:02:34 2019 New Revision: 352744 URL: https://svnweb.freebsd.org/changeset/base/352744 Log: Remove the unused sch parameter to the syncache_respond() function. The use of this parameter was removed in r313330. This commit now removes passing this now-unused par

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Kyle Evans
On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrote: > > Gleb Smirnoff wrote: > > Modified: head/sys/conf/options > > == > > --- head/sys/conf/options Wed Sep 25 18:09:19 2019(r352706) > > +++ head/sys/conf/option

svn commit: r352743 - head/sys/cam/scsi

2019-09-26 Thread Alexander Motin
Author: mav Date: Thu Sep 26 14:48:39 2019 New Revision: 352743 URL: https://svnweb.freebsd.org/changeset/base/352743 Log: Add kern.cam.da.X.quirks tunable, similar existing for ada. Submitted by: Michael Lass MFC after:2 weeks Differential Revision:https://reviews.freebsd.o

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Charlie Li via svn-src-head
Gleb Smirnoff wrote: > Modified: head/sys/conf/options > == > --- head/sys/conf/options Wed Sep 25 18:09:19 2019(r352706) > +++ head/sys/conf/options Wed Sep 25 18:26:31 2019(r352707) > @@ -712,6 +71

svn commit: r352742 - head/usr.bin/bsdiff/bspatch

2019-09-26 Thread Ed Maste
Author: emaste Date: Thu Sep 26 13:27:25 2019 New Revision: 352742 URL: https://svnweb.freebsd.org/changeset/base/352742 Log: bspatch: add integer overflow checks Introduce a new add_off_t static function that exits with an error message if there's an overflow, otherwise returns their sum

Re: svn commit: r352695 - in head/sys: kern sys

2019-09-26 Thread Kyle Evans
On Wed, Sep 25, 2019 at 12:32 PM Kyle Evans wrote: > > Author: kevans > Date: Wed Sep 25 17:32:43 2019 > New Revision: 352695 > URL: https://svnweb.freebsd.org/changeset/base/352695 > > Log: > [1/3] Add mostly Linux-compatible file sealing support > > File sealing applies protections against c

svn commit: r352740 - head/sys/kern

2019-09-26 Thread Toomas Soome
Author: tsoome Date: Thu Sep 26 07:19:26 2019 New Revision: 352740 URL: https://svnweb.freebsd.org/changeset/base/352740 Log: kernel terminal should initialize fg and bg variables before calling TUNABLE_INT_FETCH We have two ways to check if kenv variable exists - either we check return

svn commit: r352739 - head/sys/dev/vt/hw/fb

2019-09-26 Thread Toomas Soome
Author: tsoome Date: Thu Sep 26 07:14:54 2019 New Revision: 352739 URL: https://svnweb.freebsd.org/changeset/base/352739 Log: vt: use proper return value check with TUNABLE_INT_FETCH The TUNABLE_INT_FETCH is macro around getenv_int() and we will get return value 0 or 1 for failure or succ