svn commit: r352738 - head/contrib/ipfilter/tools

Author: cy Date: Thu Sep 26 03:09:45 2019 New Revision: 352738 URL: https://svnweb.freebsd.org/changeset/base/352738 Log: Teach the ippool parser about address families. This is a precursor to implementing IPv6 support within ippool which requires reworking radix_ipf.c. MFC after:1

svn commit: r352737 - head/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Sep 26 03:09:42 2019 New Revision: 352737 URL: https://svnweb.freebsd.org/changeset/base/352737 Log: ipf mistakenly regards UDP packets with a checksum of 0x as bad. Obtained from:NetBSD fil.c r1.30, NetBSD PR/54443 MFC after:3 days Modified: head/s

svn commit: r352736 - in head/sys/fs: nfs nfsclient

Author: rmacklem Date: Thu Sep 26 02:54:45 2019 New Revision: 352736 URL: https://svnweb.freebsd.org/changeset/base/352736 Log: Replace all mtx_assert() calls for n_mtx and ncl_iod_mutex with macros. To be consistent with replacing the mtx_lock()/mtx_unlock() calls on the NFS node mutex (

svn commit: r352734 - head/sys/amd64/amd64

Author: cem Date: Thu Sep 26 01:51:55 2019 New Revision: 352734 URL: https://svnweb.freebsd.org/changeset/base/352734 Log: amd64 pmap: Clarify largemap bootverbose message units A PML4 covers 512 gigabytes, not gigabits. Use the typical B suffix for bytes. No functional change. Spo

svn commit: r352733 - head/sys/amd64/amd64

Author: cem Date: Thu Sep 26 01:50:26 2019 New Revision: 352733 URL: https://svnweb.freebsd.org/changeset/base/352733 Log: amd64: Expose vm.pmap.large_map_pml4_entries as a sysctl node It's nice to have sysctl nodes for tunables. Sponsored by: Dell EMC Isilon Modified: head/sys/amd6

svn commit: r352732 - in head/contrib/libarchive: cat cpio libarchive libarchive/test tar tar/test test_utils

Author: mm Date: Thu Sep 26 01:50:20 2019 New Revision: 352732 URL: https://svnweb.freebsd.org/changeset/base/352732 Log: MFV r352731: Sync libarchive with vendor. Relevant vendor changes: Issue #1237: Fix integer overflow in archive_read_support_filter_lz4.c PR #1249: Correct som

svn commit: r352730 - head/sys/riscv/riscv

Author: mhorne Date: Thu Sep 26 00:58:47 2019 New Revision: 352730 URL: https://svnweb.freebsd.org/changeset/base/352730 Log: Fix some broken relocation handling In a few cases, the symbol lookup is missing before attempting to perform the relocation. While the relocation types affected a

svn commit: r352729 - head/sys/riscv/riscv

Author: mhorne Date: Thu Sep 26 00:54:07 2019 New Revision: 352729 URL: https://svnweb.freebsd.org/changeset/base/352729 Log: Cleanup of elf_machdep.c Fix some style(9) violations. This also changes the name of the machine-dependent sysctl kern.debug_kld to debug.kld_reloc, and chang

svn commit: r352728 - head/sys/kern

Author: mav Date: Thu Sep 26 00:35:06 2019 New Revision: 352728 URL: https://svnweb.freebsd.org/changeset/base/352728 Log: Microoptimize sched_pickcpu() CPU affinity on SMT. Use of CPU_FFS() to implement CPUSET_FOREACH() allows to save up to ~0.5% of CPU time on 72-thread SMT system doing

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

On Wed, 25 Sep 2019 at 17:13, Dimitry Andric wrote: > > > Interesting, it seems Clang doesn't even warn in the case of casting a > > uint64_t to a 32-bit pointer. Looks like there are some useful > > warnings that ought to be implemented. > > There is -Wconversion for this, or the more specific -W

svn commit: r352727 - in head: lib/libc/sys tests/sys/kern

Author: kevans Date: Wed Sep 25 22:53:30 2019 New Revision: 352727 URL: https://svnweb.freebsd.org/changeset/base/352727 Log: Add SPDX tags to recently added files Reported by: Pawel Biernacki Modified: head/lib/libc/sys/shm_open.c head/tests/sys/kern/memfd_test.c Modified: head/lib/

svn commit: r352726 - head/usr.sbin/efibootmgr

Author: yuripv Date: Wed Sep 25 21:23:30 2019 New Revision: 352726 URL: https://svnweb.freebsd.org/changeset/base/352726 Log: efibootmgr(8): fix markup and style issues - split synopsis into separate options that can't be used together - sort options - fix (style) issues reported by man

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

On 25 Sep 2019, at 15:36, Ed Maste wrote: > > On Tue, 24 Sep 2019 at 17:39, Bruce Evans wrote: >> >> On i386, these types have different sizes, so >> gcc detects the type mismatch. clang is too broken to report this type >> mismatch. > > Interesting, it seems Clang doesn't even warn in the ca

svn commit: r352725 - in head/sys: dev/firewire net

Author: glebius Date: Wed Sep 25 20:46:09 2019 New Revision: 352725 URL: https://svnweb.freebsd.org/changeset/base/352725 Log: style(9): remove extraneous empty lines Modified: head/sys/dev/firewire/if_fwip.c head/sys/net/if_ethersubr.c head/sys/net/if_vlan.c Modified: head/sys/dev/firew

svn commit: r352713 - head/sys/kern

Author: mav Date: Wed Sep 25 19:29:09 2019 New Revision: 352713 URL: https://svnweb.freebsd.org/changeset/base/352713 Log: Microoptimize sched_pickcpu() after r352658. I've noticed that I missed intr check at one more SCHED_AFFINITY(), so instead of adding one more branching I prefer to r

svn commit: r352712 - in head/lib/libc: gen sys

Author: kevans Date: Wed Sep 25 19:22:03 2019 New Revision: 352712 URL: https://svnweb.freebsd.org/changeset/base/352712 Log: posix_spawn(3): handle potential signal issues with vfork Described in [1], signal handlers running in a vfork child have opportunities to corrupt the parent's sta

svn commit: r352711 - in head: lib/libc/sys sys/kern sys/sys

Author: kevans Date: Wed Sep 25 19:20:41 2019 New Revision: 352711 URL: https://svnweb.freebsd.org/changeset/base/352711 Log: rfork(2): add RFSPAWN flag When RFSPAWN is passed, rfork exhibits vfork(2) semantics but also resets signal handlers in the child during creation to avoid a point

Re: svn commit: r351319 - in head/usr.sbin/makefs: ffs msdos

On Fri, 30 Aug 2019 at 00:29, Bruce Evans wrote: > > On Wed, 21 Aug 2019, Ed Maste wrote: > > > Author: emaste > > Date: Wed Aug 21 01:45:29 2019 > > New Revision: 351319 > > URL: https://svnweb.freebsd.org/changeset/base/351319 > > > > Log: > > makefs: use `char *` not `void *` for buf b_data, d

svn commit: r352710 - head/lib/msun/src

Author: dim Date: Wed Sep 25 18:50:57 2019 New Revision: 352710 URL: https://svnweb.freebsd.org/changeset/base/352710 Log: Do not left-shift a negative number (inducing undefined behavior in C/C++) in exp(3), expf(3), expm1(3) and expm1f(3) during intermediate computations that compute the I

svn commit: r352709 - head/sys/compat/freebsd32

Author: kevans Date: Wed Sep 25 18:48:05 2019 New Revision: 352709 URL: https://svnweb.freebsd.org/changeset/base/352709 Log: compat/freebsd32: restore style after r352705 (no functional change) The escaped newlines haven't been necessary since r339624, but this file has not been reformat

svn commit: r352707 - in head/sys: conf kern net sys

Author: glebius Date: Wed Sep 25 18:26:31 2019 New Revision: 352707 URL: https://svnweb.freebsd.org/changeset/base/352707 Log: Add debugging facility EPOCH_TRACE that checks that epochs entered are properly nested and warns about recursive entrances. Unlike with locks, there is nothing fund

svn commit: r352706 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys usr.bin/kdump

Author: kevans Date: Wed Sep 25 18:09:19 2019 New Revision: 352706 URL: https://svnweb.freebsd.org/changeset/base/352706 Log: sysent: regenerate after r352705 This also implements it, fixes kdump, and removes no longer needed bits from lib/libc/sys/shm_open.c for the interim. Modified:

svn commit: r352705 - in head/sys: compat/freebsd32 kern

Author: kevans Date: Wed Sep 25 18:06:48 2019 New Revision: 352705 URL: https://svnweb.freebsd.org/changeset/base/352705 Log: Mark shm_open(2) as COMPAT12, succeeded by shm_open2 Implementation and regenerated files will follow. Modified: head/sys/compat/freebsd32/syscalls.master head/

svn commit: r352704 - head

Author: kevans Date: Wed Sep 25 18:04:09 2019 New Revision: 352704 URL: https://svnweb.freebsd.org/changeset/base/352704 Log: Adjust Makefile.inc1 syscall sub commit Modified: head/Makefile.inc1 Modified: head/Makefile.inc1

svn commit: r352703 - in head: . lib/libc/include lib/libc/sys sys/sys tests/sys/kern

Author: kevans Date: Wed Sep 25 18:03:18 2019 New Revision: 352703 URL: https://svnweb.freebsd.org/changeset/base/352703 Log: Add linux-compatible memfd_create memfd_create is effectively a SHM_ANON shm_open(2) mapping with optional CLOEXEC and file sealing support. This is used by some m

svn commit: r352702 - head/tools/debugscripts

Author: glebius Date: Wed Sep 25 18:03:15 2019 New Revision: 352702 URL: https://svnweb.freebsd.org/changeset/base/352702 Log: Enhance the 'ps' command so that it prints a line per proc and a line per thread, so that instead of repeating the same info for all threads in proc, it would print

svn commit: r352701 - in head/sys: compat/freebsd32 kern sys

Author: kevans Date: Wed Sep 25 17:59:58 2019 New Revision: 352701 URL: https://svnweb.freebsd.org/changeset/base/352701 Log: sysent: regenerate after r352700 Modified: head/sys/compat/freebsd32/freebsd32_syscall.h head/sys/compat/freebsd32/freebsd32_syscalls.c head/sys/compat/freebsd32/f

svn commit: r352700 - in head/sys: compat/freebsd32 kern sys

Author: kevans Date: Wed Sep 25 17:59:15 2019 New Revision: 352700 URL: https://svnweb.freebsd.org/changeset/base/352700 Log: Add a shm_open2 syscall to support upcoming memfd_create shm_open2 allows a little more flexibility than the original shm_open. shm_open2 doesn't enforce CLOEXEC o

svn commit: r352699 - head/share/mk

Author: dim Date: Wed Sep 25 17:52:59 2019 New Revision: 352699 URL: https://svnweb.freebsd.org/changeset/base/352699 Log: In suite.test.mk, test if ${DESTDIR} exists before attempting to run chflags -R on it, otherwise the command will error out. (Note that adding -f to the chflags invocat

svn commit: r352698 - head

Author: dim Date: Wed Sep 25 17:35:34 2019 New Revision: 352698 URL: https://svnweb.freebsd.org/changeset/base/352698 Log: In r340411, libufs.so's major number was bumped to 7, but an entry in ObsoleteFiles.inc was not added. Retroactively fix that. Modified: head/ObsoleteFiles.inc Modifi

svn commit: r352697 - in head/sys: compat/cloudabi kern sys

Author: kevans Date: Wed Sep 25 17:35:03 2019 New Revision: 352697 URL: https://svnweb.freebsd.org/changeset/base/352697 Log: [2/3] Add an initial seal argument to kern_shm_open() Now that flags may be set on posixshm, add an argument to kern_shm_open() for the initial seals. To maintain

svn commit: r352696 - head/lib/libc/sys

Author: kevans Date: Wed Sep 25 17:33:12 2019 New Revision: 352696 URL: https://svnweb.freebsd.org/changeset/base/352696 Log: Update fcntl(2) after r352695 Modified: head/lib/libc/sys/fcntl.2 Modified: head/lib/libc/sys/fcntl.2

svn commit: r352695 - in head/sys: kern sys

Author: kevans Date: Wed Sep 25 17:32:43 2019 New Revision: 352695 URL: https://svnweb.freebsd.org/changeset/base/352695 Log: [1/3] Add mostly Linux-compatible file sealing support File sealing applies protections against certain actions (currently: write, growth, shrink) at the inode lev

svn commit: r352694 - in head/sys: amd64/linux amd64/linux32 arm64/linux compat/freebsd32 i386/linux sys

Author: kevans Date: Wed Sep 25 17:30:28 2019 New Revision: 352694 URL: https://svnweb.freebsd.org/changeset/base/352694 Log: sysent: regenerate after r352693 Modified: head/sys/amd64/linux/linux_proto.h head/sys/amd64/linux32/linux32_proto.h head/sys/arm64/linux/linux_proto.h head/sys/

svn commit: r352693 - in head/sys: compat/freebsd32 kern

Author: kevans Date: Wed Sep 25 17:29:45 2019 New Revision: 352693 URL: https://svnweb.freebsd.org/changeset/base/352693 Log: Add COMPAT12 support to makesyscalls.sh Reviewed by: kib, imp, brooks (all without syscalls.master edits) Differential Revision:https://reviews.freebsd.or

svn commit: r352691 - in head: contrib/netbsd-tests/usr.bin/grep usr.bin/grep

Author: kevans Date: Wed Sep 25 17:14:43 2019 New Revision: 352691 URL: https://svnweb.freebsd.org/changeset/base/352691 Log: bsdgrep(1): various fixes of empty pattern/exit code/-c behavior When an empty pattern is encountered in the pattern list, I had previously broken bsdgrep to count

svn commit: r352690 - head/sys/vm

Author: markj Date: Wed Sep 25 17:08:35 2019 New Revision: 352690 URL: https://svnweb.freebsd.org/changeset/base/352690 Log: Add some counters for per-VM page events. For now, just count batched page queue state operations. vm.stats.page.queue_ops counts the number of batch entries that

svn commit: r352689 - head/lib/libc/i386/string

Author: emaste Date: Wed Sep 25 16:49:22 2019 New Revision: 352689 URL: https://svnweb.freebsd.org/changeset/base/352689 Log: remove obsolete i386 MD memchr implementation bde reports (in a reply to r351700 commit mail): This uses scasb, which was last optimal on the 8086, or perhaps

Re: svn commit: r351700 - head/lib/libc/string

On Wed, 25 Sep 2019 at 11:46, Bruce Evans wrote: > > On Wed, 25 Sep 2019, Ed Maste wrote: > > > On Fri, 20 Sep 2019 at 08:14, Bruce Evans wrote: > >> > >> Optimizing this function [memchr] is especially unimportant, > > > > Why? > > Because it is almost never used, and most of its uses are unimpo

svn commit: r352688 - in head/sys: amd64/amd64 arm/arm arm64/arm64 dev/agp i386/i386 mips/mips powerpc/booke riscv/riscv vm x86/iommu

Author: markj Date: Wed Sep 25 16:11:35 2019 New Revision: 352688 URL: https://svnweb.freebsd.org/changeset/base/352688 Log: Complete the removal of the "wire_count" field from struct vm_page. Convert all remaining references to that field to "ref_count" and update comments accordingly.

Re: svn commit: r351700 - head/lib/libc/string

On Wed, 25 Sep 2019, Ed Maste wrote: On Fri, 20 Sep 2019 at 08:14, Bruce Evans wrote: Optimizing this function [memchr] is especially unimportant, Why? Because it is almost never used, and most of its uses are unimportant. It is used a whole 26 times in all of /usr/src/*bin: - sh/exec.c:

Re: svn commit: r351700 - head/lib/libc/string

On Wed, 25 Sep 2019 at 10:11, Ed Maste wrote: > > Functionally equivalent, although I compared the compiled output of > both cases and what's currently there is somewhat smaller. Note that > it's not an #else case, the equivalent loop is used in both cases - > handling the non-word-size residue in

Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio

On Fri, 13 Sep 2019 at 08:00, Bruce Evans wrote: > > C11 removed gets(), but POSIX.1-2017 (Issue 7) still has it (marked as > obsolescent). Thus this change breaks support for all versions of POSIX. Yes, and intentionally so. If there is a compelling reason to restore it I'll add the #ifdef-ery

Re: svn commit: r351700 - head/lib/libc/string

On Fri, 20 Sep 2019 at 08:14, Bruce Evans wrote: > > Optimizing this function [memchr] is especially unimportant, Why? Really, we should provide optimized assembly implementations of string functions deemed important, but it will take time for that to happen on all architectures. > and this ver

svn commit: r352684 - head/sys/x86/x86

Author: kib Date: Wed Sep 25 13:36:56 2019 New Revision: 352684 URL: https://svnweb.freebsd.org/changeset/base/352684 Log: x86: Fall back to leaf 0x16 if TSC frequency is obtained by CPUID and leaf 0x15 is not functional. This should improve automatic TSC frequency determination on Skyl

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

On Tue, 24 Sep 2019 at 17:39, Bruce Evans wrote: > > On i386, these types have different sizes, so > gcc detects the type mismatch. clang is too broken to report this type > mismatch. Interesting, it seems Clang doesn't even warn in the case of casting a uint64_t to a 32-bit pointer. Looks like

svn commit: r352681 - in head/sys/dev/vt: . hw/fb

Author: tsoome Date: Wed Sep 25 13:24:31 2019 New Revision: 352681 URL: https://svnweb.freebsd.org/changeset/base/352681 Log: vt: use colors from terminal emulator Instead of hardcoded colors, use terminal state. This also means, we need to record the pointer to terminal state with vtbuf.

svn commit: r352680 - head/sys/kern

Author: tsoome Date: Wed Sep 25 13:21:07 2019 New Revision: 352680 URL: https://svnweb.freebsd.org/changeset/base/352680 Log: kernel: terminal_init() should check for teken colors from kenv Check for teken.fg_color and teken.bg_color and prepare the color attributes accordingly. When

svn commit: r352679 - head

Author: kevans Date: Wed Sep 25 13:04:34 2019 New Revision: 352679 URL: https://svnweb.freebsd.org/changeset/base/352679 Log: RELNOTES: Document r352668 (crontab -n and -q options) Suggested by: bapt Modified: head/RELNOTES Modified: head/RELNOTES ===

Re: svn commit: r352668 - in head/usr.sbin/cron: cron crontab lib

On Wed, Sep 25, 2019 at 1:58 AM Baptiste Daroussin wrote: > > On Wed, Sep 25, 2019 at 02:37:41AM +, Kyle Evans wrote: > > Author: kevans > > Date: Wed Sep 25 02:37:40 2019 > > New Revision: 352668 > > URL: https://svnweb.freebsd.org/changeset/base/352668 > > > > Log: > > cron: add log suppre

Re: svn commit: r352658 - head/sys/kern

On 25.09.2019 01:13, Peter Holm wrote: > On Tue, Sep 24, 2019 at 08:01:20PM +, Alexander Motin wrote: >> Author: mav >> Date: Tue Sep 24 20:01:20 2019 >> New Revision: 352658 >> URL: https://svnweb.freebsd.org/changeset/base/352658 >> >> Log: >> Fix/improve interrupt threads scheduling. >>

svn commit: r352677 - head/sys/kern

Author: mav Date: Wed Sep 25 11:58:54 2019 New Revision: 352677 URL: https://svnweb.freebsd.org/changeset/base/352677 Log: Fix wrong assertion in r352658. MFC after:1 month Modified: head/sys/kern/sched_ule.c Modified: head/sys/kern/sched_ule.c ==

svn commit: r352671 - head/sbin/nvmecontrol

Author: imp Date: Wed Sep 25 07:51:30 2019 New Revision: 352671 URL: https://svnweb.freebsd.org/changeset/base/352671 Log: Size is unsigned, so remove the test entirely. The kernel won't crash if you have a bad value and I'd rather not have nvmecontrol know the internal details about how

svn commit: r352670 - in head/stand: efi/libefi i386/libi386

Author: tsoome Date: Wed Sep 25 07:36:35 2019 New Revision: 352670 URL: https://svnweb.freebsd.org/changeset/base/352670 Log: loader: fix indentation in efi_console and vidconsole Remove extra tab. Reported by: yuripv Modified: head/stand/efi/libefi/efi_console.c head/stand/i386/

Re: svn commit: r352658 - head/sys/kern

> On 25. Sep 2019, at 07:13, Peter Holm wrote: > > On Tue, Sep 24, 2019 at 08:01:20PM +, Alexander Motin wrote: >> Author: mav >> Date: Tue Sep 24 20:01:20 2019 >> New Revision: 352658 >> URL: https://svnweb.freebsd.org/changeset/base/352658 >> >> Log: >> Fix/improve interrupt threads sched

svn commit: r352669 - in head/stand: efi/libefi i386/libi386

Author: tsoome Date: Wed Sep 25 07:09:25 2019 New Revision: 352669 URL: https://svnweb.freebsd.org/changeset/base/352669 Log: loader: add teken.fg_color and teken.bg_color variables Add settable variables to control teken default color attributes. The supported colors are 0-7 or basic col