svn commit: r340800 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:56 2018 New Revision: 340800 URL: https://svnweb.freebsd.org/changeset/base/340800 Log: sfxge(4): let caller know that queue is already flushed Tx/Rx queue may be already flushed due to Tx/Rx error on the queue or MC reboot. Caller needs to know tha

svn commit: r340799 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:45 2018 New Revision: 340799 URL: https://svnweb.freebsd.org/changeset/base/340799 Log: sfxge(4): fix error code usage MCDI results returned in req.emr_rc have already been translated from MC_CMD_ERR_* to errno names, so using an MC_CMD_ERR_* value

svn commit: r340798 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:34 2018 New Revision: 340798 URL: https://svnweb.freebsd.org/changeset/base/340798 Log: sfxge(4): fix out of bounds read in VIs allocation Submitted by: Andy Moreton Sponsored by: Solarflare Communications, Inc. MFC after: 1 week Diffe

svn commit: r340797 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:22 2018 New Revision: 340797 URL: https://svnweb.freebsd.org/changeset/base/340797 Log: sfxge(4): fix potential buffer overflow in Tx queue init Improve error checking to avoid a caller overflowing the MCDI request buffer if the requested TXQ size w

svn commit: r340796 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:43:44 2018 New Revision: 340796 URL: https://svnweb.freebsd.org/changeset/base/340796 Log: sfxge(4): fix failure path in EF10 Tx queue PIO enable Submitted by: Andy Moreton Sponsored by: Solarflare Communications, Inc. MFC after: 1 week D

svn commit: r340795 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:38:59 2018 New Revision: 340795 URL: https://svnweb.freebsd.org/changeset/base/340795 Log: sfxge(4): add advanced function to extract FW version Some libefx-based drivers might need this functionality to indicate DPCPU FW IDs as part of FW version info

svn commit: r340794 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:26:37 2018 New Revision: 340794 URL: https://svnweb.freebsd.org/changeset/base/340794 Log: sfxge(4): add MCDI agnostic wrapper for MAC stats clear If a libefx-based driver needs some way to clear port statistics, then an MCDI agnostic method is require

svn commit: r340793 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Fri Nov 23 04:38:50 2018 New Revision: 340793 URL: https://svnweb.freebsd.org/changeset/base/340793 Log: Revert "fork: fix use-after-free with vfork" This unreliably breaks libc handling of vfork where forking succeded, but execve did not. vfork code in libc perform

svn commit: r340792 - head/sbin/ipfw

2018-11-22 Thread Guangyuan Yang
Author: ygy (doc committer) Date: Fri Nov 23 03:42:05 2018 New Revision: 340792 URL: https://svnweb.freebsd.org/changeset/base/340792 Log: Fix a minor typo in ipfw(8) manual page. PR: 230747 Submitted by: f.tos...@hotmail.it MFC after:1 week Modified: head/sbin/ipfw/ipf

svn commit: r340787 - head/sys/fs/nfsclient

2018-11-22 Thread Rick Macklem
Author: rmacklem Date: Fri Nov 23 00:17:47 2018 New Revision: 340787 URL: https://svnweb.freebsd.org/changeset/base/340787 Log: Make sure the NFS readdir client fills in all "struct dirent" data. The NFS client code (nfsrpc_readdir() and nfsrpc_readdirplus()) wasn't filling in parts of th

svn commit: r340786 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Thu Nov 22 21:38:24 2018 New Revision: 340786 URL: https://svnweb.freebsd.org/changeset/base/340786 Log: Annotate TDP_RFPPWAIT as unlikely. The flag is only set on vfork, but is tested for *all* syscalls. On amd64 this shortens common-case (not vfork) code. Modified:

svn commit: r340785 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Thu Nov 22 21:29:36 2018 New Revision: 340785 URL: https://svnweb.freebsd.org/changeset/base/340785 Log: fork: remove avoidable proc lock/unlock pair We don't have to access the process after making it runnable, so there is no need to hold it either. Sponsored by: T

svn commit: r340784 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Thu Nov 22 21:08:37 2018 New Revision: 340784 URL: https://svnweb.freebsd.org/changeset/base/340784 Log: fork: fix use-after-free with vfork The pointer to the child is stored without any reference held. Then it is blindly used to wait until P_PPWAIT is cleared. However,

svn commit: r340783 - in head/sys: kern netinet netinet6 ofed/drivers/infiniband/ulp/sdp

2018-11-22 Thread Mark Johnston
Author: markj Date: Thu Nov 22 20:49:41 2018 New Revision: 340783 URL: https://svnweb.freebsd.org/changeset/base/340783 Log: Plug some networking sysctl leaks. Various network protocol sysctl handlers were not zero-filling their output buffers and thus would export uninitialized stack mem

svn commit: r340782 - head/sys/netinet/tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 20:05:57 2018 New Revision: 340782 URL: https://svnweb.freebsd.org/changeset/base/340782 Log: A TCP stack is required to check SEG.ACK first, when processing a segment in the SYN-SENT state as stated in Section 3.9 of RFC 793, page 66. Ensure this is also done

svn commit: r340781 - head/sys/netinet/tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 20:02:39 2018 New Revision: 340781 URL: https://svnweb.freebsd.org/changeset/base/340781 Log: Ensure that the TCP RACK stack honours the setting of the net.inet.tcp.drop_synfin sysctl-variable. Reviewed by: rrs@ MFC after:1 week Spo

svn commit: r340777 - head/sys/netinet/tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 19:56:52 2018 New Revision: 340777 URL: https://svnweb.freebsd.org/changeset/base/340777 Log: Ensure that the default RTT stack can make an RTT measurement if the TCP connection was initiated using the RACK stack, but the peer does not support the TCP RACK ext

svn commit: r340774 - in head/sys/netinet: . tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 19:49:52 2018 New Revision: 340774 URL: https://svnweb.freebsd.org/changeset/base/340774 Log: Ensure that TCP RST-segments announce consistently a receiver window of zero. This was already done when sending them via tcp_respond(). Reviewed by: rrs@

svn commit: r340772 - head/sys/amd64/ia32

2018-11-22 Thread Mark Johnston
Author: markj Date: Thu Nov 22 17:51:19 2018 New Revision: 340772 URL: https://svnweb.freebsd.org/changeset/base/340772 Log: Clear unused bytes in ia32_osendsig(). Mirror the fix for the native i386 implementation from r218327. This code is compiled only when the non-default COMPAT_43 op

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-22 Thread Warner Losh
On Thu, Nov 22, 2018 at 10:28 AM Mateusz Guzik wrote: > On 11/20/18, Warner Losh wrote: > > On Tue, Nov 20, 2018 at 8:28 AM Mateusz Guzik wrote: > > > >> On 11/20/18, Konstantin Belousov wrote: > >> >> +#if defined(__mips__) || defined(__powerpc__) > >> > Please note what I asked about this #i

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-22 Thread Mateusz Guzik
On 11/20/18, Warner Losh wrote: > On Tue, Nov 20, 2018 at 8:28 AM Mateusz Guzik wrote: > >> On 11/20/18, Konstantin Belousov wrote: >> >> +#if defined(__mips__) || defined(__powerpc__) >> > Please note what I asked about this #ifdefs in the review. mips >> > and powerpc machine/atomic.h should d

svn commit: r340771 - head/sys/dev/proto

2018-11-22 Thread Ed Maste
Author: emaste Date: Thu Nov 22 16:55:09 2018 New Revision: 340771 URL: https://svnweb.freebsd.org/changeset/base/340771 Log: proto: change device permissions to 0600 C Turt reports that the driver is not thread safe and may have exploitable races. Note that the proto device is inten

svn commit: r340767 - in head/sys/dev/sfxge: . common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Thu Nov 22 16:15:24 2018 New Revision: 340767 URL: https://svnweb.freebsd.org/changeset/base/340767 Log: sfxge(4): limit max TXQ size on Medford to 2048 Queues with 4096 descriptors are not supported as the top bit is used for vfifo stuffing. Submitted by: M

svn commit: r340766 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Thu Nov 22 14:31:35 2018 New Revision: 340766 URL: https://svnweb.freebsd.org/changeset/base/340766 Log: sfxge(4): support packed stream Rx mode in libefx Submitted by: Artem V. Andreev Sponsored by: Solarflare Communications, Inc. Differential Revision: htt

svn commit: r340765 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Thu Nov 22 14:10:46 2018 New Revision: 340765 URL: https://svnweb.freebsd.org/changeset/base/340765 Log: sfxge(4): cleanup: move into right place Due to incorrect merge the piece of code was put in incorrect place and diverge from libefx in other locations. Spo

Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc

2018-11-22 Thread Kyle Evans
On Thu, Nov 22, 2018 at 1:16 AM Mark Johnston wrote: > > On Wed, Nov 21, 2018 at 10:02:15PM -0600, Kyle Evans wrote: > > On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans wrote: > > > > > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits > > > wrote: > > > > > > > > Author: jhibbits > > > > Date: Sun O