svn commit: r323904 - head/sys/netinet

Author: tuexen Date: Fri Sep 22 06:33:01 2017 New Revision: 323904 URL: https://svnweb.freebsd.org/changeset/base/323904 Log: Add missing locking. Found by Coverity while scanning the usrsctp library. MFC after:1 week Modified: head/sys/netinet/sctp_input.c Modified: head/sys/neti

svn commit: r323902 - head/sys/netinet

Author: tuexen Date: Fri Sep 22 06:07:47 2017 New Revision: 323902 URL: https://svnweb.freebsd.org/changeset/base/323902 Log: Add missing socket lock. MFC after:1 week Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c ===

svn commit: r323899 - head/tests/sys/opencrypto

Author: cem Date: Fri Sep 22 04:41:48 2017 New Revision: 323899 URL: https://svnweb.freebsd.org/changeset/base/323899 Log: cryptotest.py: Like r323869, skip SHA HMAC tests on non-SHA drivers Sponsored by: Dell EMC Isilon Modified: head/tests/sys/opencrypto/cryptotest.py Modified: head/t

svn commit: r323898 - head/tests/sys/opencrypto

Author: cem Date: Fri Sep 22 04:25:44 2017 New Revision: 323898 URL: https://svnweb.freebsd.org/changeset/base/323898 Log: cryptotest.py: Fix whitespace style errors I accidentally introduced different whitespace style in r323878. I'm not used to using tabs for indentation in Python scri

svn commit: r323897 - head/sys/boot/efi/include

Author: tsoome Date: Fri Sep 22 02:58:47 2017 New Revision: 323897 URL: https://svnweb.freebsd.org/changeset/base/323897 Log: efilib.h: typo in structure member description The link should be replaced by list. Modified: head/sys/boot/efi/include/efilib.h Modified: head/sys/boot/efi/incl

svn commit: r323896 - head/sys/boot/efi/include

Author: tsoome Date: Fri Sep 22 02:56:26 2017 New Revision: 323896 URL: https://svnweb.freebsd.org/changeset/base/323896 Log: r323885 did miss efilib.h update The efilib.h update was left out from r323885 by mistake. Modified: head/sys/boot/efi/include/efilib.h Modified: head/sys/boot/e

svn commit: r323895 - head/sys/boot/efi/libefi

Author: tsoome Date: Fri Sep 22 02:53:01 2017 New Revision: 323895 URL: https://svnweb.freebsd.org/changeset/base/323895 Log: libefi: efi_devpath_match local len should be unsigned DevicePathNodeLength() will always return unsigned value. Modified: head/sys/boot/efi/libefi/devpath.c Mod

svn commit: r323893 - head/sys/cam

Author: imp Date: Fri Sep 22 02:36:32 2017 New Revision: 323893 URL: https://svnweb.freebsd.org/changeset/base/323893 Log: cam iosched: Enforce iop limits below the quanta value Previously the iops limiter would always allow at least quanta ios per second as cam_iosched_iops_tick() never

svn commit: r323894 - head/sys/cam

Author: imp Date: Fri Sep 22 02:36:36 2017 New Revision: 323894 URL: https://svnweb.freebsd.org/changeset/base/323894 Log: cam iosched: Bettar account IOPS for smoother performance Prevent cam_iosched_iops_tick() from discarding 'unspent' ios unless it's a new accounting interval. Pr

svn commit: r323892 - head/sys/opencrypto

Author: jhb Date: Fri Sep 22 00:34:46 2017 New Revision: 323892 URL: https://svnweb.freebsd.org/changeset/base/323892 Log: Support AEAD requests with non-GCM algorithms. In particular, support chaining an AES cipher with an HMAC for a request including AAD. This permits submitting reques

svn commit: r323891 - in head: share/man/man4 sys/opencrypto

Author: jhb Date: Fri Sep 22 00:21:58 2017 New Revision: 323891 URL: https://svnweb.freebsd.org/changeset/base/323891 Log: Add a new COP_F_CIPHER_FIRST flag for struct crypt_op. This requests that the cipher be performed before rather than after the HMAC when both are specified for a sing

svn commit: r323889 - head/sys/opencrypto

Author: jhb Date: Fri Sep 22 00:15:54 2017 New Revision: 323889 URL: https://svnweb.freebsd.org/changeset/base/323889 Log: Place the AAD before the plaintext/ciphertext for CIOCRYPTAEAD. Software crypto implementations don't care how the buffer is laid out, but hardware implementations ma

svn commit: r323887 - head/sys/kern

Author: shurd Date: Thu Sep 21 23:27:35 2017 New Revision: 323887 URL: https://svnweb.freebsd.org/changeset/base/323887 Log: Fix undeclared identifier error introduced in r323879 It doesn't appear to be safe to use gtask->gt_name. Reported by: Mark Johnston, Jenkins Reviewed by: sb

svn commit: r323886 - head/sys/boot/efi/libefi

Author: tsoome Date: Thu Sep 21 23:22:18 2017 New Revision: 323886 URL: https://svnweb.freebsd.org/changeset/base/323886 Log: libefi: efipart.c should use calloc() The device specific *_add functions are using malloc() + memset, should use calloc instead. Modified: head/sys/boot/efi/li

svn commit: r323885 - head/sys/boot/efi/libefi

Author: tsoome Date: Thu Sep 21 23:14:07 2017 New Revision: 323885 URL: https://svnweb.freebsd.org/changeset/base/323885 Log: libefi: efi_devpath_match() should return bool The current implementation of efi_devpath_match() is returning values 0 or 1, so it should be updated to return bool

svn commit: r323883 - head/tools/tools/nanobsd

Author: imp Date: Thu Sep 21 23:10:56 2017 New Revision: 323883 URL: https://svnweb.freebsd.org/changeset/base/323883 Log: Always create usr/local/etc -> /etc/local symlink /usr/local/etc gets created and populated by packages. However, if no packages are installed when setup_nanobsd is r

svn commit: r323882 - in head/sys: fs/devfs kern

Author: jhb Date: Thu Sep 21 23:05:32 2017 New Revision: 323882 URL: https://svnweb.freebsd.org/changeset/base/323882 Log: Only handle _PC_MAX_CANON, _PC_MAX_INPUT, and _PC_VDISABLE for TTY devices. Move handling of these three pathconf() variables out of vop_stdpathconf() and into devfs_

svn commit: r323881 - head/sbin/fsck_ffs

Author: jhb Date: Thu Sep 21 22:33:59 2017 New Revision: 323881 URL: https://svnweb.freebsd.org/changeset/base/323881 Log: Use UFS_LINK_MAX instead of LINK_MAX. Submitted by: bde Sponsored by: Chelsio Communications Modified: head/sbin/fsck_ffs/suj.c Modified: head/sbin/fsck_ffs/suj.c

svn commit: r323880 - head/sys/dev/drm2/i915

Author: markj Date: Thu Sep 21 22:15:45 2017 New Revision: 323880 URL: https://svnweb.freebsd.org/changeset/base/323880 Log: Simplify i915_gem_wire_page() and avoid unneeded page-busying. Reviewed by: alc, kib MFC after:1 week Modified: head/sys/dev/drm2/i915/i915_gem.c Modified:

svn commit: r323879 - head/sys/kern

Author: shurd Date: Thu Sep 21 21:14:48 2017 New Revision: 323879 URL: https://svnweb.freebsd.org/changeset/base/323879 Log: Improved logging of gtaskqueue failues Check the return code of intr_setaffinity() and log any errors it returns. When a qid is not located, log an error before ret

svn commit: r323878 - head/tests/sys/opencrypto

Author: cem Date: Thu Sep 21 21:07:21 2017 New Revision: 323878 URL: https://svnweb.freebsd.org/changeset/base/323878 Log: cryptotest.py: Actually use NIST-KAT HMAC test vectors and test the right hashes Previously, this test was entirely a no-op as no vector in the NIST-KAT file has a p

svn commit: r323876 - head/sys/kern

Author: shurd Date: Thu Sep 21 20:34:33 2017 New Revision: 323876 URL: https://svnweb.freebsd.org/changeset/base/323876 Log: Fix M_GTASKQUEUE definition Previously had the same short and long description as taskqueues. This could cause problems with memguard(9) and vmstat -m which use t

svn commit: r323874 - head/sys/dev/bnxt

Author: shurd Date: Thu Sep 21 20:27:43 2017 New Revision: 323874 URL: https://svnweb.freebsd.org/changeset/base/323874 Log: bnxt: Fix driver when attached to a VF - Use HWRM_FUNC_VF_CFG instead of HWRM_FUNC_CFG on VFs - Fix NPAR/VF detection - Clean up flag definitions - Don't allow

svn commit: r323873 - head/sys/netgraph

Author: eugen (ports committer) Date: Thu Sep 21 20:16:10 2017 New Revision: 323873 URL: https://svnweb.freebsd.org/changeset/base/323873 Log: Unprotected modification of ng_iface(4) private data leads to kernel panic. Fix a race with per-node read-mostly lock and refcounting for a hook.

svn commit: r323869 - head/tests/sys/opencrypto

Author: cem Date: Thu Sep 21 18:06:21 2017 New Revision: 323869 URL: https://svnweb.freebsd.org/changeset/base/323869 Log: cryptotest.py: Do not run AES-CBC or AES-GCM tests on non-AES crypto(4) drivers For some reason, we only skipped AES-XTS tests if a driver was not in the aesmodules

svn commit: r323868 - head/sys/dev/drm2/i915

Author: alc Date: Thu Sep 21 15:32:41 2017 New Revision: 323868 URL: https://svnweb.freebsd.org/changeset/base/323868 Log: Modernize calls to vm_page_unwire(). As of r288122, vm_page_unwire() accepts PQ_NONE as the specified queue and returns a Boolean indicating whether the page's wire cou

svn commit: r323867 - head/sys/boot/efi/libefi

Author: tsoome Date: Thu Sep 21 15:30:20 2017 New Revision: 323867 URL: https://svnweb.freebsd.org/changeset/base/323867 Log: libefi: devicename.c cleanups Remove duplicated free()+return statements, default unit to 0 and improve strtol error processing. Modified: head/sys/boot/efi/lib

svn commit: r323866 - in head: contrib/tcpdump contrib/traceroute sbin/ping usr.bin/kdump usr.sbin/tcpdump/tcpdump usr.sbin/traceroute

Author: oshogbo Date: Thu Sep 21 14:41:41 2017 New Revision: 323866 URL: https://svnweb.freebsd.org/changeset/base/323866 Log: We use a few different ifdef's names to check if we are using Casper or not, let's standardize this. Now we are always use WITH_CASPER name. Discussed with:

svn commit: r323865 - in head/bin/cat: . tests

Author: sevan (doc committer) Date: Thu Sep 21 14:14:49 2017 New Revision: 323865 URL: https://svnweb.freebsd.org/changeset/base/323865 Log: Ammend bin/cat/cat.c so the output is the same aside from blank lines being numbered or unnumbered, depending on whether cat was invoked with -ne or -b

svn commit: r323864 - head/sys/net

Author: kp Date: Thu Sep 21 14:14:01 2017 New Revision: 323864 URL: https://svnweb.freebsd.org/changeset/base/323864 Log: bridge: Set module version This ensures that the loader will not load the module if it's also built in to the kernel. PR: 220860 Submitted by: Eugene

svn commit: r323861 - head/sys/netinet

Author: tuexen Date: Thu Sep 21 11:56:31 2017 New Revision: 323861 URL: https://svnweb.freebsd.org/changeset/base/323861 Log: Code cleanup, no functional change. MFC after:1 week Modified: head/sys/netinet/sctp_constants.h head/sys/netinet/sctp_input.c head/sys/netinet/sctp_outpu

svn commit: r323860 - head/sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:28:22 2017 New Revision: 323860 URL: https://svnweb.freebsd.org/changeset/base/323860 Log: Plug memory leak in case when nvlist allocation succeeds, but nvpair allocation fails. Submitted by: pjd@ MFC after:1 month Sponsored by: Wheel Systems M

svn commit: r323859 - head/sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:18:02 2017 New Revision: 323859 URL: https://svnweb.freebsd.org/changeset/base/323859 Log: Simplify the code by _not_ expecting success under 'fail'. Submitted by: pjd@ and oshogbo@ MFC after:1 month Sponsored by: Wheel Systems Modified: head/s

svn commit: r323858 - head/sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:16:44 2017 New Revision: 323858 URL: https://svnweb.freebsd.org/changeset/base/323858 Log: IMHO it is possible that failure will be treated as success because we don't initialize nvp on every loop iteration and the code under 'fail'(!) label detects succes

svn commit: r323856 - head/sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:14:43 2017 New Revision: 323856 URL: https://svnweb.freebsd.org/changeset/base/323856 Log: Free 'value' only once we are done freeing all individual Submitted by: pjd@ MFC after:1 month Found by: scan-build Sponsored by: Wheel Systems

svn commit: r323855 - head/tools/tools/nanobsd

Author: n_hibma Date: Thu Sep 21 10:13:48 2017 New Revision: 323855 URL: https://svnweb.freebsd.org/changeset/base/323855 Log: Remove an 'unused' function. This function was only set in legacy.sh and only at the very end after the disk image had been successfully created. The only differe

svn commit: r323854 - head/sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:10:42 2017 New Revision: 323854 URL: https://svnweb.freebsd.org/changeset/base/323854 Log: Because nvp wasn't initialized on every loop iteration once we jumped to 'fail' on error it was treated as success, because nvp!=NULL. Fix this by not handling succe

svn commit: r323853 - head/sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:06:00 2017 New Revision: 323853 URL: https://svnweb.freebsd.org/changeset/base/323853 Log: Make the code consistent by always using 'fail' label. Submitted by: pjd@ and oshogbo@ MFC after:1 month Sponsored by: Wheel Systems Modified: head/sys/c

svn commit: r323852 - head/sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:03:14 2017 New Revision: 323852 URL: https://svnweb.freebsd.org/changeset/base/323852 Log: The 'while (array != NULL) { }' suggests scan-build that array may be initially NULL, which is not possible. Change the loop to 'do {} while (array != NULL)' to sati

svn commit: r323851 - in head: lib/libnv sys/contrib/libnv

Author: oshogbo Date: Thu Sep 21 10:00:16 2017 New Revision: 323851 URL: https://svnweb.freebsd.org/changeset/base/323851 Log: Remove redundant initialization. Don't use variable - just return the value. Make scan-build happy by casting to 'void *' instead of 'void **'. Submitted by: pjd@

svn commit: r323850 - head/sys/netinet

Author: tuexen Date: Thu Sep 21 09:47:56 2017 New Revision: 323850 URL: https://svnweb.freebsd.org/changeset/base/323850 Log: Free the control structure after using is, not before. Found by Coverity while scanning the usrsctp library. MFC after:1 week Modified: head/sys/netinet/sctp_i

svn commit: r323849 - head/tools/tools/nanobsd

Author: n_hibma Date: Thu Sep 21 09:27:44 2017 New Revision: 323849 URL: https://svnweb.freebsd.org/changeset/base/323849 Log: Fix up style for consistency. Modified: head/tools/tools/nanobsd/defaults.sh Modified: head/tools/tools/nanobsd/defaults.sh =

svn commit: r323848 - head/tools/tools/nanobsd/embedded

Author: n_hibma Date: Thu Sep 21 09:22:41 2017 New Revision: 323848 URL: https://svnweb.freebsd.org/changeset/base/323848 Log: Speling mistakes. Modified: head/tools/tools/nanobsd/embedded/common Modified: head/tools/tools/nanobsd/embedded/common =

svn commit: r323847 - head/sys/netinet

Author: tuexen Date: Thu Sep 21 09:18:05 2017 New Revision: 323847 URL: https://svnweb.freebsd.org/changeset/base/323847 Log: No need to wakeup, since sctp_add_to_readq() does it. MFC after:1 week Modified: head/sys/netinet/sctp_indata.c Modified: head/sys/netinet/sctp_indata.c