Re: svn commit: r286700 - in head: sbin/ifconfig sys/net

2017-01-18 Thread Hiren Panchasara
Adding the submitter and other reviewers for their comments. On 01/18/17 at 03:03P, Alan Somers wrote: > Is the change to lacp_port_create correct? The comment indicates that > fast is configurable, but it's actually constant. Later on, there's > some dead code that depends on the value of fast

svn commit: r312396 - head/cddl/usr.sbin/zfsd

2017-01-18 Thread Alan Somers
Author: asomers Date: Wed Jan 18 22:10:18 2017 New Revision: 312396 URL: https://svnweb.freebsd.org/changeset/base/312396 Log: Fix an unchecked return value in zfsd It's pretty unlikely to actually hit this, but good to check it anyway Reported by: Coverity CID: 1362018 M

Re: svn commit: r286700 - in head: sbin/ifconfig sys/net

2017-01-18 Thread Alan Somers
Is the change to lacp_port_create correct? The comment indicates that fast is configurable, but it's actually constant. Later on, there's some dead code that depends on the value of fast (it was dead before this commit, too). CID: 1305734 CID: 1305692 -Alan On Wed, Aug 12, 2015 at 2:21 PM, Hir

svn commit: r312395 - head/sbin/devd

2017-01-18 Thread Alan Somers
Author: asomers Date: Wed Jan 18 20:24:37 2017 New Revision: 312395 URL: https://svnweb.freebsd.org/changeset/base/312395 Log: Fix several Coverity CIDs in devd CID 1362055, 1362054: File descriptor leaks during shutdown CID 1362013: Potential null-termination fail with long network devic

Re: svn commit: r312379 - in head: lib/libc/sys sbin/ifconfig sys/conf sys/kern sys/modules/if_lagg sys/modules/if_vlan sys/net sys/netinet sys/netinet6 sys/sys

2017-01-18 Thread Adrian Chadd
It depends, is this -HEAD or is this -stable? If this thing doesn't pan out with the chelsio/mellanox hardware socket rate limiting then we can either evolve it or remove it. -adrian ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/

Re: svn commit: r312387 - head/sys/sys

2017-01-18 Thread John Baldwin
On Wednesday, January 18, 2017 05:09:22 PM Gleb Smirnoff wrote: > Author: glebius > Date: Wed Jan 18 17:09:22 2017 > New Revision: 312387 > URL: https://svnweb.freebsd.org/changeset/base/312387 > > Log: > Fix regression from r311568: collision of MSG_NOSIGNAL with MSG_MORETOCOME > lead to dela

svn commit: r312393 - in head: sbin/restore sys/sys sys/ufs/ufs

2017-01-18 Thread Conrad E. Meyer
Author: cem Date: Wed Jan 18 18:16:57 2017 New Revision: 312393 URL: https://svnweb.freebsd.org/changeset/base/312393 Log: restore(8): Handle extended attribute names correctly UFS2 extended attribute names are not NUL-terminated. Handle appropriately. Correct the EXTATTR_BASE_LENGT

Re: svn commit: r312379 - in head: lib/libc/sys sbin/ifconfig sys/conf sys/kern sys/modules/if_lagg sys/modules/if_vlan sys/net sys/netinet sys/netinet6 sys/sys

2017-01-18 Thread Gleb Smirnoff
On Wed, Jan 18, 2017 at 07:04:05PM +0100, Hans Petter Selasky wrote: H> > there were no production testing of the feature, H> > that will prove that the idea actually works. H> H> Hi Gleb, H> H> This feature has been tested small scale in production environments and H> it for sure saves CPU vers

svn commit: r312392 - head/lib/libwrap

2017-01-18 Thread Ngie Cooper
Author: ngie Date: Wed Jan 18 18:14:50 2017 New Revision: 312392 URL: https://svnweb.freebsd.org/changeset/base/312392 Log: Use SRCTOP instead of .CURDIR-relative path in .PATH directive MFC after:3 weeks Sponsored by: Dell EMC Isilon Modified: head/lib/libwrap/Makefile Modified:

Re: svn commit: r312391 - in head: share/man/man5 sys/ufs/ufs

2017-01-18 Thread Conrad Meyer
On Wed, Jan 18, 2017 at 9:55 AM, Conrad E. Meyer wrote: > Author: cem > Date: Wed Jan 18 17:55:49 2017 > New Revision: 312391 > URL: https://svnweb.freebsd.org/changeset/base/312391 > > Log: > ufs/extattr.h: Fix documentation of ea_name termination > > The ea_name string is not nul-terminated.

Re: svn commit: r312379 - in head: lib/libc/sys sbin/ifconfig sys/conf sys/kern sys/modules/if_lagg sys/modules/if_vlan sys/net sys/netinet sys/netinet6 sys/sys

2017-01-18 Thread Hans Petter Selasky
On 01/18/17 18:31, Gleb Smirnoff wrote: there were no production testing of the feature, that will prove that the idea actually works. Hi Gleb, This feature has been tested small scale in production environments and it for sure saves CPU versus doing rate limiting all in software. Mellanox

svn commit: r312390 - in head/sys: kern sys

2017-01-18 Thread Mateusz Guzik
Author: mjg Date: Wed Jan 18 17:55:08 2017 New Revision: 312390 URL: https://svnweb.freebsd.org/changeset/base/312390 Log: sx: reduce lock accesses similarly to r311172 Discussed with: jhb Tested by:pho (previous version) Modified: head/sys/kern/kern_sx.c head/sys/sys/sx.h

svn commit: r312391 - in head: share/man/man5 sys/ufs/ufs

2017-01-18 Thread Conrad E. Meyer
Author: cem Date: Wed Jan 18 17:55:49 2017 New Revision: 312391 URL: https://svnweb.freebsd.org/changeset/base/312391 Log: ufs/extattr.h: Fix documentation of ea_name termination The ea_name string is not nul-terminated. Correct the documentation. Because the subsequent field is padde

svn commit: r312389 - in head/sys: kern sys

2017-01-18 Thread Mateusz Guzik
Author: mjg Date: Wed Jan 18 17:53:57 2017 New Revision: 312389 URL: https://svnweb.freebsd.org/changeset/base/312389 Log: rwlock: reduce lock accesses similarly to r311172 Discussed with: jhb Tested by:pho (previous version) Modified: head/sys/kern/kern_rwlock.c head/sys/sys

Re: svn commit: r312379 - in head: lib/libc/sys sbin/ifconfig sys/conf sys/kern sys/modules/if_lagg sys/modules/if_vlan sys/net sys/netinet sys/netinet6 sys/sys

2017-01-18 Thread Gleb Smirnoff
Hi! I'm quite disappointed by this checkin. This is an interesting experimental feature, but to my knowledge, there were no production testing of the feature, that will prove that the idea actually works. To my knowledge the code isn't used anywhere right now, it was just tested to work as a c

svn commit: r312388 - head/sys/sys

2017-01-18 Thread Gleb Smirnoff
Author: glebius Date: Wed Jan 18 17:21:28 2017 New Revision: 312388 URL: https://svnweb.freebsd.org/changeset/base/312388 Log: Format and sort MSG_* flags, to prevent misedits in future. There is no functional change. Modified: head/sys/sys/socket.h Modified: head/sys/sys/socket.h ===

svn commit: r312387 - head/sys/sys

2017-01-18 Thread Gleb Smirnoff
Author: glebius Date: Wed Jan 18 17:09:22 2017 New Revision: 312387 URL: https://svnweb.freebsd.org/changeset/base/312387 Log: Fix regression from r311568: collision of MSG_NOSIGNAL with MSG_MORETOCOME lead to delayed send of data sent with sendto(MSG_NOSIGNAL). Submitted by: rrs Modifie

svn commit: r312384 - head/sys/boot/fdt/dts/mips

2017-01-18 Thread Ruslan Bukin
Author: br Date: Wed Jan 18 14:41:59 2017 New Revision: 312384 URL: https://svnweb.freebsd.org/changeset/base/312384 Log: Remove empty ranges property so beri_simplebus can be attached again. Sponsored by: DARPA, AFRL Modified: head/sys/boot/fdt/dts/mips/beri-netfpga.dts head/sys/boot/

svn commit: r312383 - head/sys/dev/e1000

2017-01-18 Thread Sean Bruno
Author: sbruno Date: Wed Jan 18 14:23:43 2017 New Revision: 312383 URL: https://svnweb.freebsd.org/changeset/base/312383 Log: ugh, device_t not device_t * Reported by: hps Modified: head/sys/dev/e1000/if_em.h Modified: head/sys/dev/e1000/if_em.h

Re: svn commit: r312380 - head/sys/dev/e1000

2017-01-18 Thread Mateusz Guzik
On Wed, Jan 18, 2017 at 01:57:29PM +, Sean Bruno wrote: > Author: sbruno > Date: Wed Jan 18 13:57:29 2017 > New Revision: 312380 > URL: https://svnweb.freebsd.org/changeset/base/312380 > > Log: > Change device type to unbreak drm-next testing and builds. > > Submitted by: Matt Mac

svn commit: r312380 - head/sys/dev/e1000

2017-01-18 Thread Sean Bruno
Author: sbruno Date: Wed Jan 18 13:57:29 2017 New Revision: 312380 URL: https://svnweb.freebsd.org/changeset/base/312380 Log: Change device type to unbreak drm-next testing and builds. Submitted by: Matt Macy Modified: head/sys/dev/e1000/if_em.h Modified: head/sys/dev/e1000/if_em.h ===

svn commit: r312379 - in head: lib/libc/sys sbin/ifconfig sys/conf sys/kern sys/modules/if_lagg sys/modules/if_vlan sys/net sys/netinet sys/netinet6 sys/sys

2017-01-18 Thread Hans Petter Selasky
Author: hselasky Date: Wed Jan 18 13:31:17 2017 New Revision: 312379 URL: https://svnweb.freebsd.org/changeset/base/312379 Log: Implement kernel support for hardware rate limited sockets. - Add RATELIMIT kernel configuration keyword which must be set to enable the new functionality.

svn commit: r312378 - head/sys/cddl/dev/fbt/arm

2017-01-18 Thread Andrew Turner
Author: andrew Date: Wed Jan 18 13:27:24 2017 New Revision: 312378 URL: https://svnweb.freebsd.org/changeset/base/312378 Log: Use the kernel stack in the ARM FBT DTrace provider. This is used to find the fifth argument to functions being traced, however there was an error where the userspace

svn commit: r312374 - head/sys/boot/efi/libefi

2017-01-18 Thread Toomas Soome
Author: tsoome Date: Wed Jan 18 08:18:07 2017 New Revision: 312374 URL: https://svnweb.freebsd.org/changeset/base/312374 Log: loader: efi devpath api usage should be more aware of NULL pointers As the efi_devpath_last_node() and efi_devpath_trim() can return NULL pointers, the consumers o