Re: svn commit: r272820 - head/etc/devd

2014-11-04 Thread Hans Petter Selasky
On 11/05/14 00:31, Alexey Dokuchaev wrote: On Thu, Oct 09, 2014 at 01:58:20PM +, Hans Petter Selasky wrote: New Revision: 272820 URL: https://svnweb.freebsd.org/changeset/base/272820 Log: Add example devd configuration file for USB printers. +# Generic USB printer devices +#notify 100 {

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Adrian Chadd
... why not just use UMA? -adrian On 4 November 2014 03:29, Hans Petter Selasky wrote: > Author: hselasky > Date: Tue Nov 4 11:29:49 2014 > New Revision: 274088 > URL: https://svnweb.freebsd.org/changeset/base/274088 > > Log: > Simplify logic a bit. Ensure data buffer is properly aligned, >

svn commit: r274130 - head/etc/periodic/security

2014-11-04 Thread Baptiste Daroussin
Author: bapt Date: Wed Nov 5 06:42:07 2014 New Revision: 274130 URL: https://svnweb.freebsd.org/changeset/base/274130 Log: Avoid installing security.functions with executable bits, periodic(8) will try to execute all files with an executable bit in /etc/periodic/*/ while this file is suppos

svn commit: r274129 - head/sys/amd64/conf

2014-11-04 Thread George V. Neville-Neil
Author: gnn Date: Wed Nov 5 06:22:37 2014 New Revision: 274129 URL: https://svnweb.freebsd.org/changeset/base/274129 Log: Add support for netmap in GENERIC by default. Modified: head/sys/amd64/conf/GENERIC Modified: head/sys/amd64/conf/GENERIC ===

Re: svn commit: r273835 - head/usr.bin/top

2014-11-04 Thread Adrian Chadd
Hah, great catch! Thanks! -adrian On 29 October 2014 12:21, Jung-uk Kim wrote: > Author: jkim > Date: Wed Oct 29 19:21:19 2014 > New Revision: 273835 > URL: https://svnweb.freebsd.org/changeset/base/273835 > > Log: > Replace a magic number with the proper definition. This change actually >

Re: svn commit: r274123 - in head: lib/libdpv usr.bin/dpv

2014-11-04 Thread Garrett Cooper
On Nov 4, 2014, at 18:36, Devin Teske wrote: > Author: dteske > Date: Wed Nov 5 02:36:28 2014 > New Revision: 274123 > URL: https://svnweb.freebsd.org/changeset/base/274123 … > Modified: head/lib/libdpv/Makefile > == >

svn commit: r274127 - head/sys/boot/common

2014-11-04 Thread Marcel Moolenaar
Author: marcel Date: Wed Nov 5 04:18:41 2014 New Revision: 274127 URL: https://svnweb.freebsd.org/changeset/base/274127 Log: In alloc_pread() and kern_pread(), print errors only when DEBUG is defined. An error is not fatal and is supposed to be handled by the caller. Obtained from:

svn commit: r274126 - head/usr.bin/wc

2014-11-04 Thread Marcel Moolenaar
Author: marcel Date: Wed Nov 5 04:09:10 2014 New Revision: 274126 URL: https://svnweb.freebsd.org/changeset/base/274126 Log: Document that wc(1) supports libxo(3). Modified: head/usr.bin/wc/wc.1 Modified: head/usr.bin/wc/wc.1 =

svn commit: r274125 - head/usr.bin/wc

2014-11-04 Thread Marcel Moolenaar
Author: marcel Date: Wed Nov 5 04:02:25 2014 New Revision: 274125 URL: https://svnweb.freebsd.org/changeset/base/274125 Log: Convert to use libxo. Obtained from:Phil Shafer Sponsored by: Juniper Networks, Inc. Modified: head/usr.bin/wc/Makefile head/usr.bin/wc/wc.c Modifie

Re: svn commit: r274124 - in head: lib usr.bin

2014-11-04 Thread Ian Lepore
On Wed, 2014-11-05 at 02:58 +, Devin Teske wrote: > Author: dteske > Date: Wed Nov 5 02:58:02 2014 > New Revision: 274124 > URL: https://svnweb.freebsd.org/changeset/base/274124 > > Log: > Temporarily _disable_ compilation of dpv(3) and dpv(1). > Will revisit this to find out how to solve

svn commit: r274124 - in head: lib usr.bin

2014-11-04 Thread Devin Teske
Author: dteske Date: Wed Nov 5 02:58:02 2014 New Revision: 274124 URL: https://svnweb.freebsd.org/changeset/base/274124 Log: Temporarily _disable_ compilation of dpv(3) and dpv(1). Will revisit this to find out how to solve the ordering issue in buildworld (potentially `make -j' specific).

svn commit: r274123 - in head: lib/libdpv usr.bin/dpv

2014-11-04 Thread Devin Teske
Author: dteske Date: Wed Nov 5 02:36:28 2014 New Revision: 274123 URL: https://svnweb.freebsd.org/changeset/base/274123 Log: Fix buildworld by adding DPADD= to libdpv [dpv(3)] Makefile NB: Should also address `make -j' building Remove "+" from "+=" in assignments to DPADD/LDADD while here.

Re: svn commit: r274122 - in head/sys: kern sys

2014-11-04 Thread Mateusz Guzik
On Wed, Nov 05, 2014 at 02:08:38AM +, Mateusz Guzik wrote: > Author: mjg > Date: Wed Nov 5 02:08:37 2014 > New Revision: 274122 > URL: https://svnweb.freebsd.org/changeset/base/274122 > > Log: > Extend struct ucred with group table. > > This saves one malloc + free with typical cases a

svn commit: r274122 - in head/sys: kern sys

2014-11-04 Thread Mateusz Guzik
Author: mjg Date: Wed Nov 5 02:08:37 2014 New Revision: 274122 URL: https://svnweb.freebsd.org/changeset/base/274122 Log: Extend struct ucred with group table. This saves one malloc + free with typical cases and better utilizes memory. Submitted by: Tiwei Bie (slightly modified)

svn commit: r274121 - head/lib/libdpv

2014-11-04 Thread Devin Teske
Author: dteske Date: Wed Nov 5 01:57:32 2014 New Revision: 274121 URL: https://svnweb.freebsd.org/changeset/base/274121 Log: Make libdpv [dpv(3)] WARNS=6 clean for clang on -CURRENT. NB: aka unbreak the build Reviewed by: shurd MFC after:21 days X-MFC-to: stable/10 stable/9

svn commit: r274120 - in head: lib/libdpv usr.bin/dpv

2014-11-04 Thread Devin Teske
Author: dteske Date: Wed Nov 5 01:47:25 2014 New Revision: 274120 URL: https://svnweb.freebsd.org/changeset/base/274120 Log: Fix build-error (pointy hat; didn't merge full up-to-date code) MFC after:21 days X-MFC-to: stable/10 stable/9 X-MFC-with: 274116 Modified: head/lib

svn commit: r274119 - head/usr.sbin/sysrc

2014-11-04 Thread Devin Teske
Author: dteske Date: Wed Nov 5 01:24:44 2014 New Revision: 274119 URL: https://svnweb.freebsd.org/changeset/base/274119 Log: Add EXAMPLES-section entry for new key+=append syntax of sysrc(8). MFC after:3 days X-MFC-to: stable/10 stable/9 X-MFC-with: 274068 Thanks to:@Se

Re: svn commit: r274103 - head/sys/dev/random

2014-11-04 Thread Dag-Erling Smørgrav
Ian Lepore writes: > Dag-Erling Smørgrav writes: > > +/* This implementation of Fortuna is based on the descriptions found in > > + * ISBN 0-471-22357-3 "Practical Cryptography" by Ferguson and Schneier > > + * ("K&S"). > I'm guessing s/b F&S. Uh, yes. Probably thinking of K&R :) Please feel f

svn commit: r274118 - in head/sys: kern netinet netinet6 sys

2014-11-04 Thread Alexander V. Chernikov
Author: melifaro Date: Wed Nov 5 00:58:01 2014 New Revision: 274118 URL: https://svnweb.freebsd.org/changeset/base/274118 Log: Remove old hack abusing domattach from NFS code. According to IANA RPC uaddr registry, there are no AFs except IPv4 and IPv6, so it's not worth being too abstrac

svn commit: r274117 - head/sys/dev/vt

2014-11-04 Thread Jean-Sebastien Pedron
Author: dumbbell Date: Tue Nov 4 23:51:35 2014 New Revision: 274117 URL: https://svnweb.freebsd.org/changeset/base/274117 Log: vt(4): Support syscons' SC_HISTORY_SIZE to configure history size Therefore, to set histry size to 2000 lines, add the following line to your kernel configuratio

svn commit: r274116 - in head: lib lib/libdpv lib/libfigpar share/mk sys/sys usr.bin usr.bin/dpv

2014-11-04 Thread Devin Teske
Author: dteske Date: Tue Nov 4 23:46:01 2014 New Revision: 274116 URL: https://svnweb.freebsd.org/changeset/base/274116 Log: Add new libraries/utilities for data throughput visualization. dpv(3): dialog progress view library dpv(1): stream data from stdin or multiple paths with dialog progr

Re: svn commit: r274103 - head/sys/dev/random

2014-11-04 Thread Ian Lepore
On Tue, 2014-11-04 at 23:02 +, Dag-Erling Smørgrav wrote: > Author: des > Date: Tue Nov 4 23:02:19 2014 > New Revision: 274103 > URL: https://svnweb.freebsd.org/changeset/base/274103 > > Log: > When reseeding the DPRNG, we're supposed to hash the current key and > some accumulated entropy

Re: svn commit: r272820 - head/etc/devd

2014-11-04 Thread Alexey Dokuchaev
On Thu, Oct 09, 2014 at 01:58:20PM +, Hans Petter Selasky wrote: > New Revision: 272820 > URL: https://svnweb.freebsd.org/changeset/base/272820 > > Log: > Add example devd configuration file for USB printers. > > +# Generic USB printer devices > +#notify 100 { > +#match "system"

svn commit: r274106 - in head: contrib/tnftp/src sys/kern

2014-11-04 Thread Dag-Erling Smørgrav
Author: des Date: Tue Nov 4 23:29:29 2014 New Revision: 274106 URL: https://svnweb.freebsd.org/changeset/base/274106 Log: [SA-14:25] Fix kernel stack disclosure in setlogin(2) / getlogin(2). [SA-14:26] Fix remote command execution in ftp(1). Approved by: so (des) Modified: head/contr

svn commit: r274105 - head/sys/dev/sound/pci

2014-11-04 Thread Baptiste Daroussin
Author: bapt Date: Tue Nov 4 23:10:58 2014 New Revision: 274105 URL: https://svnweb.freebsd.org/changeset/base/274105 Log: Partially fix indentation issues to improve readability helping cooperation with Dragonfly folks PR: 194785 Submitted by: François Tigeot (ftig...@wolfp

svn commit: r274103 - head/sys/dev/random

2014-11-04 Thread Dag-Erling Smørgrav
Author: des Date: Tue Nov 4 23:02:19 2014 New Revision: 274103 URL: https://svnweb.freebsd.org/changeset/base/274103 Log: When reseeding the DPRNG, we're supposed to hash the current key and some accumulated entropy twice and use that as the new key. Due to a typo, we were using the output

Re: svn commit: r274095 - head/release

2014-11-04 Thread Dmitry Morozovsky
On Tue, 4 Nov 2014, Dag-Erling Sm?rgrav wrote: > > Maybe then we could distinguish file system type given to makefs(8) and > > apply > > different check/sed rules depending on it? > > More work, more complexity, more opportunity for error, for - let's be > honest here - absolutely no gain. I d

Re: svn commit: r274095 - head/release

2014-11-04 Thread Dag-Erling Smørgrav
Dmitry Morozovsky writes: > Maybe then we could distinguish file system type given to makefs(8) and apply > different check/sed rules depending on it? More work, more complexity, more opportunity for error, for - let's be honest here - absolutely no gain. DES -- Dag-Erling Smørgrav - d...@des.

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Ian Lepore
On Wed, 2014-11-05 at 07:46 +1100, Bruce Evans wrote: > On Tue, 4 Nov 2014, Ian Lepore wrote: > > > On Wed, 2014-11-05 at 03:19 +1100, Bruce Evans wrote: > >> [...] > >> Another unsuitable alignment is by the MD ALIGNBYTES macro. This is > >> (sizeof(register_t) - 1) on all arches except mips 32-

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Bruce Evans
On Tue, 4 Nov 2014, Ian Lepore wrote: On Wed, 2014-11-05 at 03:19 +1100, Bruce Evans wrote: [...] Another unsuitable alignment is by the MD ALIGNBYTES macro. This is (sizeof(register_t) - 1) on all arches except mips 32-bit where it is 7 sparc64 where it is 15. On arm, it is 3, but arm also h

Re: svn commit: r274095 - head/release

2014-11-04 Thread Jung-uk Kim
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2014 15:24, Dmitry Morozovsky wrote: > On Tue, 4 Nov 2014, Jung-uk Kim wrote: > Log: Fix VOLUME_LABEL when BRANCH contains non-alpha characters, in particular '-' and '.'. >>> >>> [snip] >>> >>> By the way, what are original reaso

Re: svn commit: r274095 - head/release

2014-11-04 Thread Dmitry Morozovsky
On Tue, 4 Nov 2014, Jung-uk Kim wrote: > >> Log: Fix VOLUME_LABEL when BRANCH contains non-alpha characters, > >> in particular '-' and '.'. > > > > [snip] > > > > By the way, what are original reasons to not allow '-' and '_' in > > volume names? > > > > It looks a bit inconsistent with other fil

Re: svn commit: r274095 - head/release

2014-11-04 Thread Jung-uk Kim
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2014 14:45, Dmitry Morozovsky wrote: > On Tue, 4 Nov 2014, Glen Barber wrote: > >> Author: gjb Date: Tue Nov 4 17:24:13 2014 New Revision: 274095 >> URL: https://svnweb.freebsd.org/changeset/base/274095 >> >> Log: Fix VOLUME_LABEL when BRA

svn commit: r274100 - head/sys/vm

2014-11-04 Thread Konstantin Belousov
Author: kib Date: Tue Nov 4 19:56:04 2014 New Revision: 274100 URL: https://svnweb.freebsd.org/changeset/base/274100 Log: Fix mis-spelling of bits and types names in the default_pager_putpages() and swap_pager_putpages(). It is the same fix as was done for vnode_pager_putpages() in r27158

Re: svn commit: r274095 - head/release

2014-11-04 Thread Glen Barber
On Tue, Nov 04, 2014 at 10:45:27PM +0300, Dmitry Morozovsky wrote: > On Tue, 4 Nov 2014, Glen Barber wrote: > > > Author: gjb > > Date: Tue Nov 4 17:24:13 2014 > > New Revision: 274095 > > URL: https://svnweb.freebsd.org/changeset/base/274095 > > > > Log: > > Fix VOLUME_LABEL when BRANCH conta

Re: svn commit: r274095 - head/release

2014-11-04 Thread Dmitry Morozovsky
On Tue, 4 Nov 2014, Glen Barber wrote: > Author: gjb > Date: Tue Nov 4 17:24:13 2014 > New Revision: 274095 > URL: https://svnweb.freebsd.org/changeset/base/274095 > > Log: > Fix VOLUME_LABEL when BRANCH contains non-alpha > characters, in particular '-' and '.'. [snip] By the way, what ar

svn commit: r274099 - head/sys/vm

2014-11-04 Thread Alan Cox
Author: alc Date: Tue Nov 4 18:52:59 2014 New Revision: 274099 URL: https://svnweb.freebsd.org/changeset/base/274099 Log: Eliminate a stale, i386-specific comment. Modified: head/sys/vm/vm_page.c Modified: head/sys/vm/vm_page.c ===

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Bruce Evans
On Tue, 4 Nov 2014, Brooks Davis wrote: On Tue, Nov 04, 2014 at 06:41:44AM +0100, Mateusz Guzik wrote: re-sent with trimmed cc On Mon, Nov 03, 2014 at 07:35:56PM +, Poul-Henning Kamp wrote: In message <20141104045159.e1...@besplex.bde.org>, Bruce Evans writes: This optimization

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Ian Lepore
On Wed, 2014-11-05 at 03:19 +1100, Bruce Evans wrote: > [...] > Another unsuitable alignment is by the MD ALIGNBYTES macro. This is > (sizeof(register_t) - 1) on all arches except mips 32-bit where it is 7 > sparc64 where it is 15. On arm, it is 3, but arm also has > STACKALIGNBYTES = 7. The reg

svn commit: r274095 - head/release

2014-11-04 Thread Glen Barber
Author: gjb Date: Tue Nov 4 17:24:13 2014 New Revision: 274095 URL: https://svnweb.freebsd.org/changeset/base/274095 Log: Fix VOLUME_LABEL when BRANCH contains non-alpha characters, in particular '-' and '.'. Submitted by: des Tested by:des MFC after:3 days X-MFC-10.1: ye

Re: svn commit: r274086 - head/sbin/route

2014-11-04 Thread Bruce Evans
On Tue, 4 Nov 2014, David Chisnall wrote: On 4 Nov 2014, at 10:28, Stefan Farfeleder wrote: Shouldn't Coverity understand that err doesn't return? err() is marked as __dead2, which expands to __attribute__((__noreturn__)). If Coverity doesn't know that __attribute__((__noreturn__)) functi

svn commit: r274092 - in head: sys/kern tools/sched

2014-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 16:35:56 2014 New Revision: 274092 URL: https://svnweb.freebsd.org/changeset/base/274092 Log: Add a new thread state "spinning" to schedgraph and add tracepoints at the start and stop of spinning waits in lock primitives. Modified: head/sys/kern/kern_lock.c he

svn commit: r274091 - head/tools/sched

2014-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 16:30:42 2014 New Revision: 274091 URL: https://svnweb.freebsd.org/changeset/base/274091 Log: Bind Ctrl-Q as a global hotkey to exit. Bind Ctrl-W as a hotkey to close dialogs. Modified: head/tools/sched/schedgraph.py Modified: head/tools/sched/schedgraph.py ==

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Bruce Evans
On Tue, 4 Nov 2014, Mateusz Guzik wrote: On Tue, Nov 04, 2014 at 11:29:49AM +, Hans Petter Selasky wrote: Author: hselasky Date: Tue Nov 4 11:29:49 2014 New Revision: 274088 URL: https://svnweb.freebsd.org/changeset/base/274088 Log: Simplify logic a bit. Ensure data buffer is properly a

svn commit: r274090 - head/contrib/netbsd-tests/lib/libc/locale

2014-11-04 Thread Garrett Cooper
Author: ngie Date: Tue Nov 4 16:02:46 2014 New Revision: 274090 URL: https://svnweb.freebsd.org/changeset/base/274090 Log: Fix the Jenkins test run by skipping the negative testcases earlier The problem is that lib.libc.locale.t_io:bad_big5_wprintf was printing out illegal Unicode charac

Re: svn commit: r273653 - head/release

2014-11-04 Thread Dag-Erling Smørgrav
This works: Index: release/Makefile === --- release/Makefile.orig +++ release/Makefile @@ -56,10 +56,10 @@ .for _V in ${TARGET_ARCH} .if !empty(TARGET:M${_V}) OSRELEASE= ${TYPE}-${REVISION}-${BRANCH}-${TARGET} -VOLUME_LABEL= $

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Brooks Davis
On Tue, Nov 04, 2014 at 06:41:44AM +0100, Mateusz Guzik wrote: > re-sent with trimmed cc > > On Mon, Nov 03, 2014 at 07:35:56PM +, Poul-Henning Kamp wrote: > > > > In message <20141104045159.e1...@besplex.bde.org>, Bruce Evans writes: > > > > >This optimization is probably minor, but

Re: svn commit: r273653 - head/release

2014-11-04 Thread Dag-Erling Smørgrav
Dag-Erling Smørgrav writes: > Index: release/Makefile > === > --- release/Makefile.orig > +++ release/Makefile > @@ -56,10 +56,10 @@ > .for _V in ${TARGET_ARCH} > .if !empty(TARGET:M${_V}) > OSRELEASE= ${TYPE}-${REVISION}-${BRANC

Re: svn commit: r273653 - head/release

2014-11-04 Thread Dag-Erling Smørgrav
Glen Barber writes: > Modified: head/release/Makefile > == > --- head/release/Makefile Sun Oct 26 01:30:46 2014(r273652) > +++ head/release/Makefile Sun Oct 26 01:41:54 2014(r273653) > @@ -56,13 +56

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Alfred Perlstein
> On Nov 4, 2014, at 6:22 AM, Alfred Perlstein wrote: > > > >>> On Nov 4, 2014, at 1:25 AM, Konstantin Belousov wrote: >>> >>> On Mon, Nov 03, 2014 at 01:45:21PM -0800, Alfred Perlstein wrote: >>> Isn't there a problem where the stack can be swapped out? >>> >>> I seem to recall a problem

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Alfred Perlstein
> On Nov 4, 2014, at 1:25 AM, Konstantin Belousov wrote: > >> On Mon, Nov 03, 2014 at 01:45:21PM -0800, Alfred Perlstein wrote: >> Isn't there a problem where the stack can be swapped out? >> >> I seem to recall a problem where a swapped out process was causing >> problems due to a buffer pas

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Andrew Turner
On Tue, 4 Nov 2014 12:40:41 +0100 Mateusz Guzik wrote: > On Tue, Nov 04, 2014 at 11:29:49AM +, Hans Petter Selasky wrote: > > Author: hselasky > > Date: Tue Nov 4 11:29:49 2014 > > New Revision: 274088 > > URL: https://svnweb.freebsd.org/changeset/base/274088 > > > > Log: > > Simplify log

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Poul-Henning Kamp
In message <20141104053520.ga4...@dft-labs.eu>, Mateusz Guzik writes: >On Mon, Nov 03, 2014 at 07:35:56PM +, Poul-Henning Kamp wrote: >> >> In message <20141104045159.e1...@besplex.bde.org>, Bruce Evans writes: >> >> >This optimization is probably minor, but reminds me of oth

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Mateusz Guzik
On Mon, Nov 03, 2014 at 07:35:56PM +, Poul-Henning Kamp wrote: > > In message <20141104045159.e1...@besplex.bde.org>, Bruce Evans writes: > > >This optimization is probably minor, but reminds me of other syscalls > >that would benefit using a single largish allocation up front: > >- a

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Hans Petter Selasky
On 11/04/14 12:40, Mateusz Guzik wrote: On Tue, Nov 04, 2014 at 11:29:49AM +, Hans Petter Selasky wrote: Author: hselasky Date: Tue Nov 4 11:29:49 2014 New Revision: 274088 URL: https://svnweb.freebsd.org/changeset/base/274088 Log: Simplify logic a bit. Ensure data buffer is properly al

Re: svn commit: r274088 - head/sys/kern

2014-11-04 Thread Mateusz Guzik
On Tue, Nov 04, 2014 at 11:29:49AM +, Hans Petter Selasky wrote: > Author: hselasky > Date: Tue Nov 4 11:29:49 2014 > New Revision: 274088 > URL: https://svnweb.freebsd.org/changeset/base/274088 > > Log: > Simplify logic a bit. Ensure data buffer is properly aligned, > especially for plat

svn commit: r274088 - head/sys/kern

2014-11-04 Thread Hans Petter Selasky
Author: hselasky Date: Tue Nov 4 11:29:49 2014 New Revision: 274088 URL: https://svnweb.freebsd.org/changeset/base/274088 Log: Simplify logic a bit. Ensure data buffer is properly aligned, especially for platforms where unaligned access is not allowed. Make it possible to override the small

Re: svn commit: r274086 - head/sbin/route

2014-11-04 Thread David Chisnall
On 4 Nov 2014, at 10:28, Stefan Farfeleder wrote: > Shouldn't Coverity understand that err doesn't return? err() is marked as __dead2, which expands to __attribute__((__noreturn__)). If Coverity doesn't know that __attribute__((__noreturn__)) functions don't return, then that's a Coverity bug

Re: svn commit: r274086 - head/sbin/route

2014-11-04 Thread Stefan Farfeleder
On Tue, Nov 04, 2014 at 10:21:35AM +, Alexander V. Chernikov wrote: > Author: melifaro > Date: Tue Nov 4 10:21:34 2014 > New Revision: 274086 > URL: https://svnweb.freebsd.org/changeset/base/274086 > > Log: > Put "break" after err() to please coverity. > > Reported by:Coverity

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Konstantin Belousov
On Tue, Nov 04, 2014 at 06:03:29AM +1100, Bruce Evans wrote: > Why not just use a C99 VLA? It doesn't require any compiler magic except > being a C99 compiler (I haven't seen any of those yet, but some approximate > C99 for VLAs). I use this in delayed signal delivery code in libthr. > > You (ki

svn commit: r274087 - head/sys/netpfil/ipfw

2014-11-04 Thread Alexander V. Chernikov
Author: melifaro Date: Tue Nov 4 10:25:52 2014 New Revision: 274087 URL: https://svnweb.freebsd.org/changeset/base/274087 Log: Remove unused variable. Found by: Coverity CID: 1245739 Modified: head/sys/netpfil/ipfw/ip_fw_table.c Modified: head/sys/netpfil/ipfw/ip_fw_tabl

svn commit: r274086 - head/sbin/route

2014-11-04 Thread Alexander V. Chernikov
Author: melifaro Date: Tue Nov 4 10:21:34 2014 New Revision: 274086 URL: https://svnweb.freebsd.org/changeset/base/274086 Log: Put "break" after err() to please coverity. Reported by: Coverity CID: 1250795 Modified: head/sbin/route/route.c Modified: head/sbin/route/route.c

svn commit: r274085 - in head: . sys/kern sys/sys

2014-11-04 Thread Jean-Sebastien Pedron
) +++ head/UPDATING Tue Nov 4 10:18:03 2014(r274085) @@ -31,6 +31,24 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11 disable the most expensive debugging functionality run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) +20141104: + vt(4), th

Re: svn commit: r274040 - in head/sys: conf dev/agp

2014-11-04 Thread Konstantin Belousov
On Mon, Nov 03, 2014 at 07:50:15PM +0100, Tijl Coosemans wrote: > On Mon, 3 Nov 2014 11:49:36 + (UTC) Konstantin Belousov > wrote: > > Author: kib > > Date: Mon Nov 3 11:49:35 2014 > > New Revision: 274040 > > URL: https://svnweb.freebsd.org/changeset/base/274040 > > > > Log: > > agp_inte

svn commit: r274084 - head/sys/dev/agp

2014-11-04 Thread Konstantin Belousov
Author: kib Date: Tue Nov 4 09:56:58 2014 New Revision: 274084 URL: https://svnweb.freebsd.org/changeset/base/274084 Log: Revert agp_intel.c part of the r274040 for now. There is a confusion on my part about north bridge/GPU pci ids and use of aperture. Leave the agp_intel.c out of stat

Re: svn commit: r274017 - head/sys/kern

2014-11-04 Thread Konstantin Belousov
On Mon, Nov 03, 2014 at 01:45:21PM -0800, Alfred Perlstein wrote: > Isn't there a problem where the stack can be swapped out? > > I seem to recall a problem where a swapped out process was causing > problems due to a buffer passed being stack allocated and that process > being swapped out... >

Re: svn commit: r273958 - head/sys/dev/random

2014-11-04 Thread Konstantin Belousov
On Tue, Nov 04, 2014 at 02:59:17AM +1100, Bruce Evans wrote: > On Mon, 3 Nov 2014, Konstantin Belousov wrote: > > > On Mon, Nov 03, 2014 at 11:53:26AM +1100, Bruce Evans wrote: > >> On Sun, 2 Nov 2014, Ian Lepore wrote: > >> > >>> On Sun, 2014-11-02 at 12:27 -0800, Xin Li wrote: > -BEGIN

svn commit: r274083 - head/share/man/man4

2014-11-04 Thread John-Mark Gurney
Author: jmg Date: Tue Nov 4 08:22:08 2014 New Revision: 274083 URL: https://svnweb.freebsd.org/changeset/base/274083 Log: convert .Nm to proper .Xr's... Modified: head/share/man/man4/tap.4 Modified: head/share/man/man4/tap.4 ==