Author: ken
Date: Tue May 6 06:18:43 2014
New Revision: 265424
URL: http://svnweb.freebsd.org/changeset/base/265424
Log:
Fix a problem with async notifications in the mpr(4) driver.
This problem only occurs on versions of FreeBSD prior to the recent CAM
locking changes. (i.e. stable/9 a
On Tue, 6 May 2014, Andrey Chernov wrote:
On 06.05.2014 2:12, David Chisnall wrote:
On 5 May 2014, at 22:51, Andrey Chernov wrote:
For standard malloc/realloc interface it is up to the caller to check
n*size not overflows. You must trust caller already does such check.
Do a search of the C
While you are wandering around in the Makefiles, I was wondering
if you could estimate the amount of work to have the ability to
specify the location of the build toolchain a bit better..
Currently it's $(OBJPREFIX)/$(.CURDIR)/tmp or something
(different if cross compiling of course), but it'd
b
Author: imp
Date: Tue May 6 04:22:37 2014
New Revision: 265423
URL: http://svnweb.freebsd.org/changeset/base/265423
Log:
Remove support for WITHOUT_BMAKE. bmake is now the only make that can
build world, so it is the only make we build or install. fmake is
still in the tree, but disconnecte
expensive debugging functionality run
"ln -s 'abort:false,junk:false' /etc/malloc.conf".)
+20140505:
+ /etc/src.conf now affects only builds of the FreeBSD src tree. In the
+ past, it affected all builds that used the bsd.*.mk files. The old
+ behavior was a
Author: imp
Date: Tue May 6 04:22:01 2014
New Revision: 265420
URL: http://svnweb.freebsd.org/changeset/base/265420
Log:
Use src.opts.mk in preference to bsd.own.mk except where we need stuff
from the latter.
Modified:
head/Makefile.inc1
head/bin/Makefile
head/bin/Makefile.inc
head/b
Author: imp
Date: Tue May 6 04:21:48 2014
New Revision: 265419
URL: http://svnweb.freebsd.org/changeset/base/265419
Log:
Move the /usr/src specific options to src.opts.mk. Move inclusion of
/etc/src.conf to this file as well. Now, it will only affect builds of
/usr/src and not others that u
On 5/6/14, 12:19 AM, Neel Natu wrote:
Author: neel
Date: Mon May 5 16:19:24 2014
New Revision: 265364
URL: http://svnweb.freebsd.org/changeset/base/265364
Log:
Virtual machine halt detection is turned on by default. Allow it to be
disabled via the tunable 'hw.vmm.halt_detection'.
So this
On Tue, 6 May 2014, Andrey Chernov wrote:
On 05.05.2014 22:28, David Chisnall wrote:
On 5 May 2014, at 18:42, Andrey Chernov wrote:
Please don't commit OpenBSD errors. Now you mix calloc() with the
realloc() for the same variable later which makes calloc() zeroing
pointless and waste of CPU.
Author: alc
Date: Tue May 6 03:42:04 2014
New Revision: 265418
URL: http://svnweb.freebsd.org/changeset/base/265418
Log:
Prior to r254304, a separate function, vm_pageout_page_stats(), was used to
periodically update the reference status of the active pages. This function
was called, inste
Author: davidcs
Date: Tue May 6 02:32:27 2014
New Revision: 265411
URL: http://svnweb.freebsd.org/changeset/base/265411
Log:
Modify Copyright information to reflect Qlogic Corporation's purchase
of Broadcom's NetXtreme business
Submitted by:David C Somayajulu (davi...@freebsd.org) QLogic
Author: adrian
Date: Tue May 6 01:15:42 2014
New Revision: 265409
URL: http://svnweb.freebsd.org/changeset/base/265409
Log:
Modify the RX path to keep the previous RX descriptor around once it's
used.
It turns out that the RX DMA engine does the same last-descriptor-link-
pointer-re-re
On Mon, May 05, 2014 at 09:29:57PM +, Aleksandr Rybalko wrote:
> Author: ray
> Date: Mon May 5 21:29:56 2014
> New Revision: 265391
> URL: http://svnweb.freebsd.org/changeset/base/265391
>
> Log:
> Define a new method for probing vt(4) driver before attach it at early
> stage.
>
Can yo
Author: glebius
Date: Tue May 6 00:00:07 2014
New Revision: 265408
URL: http://svnweb.freebsd.org/changeset/base/265408
Log:
- Remove net.inet.tcp.reass.overflows sysctl. It counts exactly
same events that tcpstat's tcps_rcvmemdrop counter counts.
- Rename tcps_rcvmemdrop to tcps_rcvreass
Author: neel
Date: Mon May 5 23:54:13 2014
New Revision: 265407
URL: http://svnweb.freebsd.org/changeset/base/265407
Log:
Disable the 'uart_drain()' callback when the emulated receive FIFO is full.
Failing to do this will cause the kevent(2) notification to trigger
continuously and the b
Author: gjb
Date: Mon May 5 23:36:46 2014
New Revision: 265406
URL: http://svnweb.freebsd.org/changeset/base/265406
Log:
Use 'return' instead of 'exit' in main(), since the script exits
with the last returned exit code.
Sponsored by: The FreeBSD Foundation
Modified:
head/release/scrip
On 06.05.2014 2:59, Warner Losh wrote:
> Stupid is as stupid does. malloc and realloc both have this same issue. While
> an interesting theoretical attack, the size doesn’t necessarily come from
> multiplication. Careful coding is still required, not matter what spin you
> put on this. reallocf(
On 06.05.2014 2:52, Andrey Chernov wrote:
> As I mention initially, literal enough checks is what we need to make
> logic clear. In the case we discuss realloc() can be changed by
> reallocf() which does n*size and NULL checks and literal "if" should be
> added before malloc() to check overflow.
S
Author: gjb
Date: Mon May 5 23:01:01 2014
New Revision: 265405
URL: http://svnweb.freebsd.org/changeset/base/265405
Log:
Add a helper script for parsing 'svn log' for the
'Relnotes:' tag in case 'yes' is not explicitly
the first string value following the tab.
As it turns out, a number
On May 5, 2014, at 3:43 PM, David Chisnall wrote:
> On 5 May 2014, at 22:33, Warner Losh wrote:
>
>> reallocf():
>>The reallocf() function is identical to the realloc() function, except
>>that it will free the passed pointer when the requested memory cannot be
>>allocated. This is
On 06.05.2014 2:12, David Chisnall wrote:
> On 5 May 2014, at 22:51, Andrey Chernov wrote:
>
>> For standard malloc/realloc interface it is up to the caller to check
>> n*size not overflows. You must trust caller already does such check.
>
> Do a search of the CVE database sometime to see how we
On May 5, 2014, at 4:10 PM, Pedro Giffuni wrote:
> El 5/5/2014 4:21 PM, David Chisnall escribió:
>> On 5 May 2014, at 20:49, Pedro Giffuni wrote:
>>
>>> Yes, but I reverted it because there are other ways to check for overflows
>>> without the performance hit.
>>
>
> FWIW, in this particula
El 5/5/2014 4:21 PM, David Chisnall escribió:
On 5 May 2014, at 20:49, Pedro Giffuni wrote:
Yes, but I reverted it because there are other ways to check for overflows
without the performance hit.
FWIW, in this particular case I think the overflow simply doesn't
happen: apparently it is e
Author: ray
Date: Mon May 5 22:12:46 2014
New Revision: 265403
URL: http://svnweb.freebsd.org/changeset/base/265403
Log:
Switch vga drivers to use names and new vt(4) driver probe method.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/vt/hw/vga/vga.c
Modified: head/sys/dev
On 5 May 2014, at 22:51, Andrey Chernov wrote:
> For standard malloc/realloc interface it is up to the caller to check
> n*size not overflows. You must trust caller already does such check.
Do a search of the CVE database sometime to see how well placed that trust
generally is. Or even look at
Author: ray
Date: Mon May 5 22:10:31 2014
New Revision: 265402
URL: http://svnweb.freebsd.org/changeset/base/265402
Log:
Revert r264997 and r265026. It is not required anymore.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/vt/hw/vga/vga.c
Modified: head/sys/dev/vt/hw/vga/
Author: imp
Date: Mon May 5 22:03:01 2014
New Revision: 265400
URL: http://svnweb.freebsd.org/changeset/base/265400
Log:
Introduce CWARNFLAGS.${COMPILER_TYPE} and use that to simplify the
thicket of .if ${COMPILER_TYPE} == "clang" that controls
warnings. Also, use CFLAGS.clang in a couple p
Author: imp
Date: Mon May 5 22:03:08 2014
New Revision: 265401
URL: http://svnweb.freebsd.org/changeset/base/265401
Log:
Simplify use of the semi-bogus EARLY_BUILD variable. Also, simplify
use of semi-bogus NO_WARNS variable. Both of these, in this case,
should collapse to WITHOUT_WARNS in
Author: imp
Date: Mon May 5 22:02:48 2014
New Revision: 265399
URL: http://svnweb.freebsd.org/changeset/base/265399
Log:
[1] Make WITHOUT_FOO alway trump WITH_FOO, regardless of the system
default. This restores more of the historical expectations that
were broken when we started di
On 06.05.2014 1:52, David Chisnall wrote:
> This is not relying on undocumented intrinsic knowledge, this is relying on
> the standard library doing what is required of it. There is a reason why
> secure coding standards have, for over a decade, said to prefer calloc() over
> malloc() unless pr
On 5 May 2014, at 22:40, Andrey Chernov wrote:
> On 05.05.2014 22:28, David Chisnall wrote:
>> On 5 May 2014, at 18:42, Andrey Chernov wrote:
>>
>>> Please don't commit OpenBSD errors. Now you mix calloc() with the
>>> realloc() for the same variable later which makes calloc() zeroing
>>> point
On 06.05.2014 1:43, David Chisnall wrote:
> While reallocf() is nice, it doesn't address the problem of overflow. It
> takes a single size, forcing the caller to do the number-of-elements *
> element-size multiplication, which is the problematic one. If an attacker
> can control the number of
Author: ray
Date: Mon May 5 21:49:31 2014
New Revision: 265398
URL: http://svnweb.freebsd.org/changeset/base/265398
Log:
Add vt(4) driver name for ofwfb driver.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/vt/hw/ofwfb/ofwfb.c
Modified: head/sys/dev/vt/hw/ofwfb/ofwfb.c
==
Author: ray
Date: Mon May 5 21:48:19 2014
New Revision: 265397
URL: http://svnweb.freebsd.org/changeset/base/265397
Log:
Switch fb and efifb drivers to use names and new vt(4) driver probe method.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/vt/hw/efifb/efifb.c
head/sys
Author: rwatson
Date: Mon May 5 21:46:10 2014
New Revision: 265396
URL: http://svnweb.freebsd.org/changeset/base/265396
Log:
Garbage collect two more unused sysinit subsystems: SI_SUB_KVM_RSRC and
SI_SUB_CLISTS.
MFC after:3 days
Modified:
head/sys/sys/kernel.h
Modified: head/sys/
Author: ray
Date: Mon May 5 21:44:53 2014
New Revision: 265395
URL: http://svnweb.freebsd.org/changeset/base/265395
Log:
Set of updates to vt(4) core part.
o Declare vt(4) drivers dataset.
o Create single static structures for all early drivers.
o Add vt(4) to be by default in the kernel
On 5 May 2014, at 22:33, Warner Losh wrote:
> reallocf():
> The reallocf() function is identical to the realloc() function, except
> that it will free the passed pointer when the requested memory cannot be
> allocated. This is a FreeBSD specific API designed to ease the problems
>
On 05.05.2014 22:28, David Chisnall wrote:
> On 5 May 2014, at 18:42, Andrey Chernov wrote:
>
>> Please don't commit OpenBSD errors. Now you mix calloc() with the
>> realloc() for the same variable later which makes calloc() zeroing
>> pointless and waste of CPU.
>
> The purpose of calloc() here
Author: ray
Date: Mon May 5 21:31:00 2014
New Revision: 265392
URL: http://svnweb.freebsd.org/changeset/base/265392
Log:
Create dataset for vt(4) drivers.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/vt/vt.h
Modified: head/sys/dev/vt/vt.h
On May 5, 2014, at 3:21 PM, David Chisnall wrote:
> On 5 May 2014, at 20:49, Pedro Giffuni wrote:
>
>> Yes, but I reverted it because there are other ways to check for overflows
>> without the performance hit.
>
> Do we have a good reusable routine for doing this somewhere? Clang and gcc
>
Author: glebius
Date: Mon May 5 21:33:20 2014
New Revision: 265393
URL: http://svnweb.freebsd.org/changeset/base/265393
Log:
The tcp_log_addrs() uses th pointer, which points into the mbuf, thus we
can not free the mbuf before tcp_log_addrs().
Sponsored by: Nginx, Inc.
Sponsored by: Ne
Author: ray
Date: Mon May 5 21:29:56 2014
New Revision: 265391
URL: http://svnweb.freebsd.org/changeset/base/265391
Log:
Define a new method for probing vt(4) driver before attach it at early stage.
Sponsored by: The FreeBSD Foundation
Modified:
head/sys/dev/vt/vt.h
Modified: head/sys/
On 5 May 2014, at 20:49, Pedro Giffuni wrote:
> Yes, but I reverted it because there are other ways to check for overflows
> without the performance hit.
Do we have a good reusable routine for doing this somewhere? Clang and gcc
both have some idiom recognisers that try to spot when people ar
On May 5, 2014, at 8:31 AM, Hans Petter Selasky wrote:
> Author: hselasky
> Date: Mon May 5 14:31:34 2014
> New Revision: 265359
> URL: http://svnweb.freebsd.org/changeset/base/265359
>
> Log:
> Build the kernel sound module without ISA DMA support for ARM and MIPS
> platforms, because these
El 5/5/2014 1:28 PM, David Chisnall escribió:
On 5 May 2014, at 18:42, Andrey Chernov wrote:
Please don't commit OpenBSD errors. Now you mix calloc() with the
realloc() for the same variable later which makes calloc() zeroing
pointless and waste of CPU.
The purpose of calloc() here is not (p
Author: ken
Date: Mon May 5 19:53:03 2014
New Revision: 265386
URL: http://svnweb.freebsd.org/changeset/base/265386
Log:
Adjust #if statements inside mprsas_send_smpcmd() to more accurately
reflect when unmapped I/O support was added.
For FreeBSD 10, it arrived just prior to __FreeBSD_ve
s.inc
==
--- head/ObsoleteFiles.inc Mon May 5 19:35:32 2014(r265384)
+++ head/ObsoleteFiles.inc Mon May 5 19:38:29 2014(r265385)
@@ -38,6 +38,10 @@
# xargs -n1 | sort | uniq -d;
# done
+# 20140505: Reject PR kern/1
On 5 May 2014, at 18:42, Andrey Chernov wrote:
> Please don't commit OpenBSD errors. Now you mix calloc() with the
> realloc() for the same variable later which makes calloc() zeroing
> pointless and waste of CPU.
The purpose of calloc() here is not (primarily) to get the zero'd size, it's to
g
Author: neel
Date: Mon May 5 18:06:35 2014
New Revision: 265376
URL: http://svnweb.freebsd.org/changeset/base/265376
Log:
Modify the "-p" option to be more flexible when associating a 'vcpu' with
a 'hostcpu'. The new format of the argument string is "vcpu:hostcpu".
This allows pinning a
Author: pfg
Date: Mon May 5 18:04:57 2014
New Revision: 265375
URL: http://svnweb.freebsd.org/changeset/base/265375
Log:
Revert r265367:
Use of calloc instead of malloc in regex (from OpenBSD).
In this case the change makes no sense since we are using realloc() later.
Reported by:
On 05.05.2014 20:41, Pedro F. Giffuni wrote:
> Log:
> regex: Use calloc instead of malloc.
>
> Mostly to reduce differences with OpenBSD.
Please don't commit OpenBSD errors. Now you mix calloc() with the
realloc() for the same variable later which makes calloc() zeroing
pointless and waste
Author: tuexen
Date: Mon May 5 17:30:05 2014
New Revision: 265371
URL: http://svnweb.freebsd.org/changeset/base/265371
Log:
Fill in csum_data only for UDP or TCP packets. This fixes a bug where
SCTP were reported to have always a correct checksum if they don't
contain any ethernet padding.
Author: adrian
Date: Mon May 5 17:06:40 2014
New Revision: 265370
URL: http://svnweb.freebsd.org/changeset/base/265370
Log:
Wake up the hardware before calling ath_mode_init() in the ioctl() path.
Tested:
* AR5416, STA + powersave
Modified:
head/sys/dev/ath/if_ath.c
Modified: head
Author: pfg
Date: Mon May 5 16:41:15 2014
New Revision: 265367
URL: http://svnweb.freebsd.org/changeset/base/265367
Log:
regex: Use calloc instead of malloc.
Mostly to reduce differences with OpenBSD.
Obtained from:OpenBSD (CVS rev. 1.17)
MFC after:3 days
Modified:
he
Author: neel
Date: Mon May 5 16:35:37 2014
New Revision: 265366
URL: http://svnweb.freebsd.org/changeset/base/265366
Log:
Remove misleading "addcpu" in an error message emitted by fbsdrun_deletecpu().
Pointed out by: novel
Modified:
head/usr.sbin/bhyve/bhyverun.c
Modified: head/u
On Monday, May 05, 2014 11:59:31 am Don Lewis wrote:
> Author: truckman
> Date: Mon May 5 15:59:31 2014
> New Revision: 265363
> URL: http://svnweb.freebsd.org/changeset/base/265363
>
> Log:
> Avoid unsigned integer overflow which can cause
> rman_reserve_resource_bound() to return incorrect
Author: neel
Date: Mon May 5 16:30:03 2014
New Revision: 265365
URL: http://svnweb.freebsd.org/changeset/base/265365
Log:
Re-adding an event to a kqueue modifies the parameters of the original event.
However, if the original knote had been disabled then it is not automatically
re-enabled.
Author: neel
Date: Mon May 5 16:19:24 2014
New Revision: 265364
URL: http://svnweb.freebsd.org/changeset/base/265364
Log:
Virtual machine halt detection is turned on by default. Allow it to be
disabled via the tunable 'hw.vmm.halt_detection'.
Modified:
head/sys/amd64/vmm/vmm.c
Modified: h
Author: truckman
Date: Mon May 5 15:59:31 2014
New Revision: 265363
URL: http://svnweb.freebsd.org/changeset/base/265363
Log:
Avoid unsigned integer overflow which can cause
rman_reserve_resource_bound() to return incorrect results.
Continue the initial search until the first viable regi
Author: brueffer
Date: Mon May 5 14:57:38 2014
New Revision: 265362
URL: http://svnweb.freebsd.org/changeset/base/265362
Log:
Mention the axge(4) driver in the hardware notes.
MFC after:1 week
Modified:
head/release/doc/en_US.ISO8859-1/hardware/article.xml
Modified: head/release/do
Author: brueffer
Date: Mon May 5 14:50:44 2014
New Revision: 265360
URL: http://svnweb.freebsd.org/changeset/base/265360
Log:
Remove stray comma.
MFC after:3 days
Modified:
head/share/man/man4/tnt4882.4
Modified: head/share/man/man4/tnt4882.4
===
Author: hselasky
Date: Mon May 5 14:31:34 2014
New Revision: 265359
URL: http://svnweb.freebsd.org/changeset/base/265359
Log:
Build the kernel sound module without ISA DMA support for ARM and MIPS
platforms, because these platforms do not implement the ISA DMA
API. Else the sound modules ca
Author: hselasky
Date: Mon May 5 11:50:52 2014
New Revision: 265358
URL: http://svnweb.freebsd.org/changeset/base/265358
Log:
Improve DWC OTG USB host side support for isochronous FULL and HIGH
speed data traffic going directly to a USB device or through a
so-called USB transaction translat
Author: trasz
Date: Mon May 5 09:20:30 2014
New Revision: 265351
URL: http://svnweb.freebsd.org/changeset/base/265351
Log:
Make r242379 - the fix for UFS labels disappearing after resizing
the provider - also apply to UFS1 filesystems. This should help with
resizing filesystems created by
Author: adrian
Date: Mon May 5 08:12:21 2014
New Revision: 265350
URL: http://svnweb.freebsd.org/changeset/base/265350
Log:
Break out the multicast programming into its own hardware specific
call, which assumes the hardware is awake.
Turn ath_update_mcast() into a routine that's only cal
Author: adrian
Date: Mon May 5 08:00:50 2014
New Revision: 265349
URL: http://svnweb.freebsd.org/changeset/base/265349
Log:
Quieten the RX/TX descriptor and FIFO setup debugging.
Tested:
* AR9485, STA mode
Modified:
head/sys/dev/ath/if_ath_rx_edma.c
head/sys/dev/ath/if_ath_tx_edm
Author: adrian
Date: Mon May 5 07:58:05 2014
New Revision: 265348
URL: http://svnweb.freebsd.org/changeset/base/265348
Log:
Add Atheros AR support to the HAL.
This seems to probe/attach as an AR9485 and thus nothing else besides
adding the device id seems to be required.
ath0:
67 matches
Mail list logo
